linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Alexandre TORGUE <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-gpio@vger.kernel.org, arnd@arndb.de,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Daniel Thompson <daniel.thompson@linaro.org>,
	bruherrera@gmail.com, lee.jones@linaro.org
Subject: Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support
Date: Tue, 13 Sep 2016 17:21:26 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1609131713490.6233@nanos> (raw)
In-Reply-To: <1473432124-6784-3-git-send-email-alexandre.torgue@st.com>

On Fri, 9 Sep 2016, Alexandre TORGUE wrote:
> +static void stm32_exti_free(struct irq_domain *d, unsigned int virq,
> +			    unsigned int nr_irqs)
> +{
> +	struct irq_data *data = irq_get_irq_data(virq);
> +
> +	irq_gc_mask_clr_bit(data->parent_data);

I have a hard time to understand this. The irq domain is not hierarchical.

> +	irq_domain_reset_irq_data(data);

> +	domain = irq_domain_add_linear(node, nr_exti,
> +				       &irq_exti_domain_ops, NULL);

It's a simple linear domain. So how can data->parent_data be a valid
irq_data pointer? Answer: It can't!

But it doesn't blow up in your face simply because the alloc/free callbacks
are never invoked for simple non hierarchical domains. So you should have
removed that stuff after copying some other irqchip driver.

Thanks,

	tglx

  parent reply	other threads:[~2016-09-13 15:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 14:41 [PATCH v5 0/9] Add STM32 EXTI interrupt controller support Alexandre TORGUE
2016-09-09 14:41 ` [PATCH v5 1/9] Documentation: dt-bindings: Document STM32 EXTI controller bindings Alexandre TORGUE
2016-09-19 21:24   ` Rob Herring
2016-09-09 14:41 ` [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre TORGUE
2016-09-13  8:19   ` Marc Zyngier
2016-09-13 15:21   ` Thomas Gleixner [this message]
2016-09-13 16:29     ` Alexandre Torgue
2016-09-14  9:19       ` Thomas Gleixner
2016-09-14 13:05         ` Alexandre Torgue
2016-09-14 13:34           ` Thomas Gleixner
2016-09-14 13:44             ` Alexandre Torgue
2016-09-20  9:48               ` Alexandre Torgue
2016-09-20  9:51                 ` Thomas Gleixner
2016-09-20 12:40                   ` Alexandre Torgue
2016-09-20 12:44                     ` Thomas Gleixner
2016-09-20 13:33                       ` Alexandre Torgue
2016-09-20 14:02                         ` Thomas Gleixner
2016-09-20 15:28                           ` Alexandre Torgue
2016-09-20 15:36                             ` Thomas Gleixner
2016-09-09 14:41 ` [PATCH v5 3/9] ARM: STM32: Select external interrupts controller Alexandre TORGUE
2016-09-09 14:41 ` [PATCH v5 4/9] ARM: dts: Add EXTI controller node to stm32f429 Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl Alexandre TORGUE
2016-09-13  8:12   ` Linus Walleij
2016-09-13  8:18   ` Linus Walleij
2016-09-13 12:34     ` Alexandre Torgue
2016-09-13 12:47       ` Linus Walleij
2016-09-09 14:42 ` [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios Alexandre TORGUE
2016-09-13  8:14   ` Linus Walleij
2016-09-09 14:42 ` [PATCH v5 7/9] ARM: dts: Add GPIO irq support to STM2F429 Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 8/9] ARM: dts: Declare push button as GPIO key on stm32f429 boards Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 9/9] ARM: config: Enable GPIO Key driver in stm32_defconfig Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1609131713490.6233@nanos \
    --to=tglx@linutronix.de \
    --cc=alexandre.torgue@st.com \
    --cc=arnd@arndb.de \
    --cc=bruherrera@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).