From: Alexandre Torgue <alexandre.torgue@st.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, <linux-gpio@vger.kernel.org>,
<arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
<bruherrera@gmail.com>, <lee.jones@linaro.org>
Subject: Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support
Date: Wed, 14 Sep 2016 15:05:55 +0200 [thread overview]
Message-ID: <facd1c7c-d696-eae1-02e4-5a0c9285add0@st.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1609141103420.6233@nanos>
Hi Thomas,
On 09/14/2016 11:19 AM, Thomas Gleixner wrote:
> On Tue, 13 Sep 2016, Alexandre Torgue wrote:
>> On 09/13/2016 05:21 PM, Thomas Gleixner wrote:
>>> On Fri, 9 Sep 2016, Alexandre TORGUE wrote:
>>>> +static void stm32_exti_free(struct irq_domain *d, unsigned int virq,
>>>> + unsigned int nr_irqs)
>>>> +{
>>>> + struct irq_data *data = irq_get_irq_data(virq);
>>>> +
>>>> + irq_gc_mask_clr_bit(data->parent_data);
>>>
>>> I have a hard time to understand this. The irq domain is not hierarchical.
>>
>> Actually, I wanted to test ".free" callback function of gpio_irq_domain in
>> STM32 pinctrl driver. To do that I modified gpio driver: just after getting
>> virq through gpio_to_irq, I called "irq_dispose_mapping(virq)".
>> I know it is dirty but I thought it was the only way to test.
>>
>> Doing that, I see that ".free" callback of gpio domain is called but as it is
>> hirerchical ".free" callback for parent domain (exti one) is also called. I
>> observed that virq was well unmapped, but not masked at exti level. It is for
>> this reason than I added "irq_gc_mask_clr_bit(data->parent_data);" which mask
>> interrupt at exti level.
>
> Aargh. I really misread the patch, but this is entirely non obvious and you
> should do:
>
> struct irq_data *data = irq_domain_get_irq_data(d, virq);
>
> irq_gc_mask_clr_bit(d);
>
> Then it is entirely clear that you mask the interrupt of _this_ (the exti)
> domain.
Ok, it's easier to understand like that.
>
> Now what really bugs me is that you do that at all. An interrupt which is
> freed must be masked already. Why is it unmasked in the first place?
Honestly I don't know. When "devm_free_irq" is called to release virq,
there is no issue and interrupt is well masked. But, when I tried to use
"irq_dispose_mapping(virq)" I observed that .free is called (child and
parent domain) but interrupt is not masked.
Regards
Alex
>
> Thanks,
>
> tglx
>
next prev parent reply other threads:[~2016-09-14 13:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 14:41 [PATCH v5 0/9] Add STM32 EXTI interrupt controller support Alexandre TORGUE
2016-09-09 14:41 ` [PATCH v5 1/9] Documentation: dt-bindings: Document STM32 EXTI controller bindings Alexandre TORGUE
2016-09-19 21:24 ` Rob Herring
2016-09-09 14:41 ` [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support Alexandre TORGUE
2016-09-13 8:19 ` Marc Zyngier
2016-09-13 15:21 ` Thomas Gleixner
2016-09-13 16:29 ` Alexandre Torgue
2016-09-14 9:19 ` Thomas Gleixner
2016-09-14 13:05 ` Alexandre Torgue [this message]
2016-09-14 13:34 ` Thomas Gleixner
2016-09-14 13:44 ` Alexandre Torgue
2016-09-20 9:48 ` Alexandre Torgue
2016-09-20 9:51 ` Thomas Gleixner
2016-09-20 12:40 ` Alexandre Torgue
2016-09-20 12:44 ` Thomas Gleixner
2016-09-20 13:33 ` Alexandre Torgue
2016-09-20 14:02 ` Thomas Gleixner
2016-09-20 15:28 ` Alexandre Torgue
2016-09-20 15:36 ` Thomas Gleixner
2016-09-09 14:41 ` [PATCH v5 3/9] ARM: STM32: Select external interrupts controller Alexandre TORGUE
2016-09-09 14:41 ` [PATCH v5 4/9] ARM: dts: Add EXTI controller node to stm32f429 Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl Alexandre TORGUE
2016-09-13 8:12 ` Linus Walleij
2016-09-13 8:18 ` Linus Walleij
2016-09-13 12:34 ` Alexandre Torgue
2016-09-13 12:47 ` Linus Walleij
2016-09-09 14:42 ` [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios Alexandre TORGUE
2016-09-13 8:14 ` Linus Walleij
2016-09-09 14:42 ` [PATCH v5 7/9] ARM: dts: Add GPIO irq support to STM2F429 Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 8/9] ARM: dts: Declare push button as GPIO key on stm32f429 boards Alexandre TORGUE
2016-09-09 14:42 ` [PATCH v5 9/9] ARM: config: Enable GPIO Key driver in stm32_defconfig Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=facd1c7c-d696-eae1-02e4-5a0c9285add0@st.com \
--to=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=bruherrera@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).