* [PATCH] staging: xgifb: function definition argument should have an identifier name
@ 2017-02-21 18:08 Arushi Singhal
2017-02-21 18:13 ` [Outreachy kernel] " Julia Lawall
2017-02-21 20:50 ` kbuild test robot
0 siblings, 2 replies; 3+ messages in thread
From: Arushi Singhal @ 2017-02-21 18:08 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel, outreachy-kernel
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/xgifb/vb_setmode.h | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
index 6f082a7a5a4a..e4cf9a633676 100644
--- a/drivers/staging/xgifb/vb_setmode.h
+++ b/drivers/staging/xgifb/vb_setmode.h
@@ -1,14 +1,15 @@
#ifndef _VBSETMODE_
#define _VBSETMODE_
-void InitTo330Pointer(unsigned char, struct vb_device_info *);
-void XGI_UnLockCRT2(struct vb_device_info *);
-void XGI_LockCRT2(struct vb_device_info *);
-void XGI_DisplayOff(struct xgifb_video_info *,
- struct xgi_hw_device_info *,
- struct vb_device_info *);
-void XGI_GetVBType(struct vb_device_info *);
-void XGI_SenseCRT1(struct vb_device_info *);
+void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo);
+void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
+void XGI_LockCRT2(struct vb_device_info *pVBInfo);
+void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
+ struct xgi_hw_device_info *pXGIHWDE,
+ struct vb_device_info *pVBInfo);
+void XGI_GetVBType(struct vb_device_info *pVBInfo);
+ pVBInfo->VBInfo = DisableCRT2Display;
+void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
struct xgi_hw_device_info *HwDeviceExtension,
unsigned short ModeNo);
@@ -18,6 +19,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,
unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
unsigned short ModeNo,
unsigned short ModeIdIndex,
- struct vb_device_info *);
+ struct vb_device_info *pVBInfo);
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should have an identifier name
2017-02-21 18:08 [PATCH] staging: xgifb: function definition argument should have an identifier name Arushi Singhal
@ 2017-02-21 18:13 ` Julia Lawall
2017-02-21 20:50 ` kbuild test robot
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2017-02-21 18:13 UTC (permalink / raw)
To: Arushi Singhal
Cc: arnaud.patard, Greg Kroah-Hartman, devel, linux-kernel, outreachy-kernel
On Tue, 21 Feb 2017, Arushi Singhal wrote:
> function definition argument like 'struct vb_device_info *','unsigned
> long' etc. should have an identifier name.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/xgifb/vb_setmode.h | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
> index 6f082a7a5a4a..e4cf9a633676 100644
> --- a/drivers/staging/xgifb/vb_setmode.h
> +++ b/drivers/staging/xgifb/vb_setmode.h
> @@ -1,14 +1,15 @@
> #ifndef _VBSETMODE_
> #define _VBSETMODE_
>
> -void InitTo330Pointer(unsigned char, struct vb_device_info *);
> -void XGI_UnLockCRT2(struct vb_device_info *);
> -void XGI_LockCRT2(struct vb_device_info *);
> -void XGI_DisplayOff(struct xgifb_video_info *,
> - struct xgi_hw_device_info *,
> - struct vb_device_info *);
> -void XGI_GetVBType(struct vb_device_info *);
> -void XGI_SenseCRT1(struct vb_device_info *);
> +void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo);
> +void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
> +void XGI_LockCRT2(struct vb_device_info *pVBInfo);
> +void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
> + struct xgi_hw_device_info *pXGIHWDE,
> + struct vb_device_info *pVBInfo);
> +void XGI_GetVBType(struct vb_device_info *pVBInfo);
> + pVBInfo->VBInfo = DisableCRT2Display;
How does this like fit in?
I don't think this would have successfully compiled.
julia
> +void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
> unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
> struct xgi_hw_device_info *HwDeviceExtension,
> unsigned short ModeNo);
> @@ -18,6 +19,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,
> unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
> unsigned short ModeNo,
> unsigned short ModeIdIndex,
> - struct vb_device_info *);
> + struct vb_device_info *pVBInfo);
>
> #endif
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170221180852.GA19723%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: xgifb: function definition argument should have an identifier name
2017-02-21 18:08 [PATCH] staging: xgifb: function definition argument should have an identifier name Arushi Singhal
2017-02-21 18:13 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-21 20:50 ` kbuild test robot
1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2017-02-21 20:50 UTC (permalink / raw)
To: Arushi Singhal
Cc: kbuild-all, arnaud.patard, devel, Greg Kroah-Hartman,
linux-kernel, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]
Hi Arushi,
[auto build test ERROR on v4.9-rc8]
[cannot apply to staging/staging-testing next-20170220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-xgifb-function-definition-argument-should-have-an-identifier-name/20170222-031312
config: x86_64-randconfig-ne0-02220257 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from drivers/staging/xgifb/XGI_main_26.c:16:0:
>> drivers/staging/xgifb/vb_setmode.h:11:11: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
pVBInfo->VBInfo = DisableCRT2Display;
^~
vim +11 drivers/staging/xgifb/vb_setmode.h
5 void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
6 void XGI_LockCRT2(struct vb_device_info *pVBInfo);
7 void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
8 struct xgi_hw_device_info *pXGIHWDE,
9 struct vb_device_info *pVBInfo);
10 void XGI_GetVBType(struct vb_device_info *pVBInfo);
> 11 pVBInfo->VBInfo = DisableCRT2Display;
12 void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
13 unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
14 struct xgi_hw_device_info *HwDeviceExtension,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25266 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-21 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-21 18:08 [PATCH] staging: xgifb: function definition argument should have an identifier name Arushi Singhal
2017-02-21 18:13 ` [Outreachy kernel] " Julia Lawall
2017-02-21 20:50 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).