* [PATCH] staging: speakup: Avoid multiple assignments on same line
@ 2017-03-10 17:13 Arushi Singhal
2017-03-10 17:20 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Arushi Singhal @ 2017-03-10 17:13 UTC (permalink / raw)
To: w.d.hubbs
Cc: Chris Brannon, Kirk Reiser, Samuel Thibault, Greg Kroah-Hartman,
speakup, devel, linux-kernel, outreachy-kernel
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/speakup/main.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index c1c3ee7dc95a..6c21ae1ae2d3 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -269,9 +269,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
static void speakup_date(struct vc_data *vc)
{
- spk_x = spk_cx = vc->vc_x;
- spk_y = spk_cy = vc->vc_y;
- spk_pos = spk_cp = vc->vc_pos;
+ spk_x = vc->vc_x;
+ spk_cx = spk_x;
+ spk_y = vc->vc_y;
+ spk_cy = spk_y;
+ spk_pos = vc->vc_pos;
+ spk_cp = spk_pos;
spk_old_attr = spk_attr;
spk_attr = get_attributes(vc, (u_short *)spk_pos);
}
@@ -1643,9 +1646,12 @@ static int speak_highlight(struct vc_data *vc)
spk_do_flush();
spkup_write(speakup_console[vc_num]->ht.highbuf[hc],
speakup_console[vc_num]->ht.highsize[hc]);
- spk_pos = spk_cp = speakup_console[vc_num]->ht.rpos[hc];
- spk_x = spk_cx = speakup_console[vc_num]->ht.rx[hc];
- spk_y = spk_cy = speakup_console[vc_num]->ht.ry[hc];
+ spk_pos = speakup_console[vc_num]->ht.rpos[hc];
+ spk_cp = speakup_console[vc_num]->ht.rpos[hc];
+ spk_x = speakup_console[vc_num]->ht.rx[hc];
+ spk_cx = speakup_console[vc_num]->ht.rx[hc];
+ spk_y = speakup_console[vc_num]->ht.ry[hc];
+ spk_cy = speakup_console[vc_num]->ht.ry[hc];
return 1;
}
return 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: Avoid multiple assignments on same line
2017-03-10 17:13 [PATCH] staging: speakup: Avoid multiple assignments on same line Arushi Singhal
@ 2017-03-10 17:20 ` Julia Lawall
[not found] ` <3f1d5d12-ab81-46ae-84a7-9dd421baec05@googlegroups.com>
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2017-03-10 17:20 UTC (permalink / raw)
To: Arushi Singhal
Cc: w.d.hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup, devel, linux-kernel,
outreachy-kernel
On Fri, 10 Mar 2017, Arushi Singhal wrote:
> This patch fixes the checkpatch.pl warning "multiple assignments
> should be avoided."
Is this something that you have sent before that Greg asked you to resend?
It could be good to put RESEND in [PATCH] in that case.
julia
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/speakup/main.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index c1c3ee7dc95a..6c21ae1ae2d3 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -269,9 +269,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
>
> static void speakup_date(struct vc_data *vc)
> {
> - spk_x = spk_cx = vc->vc_x;
> - spk_y = spk_cy = vc->vc_y;
> - spk_pos = spk_cp = vc->vc_pos;
> + spk_x = vc->vc_x;
> + spk_cx = spk_x;
> + spk_y = vc->vc_y;
> + spk_cy = spk_y;
> + spk_pos = vc->vc_pos;
> + spk_cp = spk_pos;
> spk_old_attr = spk_attr;
> spk_attr = get_attributes(vc, (u_short *)spk_pos);
> }
> @@ -1643,9 +1646,12 @@ static int speak_highlight(struct vc_data *vc)
> spk_do_flush();
> spkup_write(speakup_console[vc_num]->ht.highbuf[hc],
> speakup_console[vc_num]->ht.highsize[hc]);
> - spk_pos = spk_cp = speakup_console[vc_num]->ht.rpos[hc];
> - spk_x = spk_cx = speakup_console[vc_num]->ht.rx[hc];
> - spk_y = spk_cy = speakup_console[vc_num]->ht.ry[hc];
> + spk_pos = speakup_console[vc_num]->ht.rpos[hc];
> + spk_cp = speakup_console[vc_num]->ht.rpos[hc];
> + spk_x = speakup_console[vc_num]->ht.rx[hc];
> + spk_cx = speakup_console[vc_num]->ht.rx[hc];
> + spk_y = speakup_console[vc_num]->ht.ry[hc];
> + spk_cy = speakup_console[vc_num]->ht.ry[hc];
> return 1;
> }
> return 0;
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170310171337.GA4940%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: Avoid multiple assignments on same line
[not found] ` <3f1d5d12-ab81-46ae-84a7-9dd421baec05@googlegroups.com>
@ 2017-03-10 18:23 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2017-03-10 18:23 UTC (permalink / raw)
To: Arushi Singhal
Cc: outreachy-kernel, w.d.hubbs, chris, kirk, samuel.thibault,
gregkh, speakup, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 4428 bytes --]
On Fri, 10 Mar 2017, Arushi Singhal wrote:
> Should I resend the patch
Maybe let it go. If Greg asked for a resend, he's probably fine with it
as is. It's more me who would rather know whether it is something I have
seen before :)
julia
>
> On Friday, March 10, 2017 at 10:50:28 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Fri, 10 Mar 2017, Arushi Singhal wrote:
>
> > This patch fixes the checkpatch.pl warning "multiple
> assignments
> > should be avoided."
>
> Is this something that you have sent before that Greg asked you
> to resend?
> It could be good to put RESEND in [PATCH] in that case.
>
> julia
>
> >
> > Signed-off-by: Arushi Singhal <arushising...@gmail.com>
> > ---
> > drivers/staging/speakup/main.c | 18 ++++++++++++------
> > 1 file changed, 12 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/main.c
> b/drivers/staging/speakup/main.c
> > index c1c3ee7dc95a..6c21ae1ae2d3 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -269,9 +269,12 @@ static unsigned char
> get_attributes(struct vc_data *vc, u16 *pos)
> >
> > static void speakup_date(struct vc_data *vc)
> > {
> > - spk_x = spk_cx = vc->vc_x;
> > - spk_y = spk_cy = vc->vc_y;
> > - spk_pos = spk_cp = vc->vc_pos;
> > + spk_x = vc->vc_x;
> > + spk_cx = spk_x;
> > + spk_y = vc->vc_y;
> > + spk_cy = spk_y;
> > + spk_pos = vc->vc_pos;
> > + spk_cp = spk_pos;
> > spk_old_attr = spk_attr;
> > spk_attr = get_attributes(vc, (u_short *)spk_pos);
> > }
> > @@ -1643,9 +1646,12 @@ static int speak_highlight(struct
> vc_data *vc)
> > spk_do_flush();
> >
> spkup_write(speakup_console[vc_num]->ht.highbuf[hc],
> >
> speakup_console[vc_num]->ht.highsize[hc]);
> > - spk_pos = spk_cp =
> speakup_console[vc_num]->ht.rpos[hc];
> > - spk_x = spk_cx =
> speakup_console[vc_num]->ht.rx[hc];
> > - spk_y = spk_cy =
> speakup_console[vc_num]->ht.ry[hc];
> > + spk_pos =
> speakup_console[vc_num]->ht.rpos[hc];
> > + spk_cp =
> speakup_console[vc_num]->ht.rpos[hc];
> > + spk_x = speakup_console[vc_num]->ht.rx[hc];
> > + spk_cx = speakup_console[vc_num]->ht.rx[hc];
> > + spk_y = speakup_console[vc_num]->ht.ry[hc];
> > + spk_cy = speakup_console[vc_num]->ht.ry[hc];
> > return 1;
> > }
> > return 0;
> > --
> > 2.11.0
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to outreachy-kern...@googlegroups.com.
> > To post to this group, send email to
> outreach...@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170310171337.GA4940%40
> arushi-HP-Pavilion-Notebook.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/3f1d5d12-ab81-46ae-84a7-
> 9dd421baec05%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-10 18:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 17:13 [PATCH] staging: speakup: Avoid multiple assignments on same line Arushi Singhal
2017-03-10 17:20 ` [Outreachy kernel] " Julia Lawall
[not found] ` <3f1d5d12-ab81-46ae-84a7-9dd421baec05@googlegroups.com>
2017-03-10 18:23 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).