linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer
@ 2017-04-14 21:12 kbuild test robot
  2017-04-15  5:40 ` Thomas Gleixner
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2017-04-14 21:12 UTC (permalink / raw)
  To: Vikas Shivappa; +Cc: kbuild-all, linux-kernel, tipbuild, Thomas Gleixner

[-- Attachment #1: Type: text/plain, Size: 6872 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
head:   64e8ed3d4a6dcd6139a869a3e760e625cb0d3022
commit: 05b93417ce5b924c6652de19fdcc27439ab37c90 [8/12] x86/intel_rdt/mba: Add primary support for Memory Bandwidth Allocation (MBA)
config: x86_64-randconfig-s0-04150438 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        git checkout 05b93417ce5b924c6652de19fdcc27439ab37c90
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

>> arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer
>> arch/x86/kernel/cpu/intel_rdt.c:63: warning: braces around scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:63: warning: (near initialization for 'rdt_resources_all[0].default_ctrl')
>> arch/x86/kernel/cpu/intel_rdt.c:64: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:64: error: (near initialization for 'rdt_resources_all[0].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:65: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:65: error: (near initialization for 'rdt_resources_all[0].default_ctrl')
>> arch/x86/kernel/cpu/intel_rdt.c:65: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:65: warning: (near initialization for 'rdt_resources_all[0].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:66: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:66: error: (near initialization for 'rdt_resources_all[0].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:66: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:66: warning: (near initialization for 'rdt_resources_all[0].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:75: error: unknown field 'cache' specified in initializer
   arch/x86/kernel/cpu/intel_rdt.c:75: warning: braces around scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:75: warning: (near initialization for 'rdt_resources_all[1].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:76: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:76: error: (near initialization for 'rdt_resources_all[1].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:77: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:77: error: (near initialization for 'rdt_resources_all[1].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:77: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:77: warning: (near initialization for 'rdt_resources_all[1].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:78: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:78: error: (near initialization for 'rdt_resources_all[1].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:78: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:78: warning: (near initialization for 'rdt_resources_all[1].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:87: error: unknown field 'cache' specified in initializer
   arch/x86/kernel/cpu/intel_rdt.c:87: warning: braces around scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:87: warning: (near initialization for 'rdt_resources_all[2].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:88: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:88: error: (near initialization for 'rdt_resources_all[2].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:89: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:89: error: (near initialization for 'rdt_resources_all[2].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:89: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:89: warning: (near initialization for 'rdt_resources_all[2].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:90: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:90: error: (near initialization for 'rdt_resources_all[2].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:90: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:90: warning: (near initialization for 'rdt_resources_all[2].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:99: error: unknown field 'cache' specified in initializer
   arch/x86/kernel/cpu/intel_rdt.c:99: warning: braces around scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:99: warning: (near initialization for 'rdt_resources_all[3].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:100: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:100: error: (near initialization for 'rdt_resources_all[3].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:101: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:101: error: (near initialization for 'rdt_resources_all[3].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:101: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:101: warning: (near initialization for 'rdt_resources_all[3].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:102: error: field name not in record or union initializer
   arch/x86/kernel/cpu/intel_rdt.c:102: error: (near initialization for 'rdt_resources_all[3].default_ctrl')
   arch/x86/kernel/cpu/intel_rdt.c:102: warning: excess elements in scalar initializer
   arch/x86/kernel/cpu/intel_rdt.c:102: warning: (near initialization for 'rdt_resources_all[3].default_ctrl')

vim +/cache +63 arch/x86/kernel/cpu/intel_rdt.c

c1c7c3f9 Fenghua Yu      2016-10-22  57  	{
c1c7c3f9 Fenghua Yu      2016-10-22  58  		.name			= "L3",
c1c7c3f9 Fenghua Yu      2016-10-22  59  		.domains		= domain_init(RDT_RESOURCE_L3),
c1c7c3f9 Fenghua Yu      2016-10-22  60  		.msr_base		= IA32_L3_CBM_BASE,
0921c547 Thomas Gleixner 2017-04-14  61  		.msr_update		= cat_wrmsr,
c1c7c3f9 Fenghua Yu      2016-10-22  62  		.cache_level		= 3,
d3e11b4d Thomas Gleixner 2017-04-14 @63  		.cache = {
d3e11b4d Thomas Gleixner 2017-04-14 @64  			.min_cbm_bits	= 1,
d3e11b4d Thomas Gleixner 2017-04-14 @65  			.cbm_idx_mult	= 1,
d3e11b4d Thomas Gleixner 2017-04-14  66  			.cbm_idx_offset	= 0,
d3e11b4d Thomas Gleixner 2017-04-14  67  		},
c1c7c3f9 Fenghua Yu      2016-10-22  68  	},

:::::: The code at line 63 was first introduced by commit
:::::: d3e11b4d6ffd363747ac6e6b5522baa9ca5a20c0 x86/intel_rdt: Move CBM specific data into a struct

:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20933 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer
  2017-04-14 21:12 [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer kbuild test robot
@ 2017-04-15  5:40 ` Thomas Gleixner
  2017-04-17  2:00   ` [kbuild-all] " Fengguang Wu
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2017-04-15  5:40 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Vikas Shivappa, kbuild-all, linux-kernel, tipbuild

On Sat, 15 Apr 2017, kbuild test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
> head:   64e8ed3d4a6dcd6139a869a3e760e625cb0d3022
> commit: 05b93417ce5b924c6652de19fdcc27439ab37c90 [8/12] x86/intel_rdt/mba: Add primary support for Memory Bandwidth Allocation (MBA)
> config: x86_64-randconfig-s0-04150438 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>         git checkout 05b93417ce5b924c6652de19fdcc27439ab37c90
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 

That's weird.

> c1c7c3f9 Fenghua Yu      2016-10-22  57  	{
> c1c7c3f9 Fenghua Yu      2016-10-22  58  		.name			= "L3",
> c1c7c3f9 Fenghua Yu      2016-10-22  59  		.domains		= domain_init(RDT_RESOURCE_L3),
> c1c7c3f9 Fenghua Yu      2016-10-22  60  		.msr_base		= IA32_L3_CBM_BASE,
> 0921c547 Thomas Gleixner 2017-04-14  61  		.msr_update		= cat_wrmsr,
> c1c7c3f9 Fenghua Yu      2016-10-22  62  		.cache_level		= 3,
> d3e11b4d Thomas Gleixner 2017-04-14 @63  		.cache = {
> d3e11b4d Thomas Gleixner 2017-04-14 @64  			.min_cbm_bits	= 1,
> d3e11b4d Thomas Gleixner 2017-04-14 @65  			.cbm_idx_mult	= 1,
> d3e11b4d Thomas Gleixner 2017-04-14  66  			.cbm_idx_offset	= 0,
> d3e11b4d Thomas Gleixner 2017-04-14  67  		},
> c1c7c3f9 Fenghua Yu      2016-10-22  68  	},
> 
> :::::: The code at line 63 was first introduced by commit
> :::::: d3e11b4d6ffd363747ac6e6b5522baa9ca5a20c0 x86/intel_rdt: Move CBM specific data into a struct
>

So the compiler fails to handle the anon union, which was introduced in
05b93417ce5b924. No idea why, but that concept is not new and widely used
in the kernel already.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kbuild-all] [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer
  2017-04-15  5:40 ` Thomas Gleixner
@ 2017-04-17  2:00   ` Fengguang Wu
  2017-04-17  8:11     ` Thomas Gleixner
  0 siblings, 1 reply; 4+ messages in thread
From: Fengguang Wu @ 2017-04-17  2:00 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: tipbuild, Vikas Shivappa, kbuild-all, linux-kernel

On Sat, Apr 15, 2017 at 07:40:34AM +0200, Thomas Gleixner wrote:
>On Sat, 15 Apr 2017, kbuild test robot wrote:
>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
>> head:   64e8ed3d4a6dcd6139a869a3e760e625cb0d3022
>> commit: 05b93417ce5b924c6652de19fdcc27439ab37c90 [8/12] x86/intel_rdt/mba: Add primary support for Memory Bandwidth Allocation (MBA)
>> config: x86_64-randconfig-s0-04150438 (attached as .config)
>> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
>> reproduce:
>>         git checkout 05b93417ce5b924c6652de19fdcc27439ab37c90
>>         # save the attached .config to linux build tree
>>         make ARCH=x86_64
>
>That's weird.
>
>> c1c7c3f9 Fenghua Yu      2016-10-22  57  	{
>> c1c7c3f9 Fenghua Yu      2016-10-22  58  		.name			= "L3",
>> c1c7c3f9 Fenghua Yu      2016-10-22  59  		.domains		= domain_init(RDT_RESOURCE_L3),
>> c1c7c3f9 Fenghua Yu      2016-10-22  60  		.msr_base		= IA32_L3_CBM_BASE,
>> 0921c547 Thomas Gleixner 2017-04-14  61  		.msr_update		= cat_wrmsr,
>> c1c7c3f9 Fenghua Yu      2016-10-22  62  		.cache_level		= 3,
>> d3e11b4d Thomas Gleixner 2017-04-14 @63  		.cache = {
>> d3e11b4d Thomas Gleixner 2017-04-14 @64  			.min_cbm_bits	= 1,
>> d3e11b4d Thomas Gleixner 2017-04-14 @65  			.cbm_idx_mult	= 1,
>> d3e11b4d Thomas Gleixner 2017-04-14  66  			.cbm_idx_offset	= 0,
>> d3e11b4d Thomas Gleixner 2017-04-14  67  		},
>> c1c7c3f9 Fenghua Yu      2016-10-22  68  	},
>>
>> :::::: The code at line 63 was first introduced by commit
>> :::::: d3e11b4d6ffd363747ac6e6b5522baa9ca5a20c0 x86/intel_rdt: Move CBM specific data into a struct
>>
>
>So the compiler fails to handle the anon union, which was introduced in
>05b93417ce5b924. No idea why, but that concept is not new and widely used
>in the kernel already.

It looks like a problem with gcc 4.4:

        Bug 42875 - gcc disallows named initializers for anonymous unions
        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42875
        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676

        gcc-4.4.3 lets you statically initialize named fields, and
        lets you assign to anonymous union members, but you cannot
        statically initialize a named member of an anonymous union.

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kbuild-all] [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer
  2017-04-17  2:00   ` [kbuild-all] " Fengguang Wu
@ 2017-04-17  8:11     ` Thomas Gleixner
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2017-04-17  8:11 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: tipbuild, Vikas Shivappa, kbuild-all, LKML, H. Peter Anvin

On Mon, 17 Apr 2017, Fengguang Wu wrote:
> > So the compiler fails to handle the anon union, which was introduced in
> > 05b93417ce5b924. No idea why, but that concept is not new and widely used
> > in the kernel already.
> 
> It looks like a problem with gcc 4.4:
> 
>        Bug 42875 - gcc disallows named initializers for anonymous unions
>        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42875
>        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
> 
>        gcc-4.4.3 lets you statically initialize named fields, and
>        lets you assign to anonymous union members, but you cannot
>        statically initialize a named member of an anonymous union.

Bah. I'll fix it up.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-04-17  8:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-14 21:12 [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer kbuild test robot
2017-04-15  5:40 ` Thomas Gleixner
2017-04-17  2:00   ` [kbuild-all] " Fengguang Wu
2017-04-17  8:11     ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).