linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>,
	jeffy.chen@rock-chips.com, linux-kernel@vger.kernel.org
Subject: Re: Suspend-resume failure on Intel Eagle Lake Core2Duo
Date: Fri, 28 Jul 2017 18:26:15 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1707281734240.1828@nanos> (raw)
In-Reply-To: <1d2c51f3-a655-2223-68a9-e6d700e7d8e1@intel.com>

On Fri, 28 Jul 2017, Tomi Sarvela wrote:
> On 28/07/17 17:50, Thomas Gleixner wrote:
> > On Fri, 28 Jul 2017, Tomi Sarvela wrote:
> > > On 28/07/17 17:13, Thomas Gleixner wrote:
> > > > On Fri, 28 Jul 2017, Tomi Sarvela wrote:
> > > > > On 28/07/17 16:15, Thomas Gleixner wrote:
> > > > > > Another question. Is the machine completely dead or not?
> > > > > 
> > > > > Completely dead. Powerled is on, so host isn't shut down.
> > > > 
> > > > So that means it does not even power the machine down. That's what I
> > > > expected least.
> > > > 
> > > > > Serial or network if don't give any signs of life.
> > > > 
> > > > > Patch applies cleanly but still getting the same error:
> > > > 
> > > > Sorry for the noise. I'm an idiot trying to do 10 things at once. This
> > > > time
> > > > it actually compiles and links.
> > > > 
> > > > If the machine does still not powerdown with this applied, then please
> > > > redo
> > > > the 'platform' test and grab the trace for that one.
> > > 
> > > This patch fixes the issue. Below is the dmesg from the testrun (sorry for
> > > the spam, we're primarily testing i915 issues).
> > 
> > Can you please retrieve the trace data from:
> > 
> > /sys/kernel/debug/tracing/trace
> > 
> > and provide that. The dmesg does not help much.
> 
> Right, here you go.

Thanks for providing the data. Just to be sure, that data was from a real
suspend, not the 'platform' test, right?

If so, that does not make any sense at all. The patch merily changes the
enable/resume path and adds the debug trace printks which have no influence
on the disable logic. But you said that the machine does not power off in
the bad case. That does not make any sense at all as the enable logic is
not involved at all in the suspend path.

Did you change anything else compared to the tests before ?

Thanks,

	tglx

  reply	other threads:[~2017-07-28 16:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 13:45 Suspend-resume failure on Intel Eagle Lake Core2Duo Martin Peres
2017-07-24 15:28 ` Thomas Gleixner
2017-07-24 15:41   ` Martin Peres
2017-07-24 16:35     ` Thomas Gleixner
2017-07-24 16:37       ` Martin Peres
2017-07-25  7:01         ` Tomi Sarvela
2017-07-26 13:47           ` Martin Peres
2017-07-26 14:26             ` Thomas Gleixner
2017-07-27  7:36               ` Tomi Sarvela
2017-07-27  7:42                 ` Thomas Gleixner
2017-07-27  8:12                   ` Tomi Sarvela
2017-07-27 19:42                     ` Thomas Gleixner
2017-07-27 20:13                       ` Thomas Gleixner
2017-07-27 21:08                         ` Thomas Gleixner
2017-07-28 12:29                           ` Tomi Sarvela
2017-07-28 12:42                             ` Thomas Gleixner
2017-07-28 13:15                               ` Thomas Gleixner
2017-07-28 13:25                                 ` Tomi Sarvela
2017-07-28 14:13                                   ` Thomas Gleixner
2017-07-28 14:46                                     ` Tomi Sarvela
2017-07-28 14:50                                       ` Thomas Gleixner
2017-07-28 14:55                                         ` Tomi Sarvela
2017-07-28 16:26                                           ` Thomas Gleixner [this message]
2017-07-31  7:21                                             ` Tomi Sarvela
2017-07-31  7:45                                               ` Thomas Gleixner
2017-07-31  7:55                                                 ` Tomi Sarvela
2017-07-31  8:29                                                   ` Thomas Gleixner
2017-07-31  8:41                                                     ` Tomi Sarvela
2017-07-31 14:04                                                       ` Thomas Gleixner
2017-07-31 14:13                                                         ` Tomi Sarvela
2017-07-31 15:06                                                   ` Thomas Gleixner
2017-07-31 15:44                                                     ` Tomi Sarvela
2017-07-31 15:55                                                       ` Thomas Gleixner
2017-08-03  7:32                                                         ` Masahiro Yamada
2017-08-03  8:23                                                           ` Peter Zijlstra
2017-08-03  8:41                                                           ` Marc Zyngier
2017-08-03 12:52                                                             ` Masahiro Yamada
2017-08-03 13:30                                                               ` Marc Zyngier
2017-08-07  4:45                                                                 ` Masahiro Yamada
2017-08-07  8:17                                                                   ` Marc Zyngier
2017-08-08  1:30                                                                     ` Masahiro Yamada
2017-08-08  7:39                                                                       ` Marc Zyngier
2017-08-09  4:03                                                                         ` Masahiro Yamada
2017-07-31  8:35                                           ` Thomas Gleixner
2017-07-28 12:34                 ` Martin Peres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1707281734240.1828@nanos \
    --to=tglx@linutronix.de \
    --cc=jeffy.chen@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.peres@linux.intel.com \
    --cc=tomi.p.sarvela@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).