* [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile
@ 2017-11-14 9:47 Masahiro Yamada
2017-11-14 9:54 ` Julia Lawall
2017-11-16 0:52 ` Masahiro Yamada
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-11-14 9:47 UTC (permalink / raw)
To: linux-kbuild
Cc: cocci, Julia Lawall, Nicolas Palix, Gilles Muller,
Masahiro Yamada, Michal Marek, linux-kernel
I do not think it is helpful to have a separate file just for the
coccicheck help message. Merge scripts/Makefile.help into the
top-level Makefile.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Makefile | 2 +-
scripts/Makefile.help | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
delete mode 100644 scripts/Makefile.help
diff --git a/Makefile b/Makefile
index f060f94..3b7d477 100644
--- a/Makefile
+++ b/Makefile
@@ -1388,7 +1388,7 @@ help:
@echo ' export_report - List the usages of all exported symbols'
@echo ' headers_check - Sanity check on exported headers'
@echo ' headerdep - Detect inclusion cycles in headers'
- @$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
+ @echo ' coccicheck - Check with Coccinelle'
@echo ''
@echo 'Kernel selftest:'
@echo ' kselftest - Build and run kernel selftest (run as root)'
diff --git a/scripts/Makefile.help b/scripts/Makefile.help
deleted file mode 100644
index d03608f..0000000
--- a/scripts/Makefile.help
+++ /dev/null
@@ -1,3 +0,0 @@
-
-checker-help:
- @echo ' coccicheck - Check with Coccinelle.'
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile
2017-11-14 9:47 [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile Masahiro Yamada
@ 2017-11-14 9:54 ` Julia Lawall
2017-11-16 0:52 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2017-11-14 9:54 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, cocci, Julia Lawall, Nicolas Palix, Gilles Muller,
Michal Marek, linux-kernel
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> I do not think it is helpful to have a separate file just for the
> coccicheck help message. Merge scripts/Makefile.help into the
> top-level Makefile.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Thanks!
> ---
>
> Makefile | 2 +-
> scripts/Makefile.help | 3 ---
> 2 files changed, 1 insertion(+), 4 deletions(-)
> delete mode 100644 scripts/Makefile.help
>
> diff --git a/Makefile b/Makefile
> index f060f94..3b7d477 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1388,7 +1388,7 @@ help:
> @echo ' export_report - List the usages of all exported symbols'
> @echo ' headers_check - Sanity check on exported headers'
> @echo ' headerdep - Detect inclusion cycles in headers'
> - @$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
> + @echo ' coccicheck - Check with Coccinelle'
> @echo ''
> @echo 'Kernel selftest:'
> @echo ' kselftest - Build and run kernel selftest (run as root)'
> diff --git a/scripts/Makefile.help b/scripts/Makefile.help
> deleted file mode 100644
> index d03608f..0000000
> --- a/scripts/Makefile.help
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -
> -checker-help:
> - @echo ' coccicheck - Check with Coccinelle.'
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile
2017-11-14 9:47 [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile Masahiro Yamada
2017-11-14 9:54 ` Julia Lawall
@ 2017-11-16 0:52 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-11-16 0:52 UTC (permalink / raw)
To: Linux Kbuild mailing list
Cc: cocci, Julia Lawall, Nicolas Palix, Gilles Muller,
Masahiro Yamada, Michal Marek, Linux Kernel Mailing List
2017-11-14 18:47 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> I do not think it is helpful to have a separate file just for the
> coccicheck help message. Merge scripts/Makefile.help into the
> top-level Makefile.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
Applied to linux-kbuild/kbuild.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-16 0:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 9:47 [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile Masahiro Yamada
2017-11-14 9:54 ` Julia Lawall
2017-11-16 0:52 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).