* [PATCH] HV: Fix definition of struct hv_vp_assist_page.
@ 2018-05-21 9:25 Tianyu Lan
2018-06-06 10:17 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Tianyu Lan @ 2018-05-21 9:25 UTC (permalink / raw)
Cc: Tianyu Lan, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
tglx, mingo, hpa, x86, vkuznets, Alexander Grest, devel,
linux-kernel
The struct hv_vp_assist_page was defined incorrectly.
The "vtl_control" should be u64[3], "nested_enlightenments_control"
should be a u64 and there is 7 reserved bytes following "enlighten_vmentry".
This patch is to fix it.
Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
---
arch/x86/include/asm/hyperv-tlfs.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h
index f7be6d03a310..fae0a5431cdd 100644
--- a/arch/x86/include/asm/hyperv-tlfs.h
+++ b/arch/x86/include/asm/hyperv-tlfs.h
@@ -496,10 +496,11 @@ struct hv_timer_message_payload {
/* Define virtual processor assist page structure. */
struct hv_vp_assist_page {
__u32 apic_assist;
- __u32 reserved;
- __u64 vtl_control[2];
- __u64 nested_enlightenments_control[2];
- __u32 enlighten_vmentry;
+ __u32 reserved1;
+ __u64 vtl_control[3];
+ __u64 nested_enlightenments_control;
+ __u8 enlighten_vmentry;
+ __u8 reserved2[7];
__u64 current_nested_vmcs;
};
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HV: Fix definition of struct hv_vp_assist_page.
2018-05-21 9:25 [PATCH] HV: Fix definition of struct hv_vp_assist_page Tianyu Lan
@ 2018-06-06 10:17 ` Thomas Gleixner
2018-06-06 22:41 ` KY Srinivasan
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2018-06-06 10:17 UTC (permalink / raw)
To: Tianyu Lan
Cc: KY Srinivasan, Haiyang Zhang, Stephen Hemminger, mingo, hpa, x86,
vkuznets, Alexander Grest, devel, linux-kernel
On Mon, 21 May 2018, Tianyu Lan wrote:
KY ????
> The struct hv_vp_assist_page was defined incorrectly.
> The "vtl_control" should be u64[3], "nested_enlightenments_control"
> should be a u64 and there is 7 reserved bytes following "enlighten_vmentry".
> This patch is to fix it.
>
> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
> ---
> arch/x86/include/asm/hyperv-tlfs.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h
> index f7be6d03a310..fae0a5431cdd 100644
> --- a/arch/x86/include/asm/hyperv-tlfs.h
> +++ b/arch/x86/include/asm/hyperv-tlfs.h
> @@ -496,10 +496,11 @@ struct hv_timer_message_payload {
> /* Define virtual processor assist page structure. */
> struct hv_vp_assist_page {
> __u32 apic_assist;
> - __u32 reserved;
> - __u64 vtl_control[2];
> - __u64 nested_enlightenments_control[2];
> - __u32 enlighten_vmentry;
> + __u32 reserved1;
> + __u64 vtl_control[3];
> + __u64 nested_enlightenments_control;
> + __u8 enlighten_vmentry;
> + __u8 reserved2[7];
> __u64 current_nested_vmcs;
> };
>
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] HV: Fix definition of struct hv_vp_assist_page.
2018-06-06 10:17 ` Thomas Gleixner
@ 2018-06-06 22:41 ` KY Srinivasan
0 siblings, 0 replies; 3+ messages in thread
From: KY Srinivasan @ 2018-06-06 22:41 UTC (permalink / raw)
To: Thomas Gleixner, Tianyu Lan, Allen Marshall
Cc: Haiyang Zhang, Stephen Hemminger, mingo, hpa, x86, vkuznets,
Alexander Grest, devel, linux-kernel
+Allen
> -----Original Message-----
> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Wednesday, June 6, 2018 3:18 AM
> To: Tianyu Lan <Tianyu.Lan@microsoft.com>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; mingo@redhat.com; hpa@zytor.com;
> x86@kernel.org; vkuznets@redhat.com; Alexander Grest
> <Alexander.Grest@microsoft.com>; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] HV: Fix definition of struct hv_vp_assist_page.
>
> On Mon, 21 May 2018, Tianyu Lan wrote:
>
> KY ????
I am looking at the published Hyper-V Top Level Functional Spec now; will get back shortly.
>
> > The struct hv_vp_assist_page was defined incorrectly.
> > The "vtl_control" should be u64[3], "nested_enlightenments_control"
> > should be a u64 and there is 7 reserved bytes following
> "enlighten_vmentry".
> > This patch is to fix it.
> >
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
> > ---
> > arch/x86/include/asm/hyperv-tlfs.h | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/hyperv-tlfs.h
> b/arch/x86/include/asm/hyperv-tlfs.h
> > index f7be6d03a310..fae0a5431cdd 100644
> > --- a/arch/x86/include/asm/hyperv-tlfs.h
> > +++ b/arch/x86/include/asm/hyperv-tlfs.h
> > @@ -496,10 +496,11 @@ struct hv_timer_message_payload {
> > /* Define virtual processor assist page structure. */
> > struct hv_vp_assist_page {
> > __u32 apic_assist;
> > - __u32 reserved;
> > - __u64 vtl_control[2];
> > - __u64 nested_enlightenments_control[2];
> > - __u32 enlighten_vmentry;
> > + __u32 reserved1;
> > + __u64 vtl_control[3];
> > + __u64 nested_enlightenments_control;
> > + __u8 enlighten_vmentry;
> > + __u8 reserved2[7];
> > __u64 current_nested_vmcs;
> > };
> >
> > --
> > 2.14.3
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-06 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-21 9:25 [PATCH] HV: Fix definition of struct hv_vp_assist_page Tianyu Lan
2018-06-06 10:17 ` Thomas Gleixner
2018-06-06 22:41 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).