From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch -mm] mm, oom: remove oom_lock from exit_mmap
Date: Mon, 16 Jul 2018 21:14:29 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1807162111490.157949@chino.kir.corp.google.com> (raw)
In-Reply-To: <20180713142612.GD19960@dhcp22.suse.cz>
On Fri, 13 Jul 2018, Michal Hocko wrote:
> > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> > index 0fe4087d5151..e6328cef090f 100644
> > --- a/mm/oom_kill.c
> > +++ b/mm/oom_kill.c
> > @@ -488,9 +488,11 @@ void __oom_reap_task_mm(struct mm_struct *mm)
> > * Tell all users of get_user/copy_from_user etc... that the content
> > * is no longer stable. No barriers really needed because unmapping
> > * should imply barriers already and the reader would hit a page fault
> > - * if it stumbled over a reaped memory.
> > + * if it stumbled over a reaped memory. If MMF_UNSTABLE is already set,
> > + * reaping as already occurred so nothing left to do.
> > */
> > - set_bit(MMF_UNSTABLE, &mm->flags);
> > + if (test_and_set_bit(MMF_UNSTABLE, &mm->flags))
> > + return;
>
> This could lead to pre mature oom victim selection
> oom_reaper exiting victim
> oom_reap_task exit_mmap
> __oom_reap_task_mm __oom_reap_task_mm
> test_and_set_bit(MMF_UNSTABLE) # wins the race
> test_and_set_bit(MMF_UNSTABLE)
> set_bit(MMF_OOM_SKIP) # new victim can be selected now.
>
This is not the current state of the code in the -mm tree: MMF_OOM_SKIP
only gets set by the oom reaper when the timeout has expired when the
victim has failed to free memory in the exit path.
> Besides that, why should we back off in the first place. We can
> race the two without any problems AFAICS. We already do have proper
> synchronization between the two due to mmap_sem and MMF_OOM_SKIP.
>
test_and_set_bit() here is not strictly required, I thought it was better
since any unmapping done in this context is going to be handled by
whichever thread set MMF_UNSTABLE.
prev parent reply other threads:[~2018-07-17 4:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 21:34 [patch -mm] mm, oom: remove oom_lock from exit_mmap David Rientjes
2018-07-13 6:20 ` Tetsuo Handa
2018-07-13 14:26 ` Michal Hocko
2018-07-13 21:18 ` Tetsuo Handa
2018-07-16 6:13 ` Michal Hocko
2018-07-16 7:04 ` Tetsuo Handa
2018-07-16 7:44 ` Michal Hocko
2018-07-16 10:38 ` Tetsuo Handa
2018-07-16 11:15 ` Michal Hocko
2018-07-17 4:22 ` David Rientjes
2018-07-17 4:14 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807162111490.157949@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).