From: Thomas Gleixner <tglx@linutronix.de>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: hpa@zytor.com, david.laight@aculab.com,
LKML <linux-kernel@vger.kernel.org>,
jdelvare@suse.de, Ingo Molnar <mingo@kernel.org>,
linux-tip-commits@vger.kernel.org, sedat.dilek@gmail.com
Subject: Re: [tip:x86/urgent] x86/irqflags: Provide a declaration for native_save_fl
Date: Tue, 7 Aug 2018 18:57:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1808071854590.5883@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAKwvOdnXqw_ZXD2tnPYdVdRtdKqi4hK5mLZ7ELyXMhrbNzyWfw@mail.gmail.com>
On Tue, 7 Aug 2018, Nick Desaulniers wrote:
> On Tue, Aug 7, 2018 at 12:29 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Mon, 6 Aug 2018, Nick Desaulniers wrote:
> > > also, there were tested by's reported:
> > >
> > > Tested-by: David Laight <david.laight@acuab.com>
> > > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> >
> > Which came in after I applied it....
>
> I've seen other maintainers revise commit messages before sending pull
> requests along, but I guess that's problematic as anyone else who has
> pulled before the revision would then have a merge conflict.
In general I avoid redoing commits for that reason and others and one of
the reasons why we have the Link: tag in the commit message is to be able
to look up such additional information easily - assumed that the archives
have not vanished from the planet.
Thanks,
tglx
next prev parent reply other threads:[~2018-08-07 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 13:10 native_save_fl() causes a warning Jean Delvare
2018-08-03 16:38 ` Nick Desaulniers
2018-08-03 17:05 ` [PATCH] x86/irqflags: provide a declaration for native_save_fl Nick Desaulniers
2018-08-05 20:33 ` [tip:x86/urgent] x86/irqflags: Provide " tip-bot for Nick Desaulniers
2018-08-06 21:33 ` Nick Desaulniers
2018-08-07 7:29 ` Thomas Gleixner
2018-08-07 16:46 ` Nick Desaulniers
2018-08-07 16:57 ` Thomas Gleixner [this message]
2018-08-06 10:25 ` [PATCH] x86/irqflags: provide " David Laight
2018-08-06 10:38 ` Sedat Dilek
2018-08-03 17:49 ` native_save_fl() causes a warning Alistair Strachan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1808071854590.5883@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=david.laight@aculab.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).