linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Nick Desaulniers <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, jdelvare@suse.de, ndesaulniers@google.com,
	hpa@zytor.com, tglx@linutronix.de, david.laight@aculab.com,
	linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86/irqflags: Provide a declaration for native_save_fl
Date: Sun, 5 Aug 2018 13:33:49 -0700	[thread overview]
Message-ID: <tip-208cbb32558907f68b3b2a081ca2337ac3744794@git.kernel.org> (raw)
In-Reply-To: <20180803170550.164688-1-ndesaulniers@google.com>

Commit-ID:  208cbb32558907f68b3b2a081ca2337ac3744794
Gitweb:     https://git.kernel.org/tip/208cbb32558907f68b3b2a081ca2337ac3744794
Author:     Nick Desaulniers <ndesaulniers@google.com>
AuthorDate: Fri, 3 Aug 2018 10:05:50 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 5 Aug 2018 22:30:37 +0200

x86/irqflags: Provide a declaration for native_save_fl

It was reported that the commit d0a8d9378d16 is causing users of gcc < 4.9
to observe -Werror=missing-prototypes errors.

Indeed, it seems that:
extern inline unsigned long native_save_fl(void) { return 0; }

compiled with -Werror=missing-prototypes produces this warning in gcc <
4.9, but not gcc >= 4.9.

Fixes: d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
Reported-by: David Laight <david.laight@aculab.com>
Reported-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: hpa@zytor.com
Cc: jgross@suse.com
Cc: kstewart@linuxfoundation.org
Cc: gregkh@linuxfoundation.org
Cc: boris.ostrovsky@oracle.com
Cc: astrachan@google.com
Cc: mka@chromium.org
Cc: arnd@arndb.de
Cc: tstellar@redhat.com
Cc: sedat.dilek@gmail.com
Cc: David.Laight@aculab.com
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20180803170550.164688-1-ndesaulniers@google.com

---
 arch/x86/include/asm/irqflags.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index c4fc17220df9..c14f2a74b2be 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -13,6 +13,8 @@
  * Interrupt control:
  */
 
+/* Declaration required for gcc < 4.9 to prevent -Werror=missing-prototypes */
+extern inline unsigned long native_save_fl(void);
 extern inline unsigned long native_save_fl(void)
 {
 	unsigned long flags;

  reply	other threads:[~2018-08-05 20:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 13:10 native_save_fl() causes a warning Jean Delvare
2018-08-03 16:38 ` Nick Desaulniers
2018-08-03 17:05   ` [PATCH] x86/irqflags: provide a declaration for native_save_fl Nick Desaulniers
2018-08-05 20:33     ` tip-bot for Nick Desaulniers [this message]
2018-08-06 21:33       ` [tip:x86/urgent] x86/irqflags: Provide " Nick Desaulniers
2018-08-07  7:29         ` Thomas Gleixner
2018-08-07 16:46           ` Nick Desaulniers
2018-08-07 16:57             ` Thomas Gleixner
2018-08-06 10:25     ` [PATCH] x86/irqflags: provide " David Laight
2018-08-06 10:38       ` Sedat Dilek
2018-08-03 17:49   ` native_save_fl() causes a warning Alistair Strachan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-208cbb32558907f68b3b2a081ca2337ac3744794@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=david.laight@aculab.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).