From: Vince Weaver <vincent.weaver@maine.edu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
linux-kernel@vger.kernel.org,
Josh Poimboeuf <jpoimboe@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [perf] perf_event.h ABI visibility question
Date: Tue, 28 Aug 2018 13:51:29 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1808281349210.21658@macbook-air> (raw)
In-Reply-To: <20180827075246.GX24124@hirez.programming.kicks-ass.net>
On Mon, 27 Aug 2018, Peter Zijlstra wrote:
> Something like so then?
>
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index eeb787b1c53c..f35eb72739c0 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -144,7 +144,7 @@ enum perf_event_sample_format {
>
> PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */
>
> - __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63,
> + __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, /* non-ABI; internal use */
> };
yes, something like that would be fine.
I am being difficult about this, but from experience when trying to keep
the manpage updated, what seems obvious now will not be so obvious 6
months from now and trying to dig through the git logs / mailing list
archives to verify the purpose of an addition can be a lot of work
sometimes.
Vince
next prev parent reply other threads:[~2018-08-28 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 18:25 [perf] perf_event.h ABI visibility question Vince Weaver
2018-08-24 8:50 ` Peter Zijlstra
2018-08-24 21:09 ` Vince Weaver
2018-08-27 7:52 ` Peter Zijlstra
2018-08-28 17:51 ` Vince Weaver [this message]
2018-08-29 12:13 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1808281349210.21658@macbook-air \
--to=vincent.weaver@maine.edu \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).