From: Thomas Gleixner <tglx@linutronix.de>
To: Christopher Hall <christopher.s.hall@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
jesus.sanchez-palencia@intel.com, gavin.hindman@intel.com,
liam.r.girdwood@intel.com, Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: TSC to Mono-raw Drift
Date: Fri, 19 Oct 2018 20:37:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1810191955250.1651@nanos.tec.linutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1810191720590.6075@nanos.tec.linutronix.de>
On Fri, 19 Oct 2018, Thomas Gleixner wrote:
> On Mon, 15 Oct 2018, Christopher Hall wrote:
> > TSC kHz used to calculate mult/shift value: 3312000
>
> Now the most interesting information here would be the resulting mult/shift
> value which the kernel uses. Can you please provide that?
But aside of the actual values it's pretty obvious why this happens. It's a
simple rounding error. Minimal, but still. To avoid rounding errors you'd
have to find mult and shift values which exactly result in:
(freq * mult) >> shift = 1e9
which is impossible for freq = 3312 * 1e6.
A possible fix for this is, because the error is in the low PPB range, to
adjust the error once per second or in some other sensible regular
interval.
John?
Thanks,
tglx
next prev parent reply other threads:[~2018-10-19 18:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181015160945.5993-1-christopher.s.hall@intel.com>
2018-10-19 15:25 ` TSC to Mono-raw Drift Thomas Gleixner
2018-10-19 18:34 ` John Stultz
2018-10-19 18:39 ` John Stultz
2018-10-19 18:37 ` Thomas Gleixner [this message]
2018-10-19 18:48 ` John Stultz
2018-10-19 18:57 ` Thomas Gleixner
2018-10-19 19:21 ` John Stultz
2018-10-19 20:50 ` Thomas Gleixner
2018-10-19 22:36 ` John Stultz
2018-10-23 18:31 ` John Stultz
2018-10-24 14:51 ` Miroslav Lichvar
2018-10-24 17:32 ` Christopher Hall
2018-10-25 11:49 ` Miroslav Lichvar
2018-11-01 17:41 ` Thomas Gleixner
2018-11-02 10:26 ` Miroslav Lichvar
2018-11-02 11:27 ` Thomas Gleixner
2018-11-01 17:44 ` Thomas Gleixner
2018-11-01 17:56 ` John Stultz
2018-11-01 18:03 ` Thomas Gleixner
2018-11-02 11:20 ` Miroslav Lichvar
2018-11-02 11:25 ` Thomas Gleixner
2018-11-02 12:31 ` Miroslav Lichvar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810191955250.1651@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=christopher.s.hall@intel.com \
--cc=gavin.hindman@intel.com \
--cc=hpa@zytor.com \
--cc=jesus.sanchez-palencia@intel.com \
--cc=john.stultz@linaro.org \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).