* [PATCH] net: ax25: Fix multiple blank lines warning
@ 2019-02-23 11:17 Jules Irenge
2019-02-23 12:59 ` [Outreachy kernel] " Greg KH
2019-02-23 13:22 ` Julia Lawall
0 siblings, 2 replies; 4+ messages in thread
From: Jules Irenge @ 2019-02-23 11:17 UTC (permalink / raw)
To: jreuter
Cc: linux-hams, linux-kernel, davem, ralf, netdev, outreachy-kernel,
jbi.octave
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
net/ax25/af_ax25.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index 5048790a75f6..2da349b7854a 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -49,8 +49,6 @@
#include <net/ip.h>
#include <net/arp.h>
-
-
HLIST_HEAD(ax25_list);
DEFINE_SPINLOCK(ax25_list_lock);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning
2019-02-23 11:17 [PATCH] net: ax25: Fix multiple blank lines warning Jules Irenge
@ 2019-02-23 12:59 ` Greg KH
2019-02-23 13:17 ` Ivan Ivanov
2019-02-23 13:22 ` Julia Lawall
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-02-23 12:59 UTC (permalink / raw)
To: Jules Irenge
Cc: jreuter, linux-hams, linux-kernel, davem, ralf, netdev, outreachy-kernel
On Sat, Feb 23, 2019 at 11:17:51AM +0000, Jules Irenge wrote:
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> net/ax25/af_ax25.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 5048790a75f6..2da349b7854a 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -49,8 +49,6 @@
> #include <net/ip.h>
> #include <net/arp.h>
>
> -
> -
> HLIST_HEAD(ax25_list);
> DEFINE_SPINLOCK(ax25_list_lock);
Why are you doing outreachy application patches in net/? We only accept
them in drivers/staging/ Always start there first.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning
2019-02-23 12:59 ` [Outreachy kernel] " Greg KH
@ 2019-02-23 13:17 ` Ivan Ivanov
0 siblings, 0 replies; 4+ messages in thread
From: Ivan Ivanov @ 2019-02-23 13:17 UTC (permalink / raw)
To: Jules Irenge, Greg KH, jreuter, linux-hams,
Linux Kernel Mailing List, ralf, davem, netdev, outreachy-kernel
as usual, Outreachy is doing stiuupid almost-useless commits like
remove two blank lines or fix a tiny typo. They are trying hard to
pretend that they are useful by doing many lame patches like this,
while promoting their SJW madness, anti-male sieexism and anti-white
riaacism. But with the lame stuff like this patch, they are failing
miserably. Maybe hire a ghostwriter (from NSA) to write some drivers
for you?
P.S. and no I am not going to write them for you because I disagree
with your Ci0ck of Conduct and now have to write from anonymous
account
On Sat, Feb 23, 2019, Greg KH <greg@kroah.com> wrote:
>
> On Sat, Feb 23, 2019 at 11:17:51AM +0000, Jules Irenge wrote:
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> > net/ax25/af_ax25.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> > index 5048790a75f6..2da349b7854a 100644
> > --- a/net/ax25/af_ax25.c
> > +++ b/net/ax25/af_ax25.c
> > @@ -49,8 +49,6 @@
> > #include <net/ip.h>
> > #include <net/arp.h>
> >
> > -
> > -
> > HLIST_HEAD(ax25_list);
> > DEFINE_SPINLOCK(ax25_list_lock);
>
> Why are you doing outreachy application patches in net/? We only accept
> them in drivers/staging/ Always start there first.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning
2019-02-23 11:17 [PATCH] net: ax25: Fix multiple blank lines warning Jules Irenge
2019-02-23 12:59 ` [Outreachy kernel] " Greg KH
@ 2019-02-23 13:22 ` Julia Lawall
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-02-23 13:22 UTC (permalink / raw)
To: Jules Irenge
Cc: jreuter, linux-hams, linux-kernel, davem, ralf, netdev, outreachy-kernel
On Sat, 23 Feb 2019, Jules Irenge wrote:
You need a commit message here.
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> net/ax25/af_ax25.c | 2 --
This is the same file as in your previous patch, so they should be in a
series.
But please work on files in drivers/staging instead.
julia
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 5048790a75f6..2da349b7854a 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -49,8 +49,6 @@
> #include <net/ip.h>
> #include <net/arp.h>
>
> -
> -
> HLIST_HEAD(ax25_list);
> DEFINE_SPINLOCK(ax25_list_lock);
>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223111751.14620-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-23 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-23 11:17 [PATCH] net: ax25: Fix multiple blank lines warning Jules Irenge
2019-02-23 12:59 ` [Outreachy kernel] " Greg KH
2019-02-23 13:17 ` Ivan Ivanov
2019-02-23 13:22 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).