[PATCH] ath11k: fix bugon.cocci warnings

* [PATCH] ath11k: fix bugon.cocci warnings
@ 2019-03-07 21:48 Julia Lawall
  2019-03-08 12:49 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2019-03-07 21:48 UTC (permalink / raw)
  To: Venkateswara Naralasetty
  Cc: Kalle Valo, linux-wireless, netdev, linux-kernel, ath10k, kbuild-all

From: kbuild test robot <lkp@intel.com>

Use BUG_ON instead of if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: c105b7abf400 ("ath11k: collect DDR dump after fw crash")
CC: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: c105b7abf400972ee661efe18b4ca11adfd137cd [28/42] ath11k: collect DDR dump after fw crash
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ahb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -954,8 +954,7 @@ static int ath11k_subsys_notifier_cb(str
 		sc->target_restarted = 0;
 		break;
 	case SUBSYS_BEFORE_POWERUP:
-		if (sc->target_restarted)
-			BUG();
+		BUG_ON(sc->target_restarted);
 		break;
 	default:
 		return NOTIFY_OK;

^ permalink raw reply	[flat|nested] 2+ messages in thread