From: Thomas Gleixner <tglx@linutronix.de>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com,
mingo@kernel.org, bp@alien8.de, hpa@zytor.com, dyoung@redhat.com,
x86@kernel.org
Subject: Re: [PATCH v3 2/3] x86/kexec/64: Error out if try to jump to old 4-level kernel from 5-level kernel
Date: Fri, 5 Apr 2019 22:38:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1904052223120.1802@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190312103051.18086-3-bhe@redhat.com>
On Tue, 12 Mar 2019, Baoquan He wrote:
> In relocate_kernel() CR4.LA57 flag is set before kexec jumping if
> the kernel has 5-level paging enabled. Then in boot/compressed/head_64.S,
> it will check if the booting kernel is in 4-level or 5-level paging
> mode, and handle accordingly. However, the old kernel which doesn't
> contain the 5-level codes doesn't know how to cope with it, then #GP
> triggered.
The above is more than confusing. I assume you want to say:
If the running kernel has 5-level paging activated, the 5-level paging
mode is preserved across kexec. If the kexec'ed kernel does not contain
support for handling active 5-level paging mode in the decompressor, the
decompressor will crash with #GP.
> Instead of triggering #GP during kexec kernel boot, error out during
> kexec loading if find out we are trying to jump to old 4-level kernel
> from 5-level kernel.
Prevent this situation at load time. If 5-level paging is active, check the
xloadflags whether the kexec kernel can handle 5-level paging at least in
the decompressor. If not, reject the load attempt.
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> arch/x86/kernel/kexec-bzimage64.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
> index 1f3b77367948..4c9c079b5673 100644
> --- a/arch/x86/kernel/kexec-bzimage64.c
> +++ b/arch/x86/kernel/kexec-bzimage64.c
> @@ -321,6 +321,11 @@ static int bzImage64_probe(const char *buf, unsigned long len)
> return ret;
> }
>
> + if (!(header->xloadflags & XLF_5LEVEL) && pgtable_l5_enabled()) {
> + pr_err("Can not jump to old 4-level kernel from 5-level kernel.\n");
This is confusing at best.
"bzImage cannot handle 5-level paging mode\n"
or something like this.
> + return ret;
Thanks,
tglx
next prev parent reply other threads:[~2019-04-05 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 10:30 [PATCH v3 0/3] Add restrictions for kexec/kdump jumping between 5-level and 4-level kernel Baoquan He
2019-03-12 10:30 ` [PATCH v3 1/3] x86/boot: Add xloadflags bits for 5-level kernel checking Baoquan He
2019-04-05 20:23 ` Thomas Gleixner
2019-04-06 1:40 ` Baoquan He
2019-03-12 10:30 ` [PATCH v3 2/3] x86/kexec/64: Error out if try to jump to old 4-level kernel from 5-level kernel Baoquan He
2019-04-05 20:38 ` Thomas Gleixner [this message]
2019-04-06 1:39 ` Baoquan He
2019-03-12 10:30 ` [PATCH v3 3/3] x86/kdump/64: Change the upper limit of crashkernel reservation Baoquan He
2019-04-04 2:20 ` [PATCH v3 0/3] Add restrictions for kexec/kdump jumping between 5-level and 4-level kernel Baoquan He
2019-04-06 1:43 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1904052223120.1802@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).