linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/7] staging: rtl8723bs: core: Remove return in void function.
@ 2019-05-04 18:43 Vatsala Narang
  2019-05-04 19:25 ` Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Vatsala Narang @ 2019-05-04 18:43 UTC (permalink / raw)
  To: gregkh
  Cc: hadess, hdegoede, devel, linux-kernel, julia.lawall, Vatsala Narang

Remove return in void function to get rid of checkpatch warning.

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 00d84d34da97..a7c22e5e3559 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -3097,8 +3097,6 @@ void issue_auth(struct adapter *padapter, struct sta_info *psta, unsigned short
 	rtw_wep_encrypt(padapter, (u8 *)pmgntframe);
 	DBG_871X("%s\n", __func__);
 	dump_mgntframe(padapter, pmgntframe);
-
-	return;
 }
 
 
@@ -5271,8 +5269,6 @@ void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsi
 	DBG_871X("report_del_sta_event: delete STA, mac_id =%d\n", mac_id);
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
 }
 
 void report_add_sta_event(struct adapter *padapter, unsigned char *MacAddr, int cam_idx)
@@ -5317,8 +5313,6 @@ void report_add_sta_event(struct adapter *padapter, unsigned char *MacAddr, int
 	DBG_871X("report_add_sta_event: add STA\n");
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
 }
 
 /****************************************************************************
@@ -5828,8 +5822,6 @@ void survey_timer_hdl(struct timer_list *t)
 
 
 exit_survey_timer_hdl:
-
-	return;
 }
 
 void link_timer_hdl(struct timer_list *t)
@@ -5880,8 +5872,6 @@ void link_timer_hdl(struct timer_list *t)
 		issue_assocreq(padapter);
 		set_link_timer(pmlmeext, REASSOC_TO);
 	}
-
-	return;
 }
 
 void addba_timer_hdl(struct timer_list *t)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/7] staging: rtl8723bs: core: Remove return in void function.
  2019-05-04 18:43 [PATCH 2/7] staging: rtl8723bs: core: Remove return in void function Vatsala Narang
@ 2019-05-04 19:25 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2019-05-04 19:25 UTC (permalink / raw)
  To: Vatsala Narang; +Cc: gregkh, hadess, hdegoede, devel, linux-kernel

> @@ -5828,8 +5822,6 @@ void survey_timer_hdl(struct timer_list *t)
>
>
>  exit_survey_timer_hdl:
> -
> -	return;
>  }

Are you sure that you compiled this code?  I'm not sure that it is possible
to have a label without a subsequent statement.

julia

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-04 19:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-04 18:43 [PATCH 2/7] staging: rtl8723bs: core: Remove return in void function Vatsala Narang
2019-05-04 19:25 ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).