* [PATCH] Input: iforce - Remove empty multiline comments
@ 2019-07-08 2:50 Tim Schumacher
2019-07-08 6:01 ` Thomas Gleixner
2019-07-14 21:29 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Tim Schumacher @ 2019-07-08 2:50 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, tglx, timschumi
Those are remnants of the SPDX identifier migration, which haven't been
removed properly.
Signed-off-by: Tim Schumacher <timschumi@gmx.de>
---
This is probably the highest level of cosmetic-only that a patch
can achieve, sorry for the noise.
CCing Thomas Gleixner, since the tool (is it a tool?) that makes
those SPDX changes would have room for improvement in that regard.
It seems to expect that all of the license information is contained
within the same comment block, which wasn't the case for the iforce
driver.
---
drivers/input/joystick/iforce/iforce-ff.c | 3 ---
drivers/input/joystick/iforce/iforce-main.c | 3 ---
drivers/input/joystick/iforce/iforce-packets.c | 3 ---
drivers/input/joystick/iforce/iforce-serio.c | 3 ---
drivers/input/joystick/iforce/iforce-usb.c | 3 ---
drivers/input/joystick/iforce/iforce.h | 3 ---
6 files changed, 18 deletions(-)
diff --git a/drivers/input/joystick/iforce/iforce-ff.c b/drivers/input/joystick/iforce/iforce-ff.c
index 2ed7da7d1f3e..4350927f7781 100644
--- a/drivers/input/joystick/iforce/iforce-ff.c
+++ b/drivers/input/joystick/iforce/iforce-ff.c
@@ -6,9 +6,6 @@
* USB/RS232 I-Force joysticks and wheels.
*/
-/*
- */
-
#include "iforce.h"
/*
diff --git a/drivers/input/joystick/iforce/iforce-main.c b/drivers/input/joystick/iforce/iforce-main.c
index 55f5b7bb4cac..8c2ffa43ce89 100644
--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -6,9 +6,6 @@
* USB/RS232 I-Force joysticks and wheels.
*/
-/*
- */
-
#include "iforce.h"
MODULE_AUTHOR("Vojtech Pavlik <vojtech@ucw.cz>, Johann Deneux <johann.deneux@gmail.com>");
diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
index 42cd9730e4cc..677a7773059d 100644
--- a/drivers/input/joystick/iforce/iforce-packets.c
+++ b/drivers/input/joystick/iforce/iforce-packets.c
@@ -6,9 +6,6 @@
* USB/RS232 I-Force joysticks and wheels.
*/
-/*
- */
-
#include "iforce.h"
static struct {
diff --git a/drivers/input/joystick/iforce/iforce-serio.c b/drivers/input/joystick/iforce/iforce-serio.c
index 65a4fe26324f..b3fff64d92dd 100644
--- a/drivers/input/joystick/iforce/iforce-serio.c
+++ b/drivers/input/joystick/iforce/iforce-serio.c
@@ -6,9 +6,6 @@
* USB/RS232 I-Force joysticks and wheels.
*/
-/*
- */
-
#include "iforce.h"
void iforce_serial_xmit(struct iforce *iforce)
diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c
index f1569ae8381b..ec5058e05317 100644
--- a/drivers/input/joystick/iforce/iforce-usb.c
+++ b/drivers/input/joystick/iforce/iforce-usb.c
@@ -6,9 +6,6 @@
* USB/RS232 I-Force joysticks and wheels.
*/
-/*
- */
-
#include "iforce.h"
void iforce_usb_xmit(struct iforce *iforce)
diff --git a/drivers/input/joystick/iforce/iforce.h b/drivers/input/joystick/iforce/iforce.h
index f1681706f526..32e91baf63f5 100644
--- a/drivers/input/joystick/iforce/iforce.h
+++ b/drivers/input/joystick/iforce/iforce.h
@@ -6,9 +6,6 @@
* USB/RS232 I-Force joysticks and wheels.
*/
-/*
- */
-
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/input.h>
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: iforce - Remove empty multiline comments
2019-07-08 2:50 [PATCH] Input: iforce - Remove empty multiline comments Tim Schumacher
@ 2019-07-08 6:01 ` Thomas Gleixner
2019-07-14 21:29 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2019-07-08 6:01 UTC (permalink / raw)
To: Tim Schumacher; +Cc: linux-input, linux-kernel
On Mon, 8 Jul 2019, Tim Schumacher wrote:
> Those are remnants of the SPDX identifier migration, which haven't been
> removed properly.
>
> Signed-off-by: Tim Schumacher <timschumi@gmx.de>
> ---
> This is probably the highest level of cosmetic-only that a patch
> can achieve, sorry for the noise.
>
> CCing Thomas Gleixner, since the tool (is it a tool?) that makes
> those SPDX changes would have room for improvement in that regard.
> It seems to expect that all of the license information is contained
> within the same comment block, which wasn't the case for the iforce
> driver.
Right. I noticed too late, that these empty comments were left. Tool was
fixed for later patches.
Thanks for cleaning that up.
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: iforce - Remove empty multiline comments
2019-07-08 2:50 [PATCH] Input: iforce - Remove empty multiline comments Tim Schumacher
2019-07-08 6:01 ` Thomas Gleixner
@ 2019-07-14 21:29 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2019-07-14 21:29 UTC (permalink / raw)
To: Tim Schumacher; +Cc: linux-input, linux-kernel, tglx
On Mon, Jul 08, 2019 at 04:50:10AM +0200, Tim Schumacher wrote:
> Those are remnants of the SPDX identifier migration, which haven't been
> removed properly.
>
> Signed-off-by: Tim Schumacher <timschumi@gmx.de>
Applied, thank you.
> ---
> This is probably the highest level of cosmetic-only that a patch
> can achieve, sorry for the noise.
>
> CCing Thomas Gleixner, since the tool (is it a tool?) that makes
> those SPDX changes would have room for improvement in that regard.
> It seems to expect that all of the license information is contained
> within the same comment block, which wasn't the case for the iforce
> driver.
> ---
> drivers/input/joystick/iforce/iforce-ff.c | 3 ---
> drivers/input/joystick/iforce/iforce-main.c | 3 ---
> drivers/input/joystick/iforce/iforce-packets.c | 3 ---
> drivers/input/joystick/iforce/iforce-serio.c | 3 ---
> drivers/input/joystick/iforce/iforce-usb.c | 3 ---
> drivers/input/joystick/iforce/iforce.h | 3 ---
> 6 files changed, 18 deletions(-)
>
> diff --git a/drivers/input/joystick/iforce/iforce-ff.c b/drivers/input/joystick/iforce/iforce-ff.c
> index 2ed7da7d1f3e..4350927f7781 100644
> --- a/drivers/input/joystick/iforce/iforce-ff.c
> +++ b/drivers/input/joystick/iforce/iforce-ff.c
> @@ -6,9 +6,6 @@
> * USB/RS232 I-Force joysticks and wheels.
> */
>
> -/*
> - */
> -
> #include "iforce.h"
>
> /*
> diff --git a/drivers/input/joystick/iforce/iforce-main.c b/drivers/input/joystick/iforce/iforce-main.c
> index 55f5b7bb4cac..8c2ffa43ce89 100644
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -6,9 +6,6 @@
> * USB/RS232 I-Force joysticks and wheels.
> */
>
> -/*
> - */
> -
> #include "iforce.h"
>
> MODULE_AUTHOR("Vojtech Pavlik <vojtech@ucw.cz>, Johann Deneux <johann.deneux@gmail.com>");
> diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
> index 42cd9730e4cc..677a7773059d 100644
> --- a/drivers/input/joystick/iforce/iforce-packets.c
> +++ b/drivers/input/joystick/iforce/iforce-packets.c
> @@ -6,9 +6,6 @@
> * USB/RS232 I-Force joysticks and wheels.
> */
>
> -/*
> - */
> -
> #include "iforce.h"
>
> static struct {
> diff --git a/drivers/input/joystick/iforce/iforce-serio.c b/drivers/input/joystick/iforce/iforce-serio.c
> index 65a4fe26324f..b3fff64d92dd 100644
> --- a/drivers/input/joystick/iforce/iforce-serio.c
> +++ b/drivers/input/joystick/iforce/iforce-serio.c
> @@ -6,9 +6,6 @@
> * USB/RS232 I-Force joysticks and wheels.
> */
>
> -/*
> - */
> -
> #include "iforce.h"
>
> void iforce_serial_xmit(struct iforce *iforce)
> diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c
> index f1569ae8381b..ec5058e05317 100644
> --- a/drivers/input/joystick/iforce/iforce-usb.c
> +++ b/drivers/input/joystick/iforce/iforce-usb.c
> @@ -6,9 +6,6 @@
> * USB/RS232 I-Force joysticks and wheels.
> */
>
> -/*
> - */
> -
> #include "iforce.h"
>
> void iforce_usb_xmit(struct iforce *iforce)
> diff --git a/drivers/input/joystick/iforce/iforce.h b/drivers/input/joystick/iforce/iforce.h
> index f1681706f526..32e91baf63f5 100644
> --- a/drivers/input/joystick/iforce/iforce.h
> +++ b/drivers/input/joystick/iforce/iforce.h
> @@ -6,9 +6,6 @@
> * USB/RS232 I-Force joysticks and wheels.
> */
>
> -/*
> - */
> -
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/input.h>
> --
> 2.22.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-14 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 2:50 [PATCH] Input: iforce - Remove empty multiline comments Tim Schumacher
2019-07-08 6:01 ` Thomas Gleixner
2019-07-14 21:29 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).