From: Thomas Gleixner <tglx@linutronix.de>
To: Helmut Grohne <helmut.grohne@intenta.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804"
Date: Thu, 15 Aug 2019 22:30:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1908152227590.1908@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190815120352.3sakpao2cpjl3sl2@laureti-dev>
On Thu, 15 Aug 2019, Helmut Grohne wrote:
> This reverts commit dfc82faad72520769ca146f857e65c23632eed5a.
>
> The commit effectively makes ARM_TIMER_SP804 depend on COMPILE_TEST,
> which makes it unselectable for practical uses.
>
> Link: https://lore.kernel.org/lkml/20190618120719.a4kgyiuljm5uivfq@laureti-dev/
> Signed-off-by: Helmut Grohne <helmut.grohne@intenta.de>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 5e9317dc3d39..72e924374591 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -393,7 +393,7 @@ config ARM_GLOBAL_TIMER
> This options enables support for the ARM global timer unit
>
> config ARM_TIMER_SP804
> - bool "Support for Dual Timer SP804 module" if COMPILE_TEST
> + bool "Support for Dual Timer SP804 module"
The obvious fix is to add
depends on ARM || ARM64 || COMPILE_TEST
instead of reverting the whole thing. Care to do that?
Thanks,
tglx
next prev parent reply other threads:[~2019-08-15 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:03 [PATCH] Revert "clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804" Helmut Grohne
2019-08-15 20:30 ` Thomas Gleixner [this message]
2019-08-16 6:47 ` [PATCH] clocksource/drivers/sp804: make CONFIG_ARM_TIMER_SP804 selectable again Helmut Grohne
2019-08-16 6:59 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908152227590.1908@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=helmut.grohne@intenta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).