From: Julia Lawall <julia.lawall@inria.fr>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, sbrivio@redhat.com,
daniel.baluta@gmail.com, nramas@linux.microsoft.com,
hverkuil@xs4all.nl
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator
Date: Sun, 8 Mar 2020 20:31:53 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2003082030310.2400@hadrien> (raw)
In-Reply-To: <20200308192152.26403-1-shreeya.patel23498@gmail.com>
On Mon, 9 Mar 2020, Shreeya Patel wrote:
> Add space around & operator for improving the code
> readability.
I guess you found this with checkpatch. If so, it could be nice to add
"Reported by checkpatch." to the log message. OK otherwise.
Acked-by: Julia Lawall <julia.lawall@inria.fr>
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index e764436e120f..8da955e8343b 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -924,7 +924,7 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_net
> /* update fw_state will clr _FW_UNDER_LINKING here indirectly */
> switch (pnetwork->network.InfrastructureMode) {
> case Ndis802_11Infrastructure:
> - if (pmlmepriv->fw_state&WIFI_UNDER_WPS)
> + if (pmlmepriv->fw_state & WIFI_UNDER_WPS)
> pmlmepriv->fw_state = WIFI_STATION_STATE|WIFI_UNDER_WPS;
> else
> pmlmepriv->fw_state = WIFI_STATION_STATE;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308192152.26403-1-shreeya.patel23498%40gmail.com.
>
next prev parent reply other threads:[~2020-03-08 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 19:21 [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator Shreeya Patel
2020-03-08 19:31 ` Julia Lawall [this message]
2020-03-08 19:59 ` Joe Perches
2020-03-08 20:10 ` Shreeya Patel
2020-03-08 20:17 ` Julia Lawall
2020-03-08 20:40 ` Shreeya Patel
2020-03-08 20:19 ` Joe Perches
2020-03-08 20:33 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003082030310.2400@hadrien \
--to=julia.lawall@inria.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).