From: Stefano Stabellini <sstabellini@kernel.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: sstabellini@kernel.org, linux@armlinux.org.uk,
xen-devel@lists.xenproject.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>,
jgross@suse.com
Subject: Re: [PATCH] arm/xen: make _xen_start_info static
Date: Thu, 16 Apr 2020 14:24:37 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2004161424090.8316@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20200415084853.5808-1-yanaijie@huawei.com>
On Wed, 15 Apr 2020, Jason Yan wrote:
> Fix the following sparse warning:
>
> arch/arm64/xen/../../arm/xen/enlighten.c:39:19: warning: symbol
> '_xen_start_info' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> arch/arm/xen/enlighten.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index dd6804a64f1a..fd4e1ce1daf9 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -36,7 +36,7 @@
>
> #include <linux/mm.h>
>
> -struct start_info _xen_start_info;
> +static struct start_info _xen_start_info;
> struct start_info *xen_start_info = &_xen_start_info;
> EXPORT_SYMBOL(xen_start_info);
>
> --
> 2.21.1
>
prev parent reply other threads:[~2020-04-16 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:48 [PATCH] arm/xen: make _xen_start_info static Jason Yan
2020-04-16 21:24 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2004161424090.8316@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=hulkci@huawei.com \
--cc=jgross@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=xen-devel@lists.xenproject.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).