* [PATCH] arm/xen: make _xen_start_info static
@ 2020-04-15 8:48 Jason Yan
2020-04-16 21:24 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-15 8:48 UTC (permalink / raw)
To: sstabellini, linux, xen-devel, linux-arm-kernel, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following sparse warning:
arch/arm64/xen/../../arm/xen/enlighten.c:39:19: warning: symbol
'_xen_start_info' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
arch/arm/xen/enlighten.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index dd6804a64f1a..fd4e1ce1daf9 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -36,7 +36,7 @@
#include <linux/mm.h>
-struct start_info _xen_start_info;
+static struct start_info _xen_start_info;
struct start_info *xen_start_info = &_xen_start_info;
EXPORT_SYMBOL(xen_start_info);
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm/xen: make _xen_start_info static
2020-04-15 8:48 [PATCH] arm/xen: make _xen_start_info static Jason Yan
@ 2020-04-16 21:24 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2020-04-16 21:24 UTC (permalink / raw)
To: Jason Yan
Cc: sstabellini, linux, xen-devel, linux-arm-kernel, linux-kernel,
Hulk Robot, jgross
On Wed, 15 Apr 2020, Jason Yan wrote:
> Fix the following sparse warning:
>
> arch/arm64/xen/../../arm/xen/enlighten.c:39:19: warning: symbol
> '_xen_start_info' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> arch/arm/xen/enlighten.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index dd6804a64f1a..fd4e1ce1daf9 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -36,7 +36,7 @@
>
> #include <linux/mm.h>
>
> -struct start_info _xen_start_info;
> +static struct start_info _xen_start_info;
> struct start_info *xen_start_info = &_xen_start_info;
> EXPORT_SYMBOL(xen_start_info);
>
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-16 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:48 [PATCH] arm/xen: make _xen_start_info static Jason Yan
2020-04-16 21:24 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).