* [PATCH v2 0/2] MIPS: Remove incorrect `cpu_has_fpu' overrides
@ 2022-04-30 15:07 Maciej W. Rozycki
2022-04-30 15:07 ` [PATCH v2 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override Maciej W. Rozycki
2022-04-30 15:07 ` [PATCH v2 2/2] MIPS: IP30: " Maciej W. Rozycki
0 siblings, 2 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-04-30 15:07 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Joshua Kinard, Stephen Zhang, linux-mips, linux-kernel
Hi,
Forcing `cpu_has_fpu' to 1 is unsupported as it breaks the `nofpu' kernel
parameter and more recently also the CONFIG_MIPS_FP_SUPPORT configuration
option. Remove the broken `cpu_has_fpu' overrides then for IP27 and IP30
systems.
This v2 of the series fixes a logical mistake in change descriptions.
Please apply.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override
2022-04-30 15:07 [PATCH v2 0/2] MIPS: Remove incorrect `cpu_has_fpu' overrides Maciej W. Rozycki
@ 2022-04-30 15:07 ` Maciej W. Rozycki
2022-04-30 15:07 ` [PATCH v2 2/2] MIPS: IP30: " Maciej W. Rozycki
1 sibling, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-04-30 15:07 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Joshua Kinard, Stephen Zhang, linux-mips, linux-kernel, stable
Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
kernel parameter non-functional, and also causes a link error:
ld: arch/mips/kernel/traps.o: in function `trap_init':
./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to `handle_fpe'
ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference to `handle_fpe'
ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference to `handle_fpe'
where the CONFIG_MIPS_FP_SUPPORT configuration option has been disabled.
Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Fixes: 0ebb2f4159af ("MIPS: IP27: Update/restructure CPU overrides")
Cc: stable@vger.kernel.org # v4.2+
---
Changes from v1:
- s/chosen/disabled/ in the change description.
---
arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h | 1 -
1 file changed, 1 deletion(-)
linux-mips-ip27-cpu-has-fpu.diff
Index: linux-macro/arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
===================================================================
--- linux-macro.orig/arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
+++ linux-macro/arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
@@ -25,7 +25,6 @@
#define cpu_has_4kex 1
#define cpu_has_3k_cache 0
#define cpu_has_4k_cache 1
-#define cpu_has_fpu 1
#define cpu_has_nofpuex 0
#define cpu_has_32fpr 1
#define cpu_has_counter 1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] MIPS: IP30: Remove incorrect `cpu_has_fpu' override
2022-04-30 15:07 [PATCH v2 0/2] MIPS: Remove incorrect `cpu_has_fpu' overrides Maciej W. Rozycki
2022-04-30 15:07 ` [PATCH v2 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override Maciej W. Rozycki
@ 2022-04-30 15:07 ` Maciej W. Rozycki
1 sibling, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-04-30 15:07 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Joshua Kinard, Stephen Zhang, linux-mips, linux-kernel, stable
Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
kernel parameter non-functional, and also causes a link error:
ld: arch/mips/kernel/traps.o: in function `trap_init':
./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to `handle_fpe'
ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference to `handle_fpe'
ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference to `handle_fpe'
where the CONFIG_MIPS_FP_SUPPORT configuration option has been disabled.
Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Fixes: 7505576d1c1a ("MIPS: add support for SGI Octane (IP30)")
Cc: stable@vger.kernel.org # v5.5+
---
Changes from v1:
- s/chosen/disabled/ in the change description.
---
arch/mips/include/asm/mach-ip30/cpu-feature-overrides.h | 1 -
1 file changed, 1 deletion(-)
linux-mips-ip30-cpu-has-fpu.diff
Index: linux-macro/arch/mips/include/asm/mach-ip30/cpu-feature-overrides.h
===================================================================
--- linux-macro.orig/arch/mips/include/asm/mach-ip30/cpu-feature-overrides.h
+++ linux-macro/arch/mips/include/asm/mach-ip30/cpu-feature-overrides.h
@@ -28,7 +28,6 @@
#define cpu_has_4kex 1
#define cpu_has_3k_cache 0
#define cpu_has_4k_cache 1
-#define cpu_has_fpu 1
#define cpu_has_nofpuex 0
#define cpu_has_32fpr 1
#define cpu_has_counter 1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-30 15:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-30 15:07 [PATCH v2 0/2] MIPS: Remove incorrect `cpu_has_fpu' overrides Maciej W. Rozycki
2022-04-30 15:07 ` [PATCH v2 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override Maciej W. Rozycki
2022-04-30 15:07 ` [PATCH v2 2/2] MIPS: IP30: " Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).