* [PATCH] usb: gadget: aspeed: add missing of_node_put
@ 2021-01-21 18:12 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2021-01-21 18:12 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Joel Stanley, Andrew Jeffery,
Tao Ren, Benjamin Herrenschmidt
Cc: linux-usb, linux-arm-kernel, kbuild-all, Sumera Priyadarsini,
linux-kernel
From: kernel test robot <lkp@intel.com>
Breaking out of for_each_child_of_node requires a put on the
child value.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Fixes: 82c2d81361ec ("coccinelle: iterators: Add for_each_child.cocci script")
CC: Sumera Priyadarsini <sylphrenadin@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 45dfb8a5659ad286c28fa59008271dbc4e5e3f2d
commit: 82c2d81361ecd142a54e84a9da1e287113314a4f coccinelle: iterators: Add for_each_child.cocci script
:::::: branch date: 17 hours ago
:::::: commit date: 3 months ago
Please take the patch only if it's a positive warning. Thanks!
hub.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
@@ -999,8 +999,10 @@ static int ast_vhub_of_parse_str_desc(st
str_array[offset].s = NULL;
ret = ast_vhub_str_alloc_add(vhub, &lang_str);
- if (ret)
+ if (ret) {
+ of_node_put(child);
break;
+ }
}
return ret;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-21 18:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 18:12 [PATCH] usb: gadget: aspeed: add missing of_node_put Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).