* [PATCH] riscv: fix bugon.cocci warnings
@ 2021-02-28 11:10 Julia Lawall
2021-02-28 14:56 ` Pekka Enberg
2021-03-17 3:36 ` Palmer Dabbelt
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2021-02-28 11:10 UTC (permalink / raw)
To: Guo Ren, Palmer Dabbelt, Patrick Stählin, Pekka Enberg
Cc: linux-kernel, kbuild-all
From: kernel test robot <lkp@intel.com>
Use BUG_ON instead of a if condition followed by BUG.
Generated by: scripts/coccinelle/misc/bugon.cocci
Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
CC: Guo Ren <guoren@linux.alibaba.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4
commit: c22b0bcb1dd024cb9caad9230e3a387d8b061df5 riscv: Add kprobes supported
:::::: branch date: 3 hours ago
:::::: commit date: 6 weeks ago
kprobes.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/arch/riscv/kernel/probes/kprobes.c
+++ b/arch/riscv/kernel/probes/kprobes.c
@@ -256,8 +256,7 @@ int __kprobes kprobe_fault_handler(struc
* normal page fault.
*/
regs->epc = (unsigned long) cur->addr;
- if (!instruction_pointer(regs))
- BUG();
+ BUG_ON(!instruction_pointer(regs));
if (kcb->kprobe_status == KPROBE_REENTER)
restore_previous_kprobe(kcb);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: fix bugon.cocci warnings
2021-02-28 11:10 [PATCH] riscv: fix bugon.cocci warnings Julia Lawall
@ 2021-02-28 14:56 ` Pekka Enberg
2021-03-17 3:36 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Pekka Enberg @ 2021-02-28 14:56 UTC (permalink / raw)
To: Julia Lawall
Cc: Guo Ren, Palmer Dabbelt, Patrick Stählin, Pekka Enberg,
linux-kernel, kbuild-all
On Sun, Feb 28, 2021 at 12:10:22PM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Use BUG_ON instead of a if condition followed by BUG.
>
> Generated by: scripts/coccinelle/misc/bugon.cocci
>
> Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
> CC: Guo Ren <guoren@linux.alibaba.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: fix bugon.cocci warnings
2021-02-28 11:10 [PATCH] riscv: fix bugon.cocci warnings Julia Lawall
2021-02-28 14:56 ` Pekka Enberg
@ 2021-03-17 3:36 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2021-03-17 3:36 UTC (permalink / raw)
To: julia.lawall; +Cc: guoren, me, penberg, linux-kernel, kbuild-all
On Sun, 28 Feb 2021 03:10:22 PST (-0800), julia.lawall@inria.fr wrote:
> From: kernel test robot <lkp@intel.com>
>
> Use BUG_ON instead of a if condition followed by BUG.
>
> Generated by: scripts/coccinelle/misc/bugon.cocci
>
> Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported")
> CC: Guo Ren <guoren@linux.alibaba.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4
> commit: c22b0bcb1dd024cb9caad9230e3a387d8b061df5 riscv: Add kprobes supported
> :::::: branch date: 3 hours ago
> :::::: commit date: 6 weeks ago
>
> kprobes.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/arch/riscv/kernel/probes/kprobes.c
> +++ b/arch/riscv/kernel/probes/kprobes.c
> @@ -256,8 +256,7 @@ int __kprobes kprobe_fault_handler(struc
> * normal page fault.
> */
> regs->epc = (unsigned long) cur->addr;
> - if (!instruction_pointer(regs))
> - BUG();
> + BUG_ON(!instruction_pointer(regs));
>
> if (kcb->kprobe_status == KPROBE_REENTER)
> restore_previous_kprobe(kcb);
Thanks, this is on fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 11:10 [PATCH] riscv: fix bugon.cocci warnings Julia Lawall
2021-02-28 14:56 ` Pekka Enberg
2021-03-17 3:36 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).