From: Julia Lawall <julia.lawall@inria.fr>
To: Mitali Borkar <mitaliborkar810@gmail.com>
Cc: zzam@gentoo.org, clabbe@baylibre.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [Outreachy kernel] Re: [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code
Date: Thu, 15 Apr 2021 15:41:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104151540360.29064@hadrien> (raw)
In-Reply-To: <YHg70mRLN5S8mywn@kali>
> > > +#define ZR36057_JMC_JPG_EXP_MODE (0 << 29)
> > > +#define ZR36057_JMC_JPG_CMP_MODE BIT(29)
> > > +#define ZR36057_JMC_MJPG_EXP_MODE (2 << 29)
> > > +#define ZR36057_JMC_MJPG_CMP_MODE (3 << 29)
> > Same as above. Please change back ZR36057_JMC_JPG_CMP_MODE to be (1 << 29).
> > Then this 2 bit field is consistent.
> >
> Sir, I guess this BIT(29) was already present. I didn't changed this.
> I will change this as you said.
It comes from this patch:
5e195bbddabdd94b15eeb60439cece996d58b329
Probably putting it back should be a different patch in the series.
julia
prev parent reply other threads:[~2021-04-15 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 19:50 [PATCH v4 0/2] staging: media: zoran: Cleanup patchset for style issues in zr36057.h Mitali Borkar
2021-04-13 19:50 ` [PATCH v4 1/2] staging: media: zoran: add spaces around '<<' operator Mitali Borkar
2021-04-13 19:50 ` [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code Mitali Borkar
2021-04-14 10:38 ` zzam
2021-04-15 13:12 ` Mitali Borkar
2021-04-15 13:41 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104151540360.29064@hadrien \
--to=julia.lawall@inria.fr \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mitali_s@me.iitr.ac.in \
--cc=mitaliborkar810@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).