* [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel @ 2022-10-17 20:10 Deepak R Varma 2022-10-17 20:56 ` Julia Lawall 0 siblings, 1 reply; 5+ messages in thread From: Deepak R Varma @ 2022-10-17 20:10 UTC (permalink / raw) To: outreachy, gregkh, linux-staging, linux-kernel Cc: kumarpraveen, saurabh.truth The done_buffer count can be directly read from HDM channel instead of calling the dim_get_channel_state function. This change also results in obsoleting the dim_channel_state local structure variable. Signed-off-by: Deepak R Varma <drv@mailo.com> --- PLEASE NOTE: I have only built the module on my machine, but have not tested it. I am not sure how to test this change. I am willing to test it with appropriate guidance provided I have the necessary hardware. drivers/staging/most/dim2/dim2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index ab72e11ac5ab..4c1f27898a29 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) static void service_done_flag(struct dim2_hdm *dev, int ch_idx) { struct hdm_channel *hdm_ch = dev->hch + ch_idx; - struct dim_ch_state_t st; struct list_head *head; struct mbo *mbo; int done_buffers; @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) spin_lock_irqsave(&dim_lock, flags); - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; + done_buffers = hdm_ch->ch.done_sw_buffers_number; if (!done_buffers) { spin_unlock_irqrestore(&dim_lock, flags); return; -- 2.30.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel 2022-10-17 20:10 [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel Deepak R Varma @ 2022-10-17 20:56 ` Julia Lawall 2022-10-17 21:05 ` Deepak R Varma 0 siblings, 1 reply; 5+ messages in thread From: Julia Lawall @ 2022-10-17 20:56 UTC (permalink / raw) To: Deepak R Varma Cc: outreachy, gregkh, linux-staging, linux-kernel, kumarpraveen, saurabh.truth On Tue, 18 Oct 2022, Deepak R Varma wrote: > The done_buffer count can be directly read from HDM channel instead of > calling the dim_get_channel_state function. This change also results in > obsoleting the dim_channel_state local structure variable. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > > PLEASE NOTE: I have only built the module on my machine, but have not tested it. > I am not sure how to test this change. I am willing to test it with appropriate > guidance provided I have the necessary hardware. For non experts, maybe it would be helpful to explain what motivated you to do this? julia > > drivers/staging/most/dim2/dim2.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index ab72e11ac5ab..4c1f27898a29 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) > static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > { > struct hdm_channel *hdm_ch = dev->hch + ch_idx; > - struct dim_ch_state_t st; > struct list_head *head; > struct mbo *mbo; > int done_buffers; > @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > spin_lock_irqsave(&dim_lock, flags); > > - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; > + done_buffers = hdm_ch->ch.done_sw_buffers_number; > if (!done_buffers) { > spin_unlock_irqrestore(&dim_lock, flags); > return; > -- > 2.30.2 > > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel 2022-10-17 20:56 ` Julia Lawall @ 2022-10-17 21:05 ` Deepak R Varma 2022-10-18 5:35 ` Julia Lawall 0 siblings, 1 reply; 5+ messages in thread From: Deepak R Varma @ 2022-10-17 21:05 UTC (permalink / raw) To: Julia Lawall Cc: outreachy, gregkh, linux-staging, linux-kernel, kumarpraveen, saurabh.truth On Mon, Oct 17, 2022 at 10:56:03PM +0200, Julia Lawall wrote: > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > The done_buffer count can be directly read from HDM channel instead of > > calling the dim_get_channel_state function. This change also results in > > obsoleting the dim_channel_state local structure variable. > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > --- > > > > PLEASE NOTE: I have only built the module on my machine, but have not tested it. > > I am not sure how to test this change. I am willing to test it with appropriate > > guidance provided I have the necessary hardware. > > For non experts, maybe it would be helpful to explain what motivated you > to do this? I was actually trying to understand the implementation of this module to determine if I can replace BUG_ON calls by WARN_ON_ONCE. A "ctrl+]" navigation took me to this function and I started wondering about why the function call would be necessary. Hence the change. While reading the Documentation under dim2 directory, I realised this module may need a specialised hardware for testing [automotive???]. Hence I was not sure how to test the same. Are you suggesting I mention this in the patch description (the motivation)? Thank you, ./drv > > julia > > > > > drivers/staging/most/dim2/dim2.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > index ab72e11ac5ab..4c1f27898a29 100644 > > --- a/drivers/staging/most/dim2/dim2.c > > +++ b/drivers/staging/most/dim2/dim2.c > > @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) > > static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > { > > struct hdm_channel *hdm_ch = dev->hch + ch_idx; > > - struct dim_ch_state_t st; > > struct list_head *head; > > struct mbo *mbo; > > int done_buffers; > > @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > > > spin_lock_irqsave(&dim_lock, flags); > > > > - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; > > + done_buffers = hdm_ch->ch.done_sw_buffers_number; > > if (!done_buffers) { > > spin_unlock_irqrestore(&dim_lock, flags); > > return; > > -- > > 2.30.2 > > > > > > > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel 2022-10-17 21:05 ` Deepak R Varma @ 2022-10-18 5:35 ` Julia Lawall 2022-10-18 6:01 ` Deepak R Varma 0 siblings, 1 reply; 5+ messages in thread From: Julia Lawall @ 2022-10-18 5:35 UTC (permalink / raw) To: Deepak R Varma Cc: outreachy, gregkh, linux-staging, linux-kernel, kumarpraveen, saurabh.truth On Tue, 18 Oct 2022, Deepak R Varma wrote: > On Mon, Oct 17, 2022 at 10:56:03PM +0200, Julia Lawall wrote: > > > > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > > > The done_buffer count can be directly read from HDM channel instead of > > > calling the dim_get_channel_state function. This change also results in > > > obsoleting the dim_channel_state local structure variable. > > > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > > --- > > > > > > PLEASE NOTE: I have only built the module on my machine, but have not tested it. > > > I am not sure how to test this change. I am willing to test it with appropriate > > > guidance provided I have the necessary hardware. > > > > For non experts, maybe it would be helpful to explain what motivated you > > to do this? > > I was actually trying to understand the implementation of this module to > determine if I can replace BUG_ON calls by WARN_ON_ONCE. A "ctrl+]" navigation > took me to this function and I started wondering about why the function call > would be necessary. Hence the change. OK, I agree with you that this story might not be super interesting. But the log message still seems too concise. You have acquired some knowledge about why this changeis correct, but that knowledge is not at all reflected in the log message. Try to explain in more detail why the function call is not necessary. julia > > While reading the Documentation under dim2 directory, I realised this module may > need a specialised hardware for testing [automotive???]. Hence I was not sure > how to test the same. > > Are you suggesting I mention this in the patch description (the motivation)? > > Thank you, > ./drv > > > > > julia > > > > > > > > drivers/staging/most/dim2/dim2.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > > index ab72e11ac5ab..4c1f27898a29 100644 > > > --- a/drivers/staging/most/dim2/dim2.c > > > +++ b/drivers/staging/most/dim2/dim2.c > > > @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) > > > static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > > { > > > struct hdm_channel *hdm_ch = dev->hch + ch_idx; > > > - struct dim_ch_state_t st; > > > struct list_head *head; > > > struct mbo *mbo; > > > int done_buffers; > > > @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > > > > > spin_lock_irqsave(&dim_lock, flags); > > > > > > - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; > > > + done_buffers = hdm_ch->ch.done_sw_buffers_number; > > > if (!done_buffers) { > > > spin_unlock_irqrestore(&dim_lock, flags); > > > return; > > > -- > > > 2.30.2 > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel 2022-10-18 5:35 ` Julia Lawall @ 2022-10-18 6:01 ` Deepak R Varma 0 siblings, 0 replies; 5+ messages in thread From: Deepak R Varma @ 2022-10-18 6:01 UTC (permalink / raw) To: Julia Lawall Cc: outreachy, gregkh, linux-staging, linux-kernel, kumarpraveen, saurabh.truth On Tue, Oct 18, 2022 at 07:35:29AM +0200, Julia Lawall wrote: > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > On Mon, Oct 17, 2022 at 10:56:03PM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > > > > > The done_buffer count can be directly read from HDM channel instead of > > > > calling the dim_get_channel_state function. This change also results in > > > > obsoleting the dim_channel_state local structure variable. > > > > > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > > > --- > > > > > > > > PLEASE NOTE: I have only built the module on my machine, but have not tested it. > > > > I am not sure how to test this change. I am willing to test it with appropriate > > > > guidance provided I have the necessary hardware. > > > > > > For non experts, maybe it would be helpful to explain what motivated you > > > to do this? > > > > I was actually trying to understand the implementation of this module to > > determine if I can replace BUG_ON calls by WARN_ON_ONCE. A "ctrl+]" navigation > > took me to this function and I started wondering about why the function call > > would be necessary. Hence the change. > > OK, I agree with you that this story might not be super interesting. > > But the log message still seems too concise. You have acquired some > knowledge about why this changeis correct, but that knowledge is not at > all reflected in the log message. Try to explain in more detail why the > function call is not necessary. Sounds good. I will update the patch log and resubmit the patch. Thank you, ./drv > > julia > > > > > While reading the Documentation under dim2 directory, I realised this module may > > need a specialised hardware for testing [automotive???]. Hence I was not sure > > how to test the same. > > > > Are you suggesting I mention this in the patch description (the motivation)? > > > > Thank you, > > ./drv > > > > > > > > julia > > > > > > > > > > > drivers/staging/most/dim2/dim2.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > > > index ab72e11ac5ab..4c1f27898a29 100644 > > > > --- a/drivers/staging/most/dim2/dim2.c > > > > +++ b/drivers/staging/most/dim2/dim2.c > > > > @@ -259,7 +259,6 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) > > > > static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > > > { > > > > struct hdm_channel *hdm_ch = dev->hch + ch_idx; > > > > - struct dim_ch_state_t st; > > > > struct list_head *head; > > > > struct mbo *mbo; > > > > int done_buffers; > > > > @@ -271,7 +270,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) > > > > > > > > spin_lock_irqsave(&dim_lock, flags); > > > > > > > > - done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers; > > > > + done_buffers = hdm_ch->ch.done_sw_buffers_number; > > > > if (!done_buffers) { > > > > spin_unlock_irqrestore(&dim_lock, flags); > > > > return; > > > > -- > > > > 2.30.2 > > > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-18 6:02 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-10-17 20:10 [PATCH] staging: most: dim2: read done_buffers count locally from HDM channel Deepak R Varma 2022-10-17 20:56 ` Julia Lawall 2022-10-17 21:05 ` Deepak R Varma 2022-10-18 5:35 ` Julia Lawall 2022-10-18 6:01 ` Deepak R Varma
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).