From: Thomas Gleixner <tglx@linutronix.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Boaz Harrosh <bharrosh@panasas.com>,
linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rt-users@vger.kernel.org
Subject: Re: Large amount of scsi-sgpool objects
Date: Tue, 3 Mar 2009 18:19:16 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0903031818230.29264@localhost.localdomain> (raw)
In-Reply-To: <1236097526.3263.17.camel@localhost.localdomain>
On Tue, 3 Mar 2009, James Bottomley wrote:
> On Tue, 2009-03-03 at 17:08 +0100, Jan Engelhardt wrote:
> > On Tuesday 2009-03-03 16:21, James Bottomley wrote:
> > >> > $ slabtop
> > >> > OBJS ACTIVE USE OBJ SIZE SLABS OBJ/SLAB CACHE SIZE NAME
> > >> > 818616 818616 100% 0.16K 34109 24 136436K sgpool-8
> > >> > 253692 253692 100% 0.62K 42282 6 169128K sgpool-32
> > >> > 52017 52016 99% 2.50K 17339 3 138712K sgpool-128
> > >> > 26220 26219 99% 0.31K 2185 12 8740K sgpool-16
> > >> > 8927 8574 96% 0.03K 79 113 316K size-32
> > >>
> > >> Looks like a leak, by failing to call scsi_release_buffers()
> > >> somehow. (Which was changed recently)
> > >
> > >Firstly, I have to say I don't see this in the mainline tree, so could
> > >you try that with your setup just to verify (git head at 2.6.29-rc6).
> >
> > Yes, looking at the rt patch (in broken-out it's in origin.diff),
> > it seems a bit obvious - the scsi_release_buffers is not called anymore:
>
> OK, this is a bad patch, so just revert it. It was posted to linux-scsi
> initially in this form before the author posted a new one with the
> missing release buffers added. It looks like the first incarnation got
> pulled into the -rt tree for some reasons.
>
> So the real question is why does the -rt tree even have patches not in
> the vanilla SCSI tree? This type of cockup clearly demonstrates why
> it's a bad idea.
My bad. I was playing with that to get rid of the aic7xxx wreckage on
one of my test boxen and forgot to remove it.
Thanks,
tglx
next prev parent reply other threads:[~2009-03-03 17:19 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 1:28 Large amount of scsi-sgpool objects Jan Engelhardt
2009-03-03 9:31 ` Boaz Harrosh
2009-03-03 15:21 ` James Bottomley
2009-03-03 16:08 ` Jan Engelhardt
2009-03-03 16:24 ` Boaz Harrosh
2009-03-03 17:59 ` Alan Stern
2009-03-03 20:56 ` Ingo Molnar
2009-03-03 21:06 ` Alan Stern
2009-03-03 16:25 ` James Bottomley
2009-03-03 17:19 ` Thomas Gleixner [this message]
2009-03-03 22:07 ` [BUG] 2.6.29-rc6-2450cf in scsi_lib.c (was: Large amount of scsi-sgpool)objects Thomas Gleixner
2009-03-03 22:22 ` Jan Engelhardt
2009-03-03 23:07 ` Thomas Gleixner
2009-03-03 22:26 ` James Bottomley
2009-03-04 2:01 ` Thomas Gleixner
2009-03-04 18:55 ` James Bottomley
2009-03-04 21:45 ` Thomas Gleixner
2009-03-04 22:56 ` James Bottomley
2009-03-05 0:13 ` James Bottomley
2009-03-05 8:36 ` FUJITA Tomonori
2009-03-05 8:39 ` FUJITA Tomonori
2009-03-05 9:29 ` FUJITA Tomonori
2009-03-05 10:09 ` Jens Axboe
2009-03-05 10:14 ` Jens Axboe
2009-03-05 10:27 ` FUJITA Tomonori
2009-03-05 10:30 ` Jens Axboe
2009-03-05 10:41 ` FUJITA Tomonori
2009-03-05 11:10 ` Jens Axboe
2009-03-05 11:40 ` FUJITA Tomonori
2009-03-05 10:41 ` Ingo Molnar
2009-03-05 11:05 ` Jens Axboe
2009-03-05 11:07 ` Ingo Molnar
2009-03-05 12:09 ` Thomas Gleixner
2009-03-05 23:16 ` Thomas Gleixner
2009-03-05 19:32 ` Ingo Molnar
2009-03-05 10:15 ` Ingo Molnar
2009-03-03 19:22 ` Large amount of scsi-sgpool objects Ingo Molnar
2009-03-03 21:25 ` James Bottomley
2009-03-03 21:44 ` Ingo Molnar
2009-03-03 22:39 ` James Bottomley
2009-03-03 23:03 ` Ingo Molnar
2009-03-03 23:32 ` Stefan Richter
2009-03-03 23:48 ` Ingo Molnar
2009-03-04 6:39 ` Stefan Richter
2009-03-04 7:12 ` Mike Galbraith
2009-03-04 7:50 ` Stefan Richter
2009-03-04 8:00 ` Mike Galbraith
2009-03-04 9:06 ` Thomas Gleixner
2009-03-04 11:12 ` Ingo Molnar
2009-03-04 11:28 ` Stefan Richter
2009-03-04 11:47 ` Ingo Molnar
2009-03-04 12:02 ` Stefan Richter
2009-03-04 11:24 ` Ingo Molnar
2009-03-04 19:11 ` Andrew Morton
2009-03-04 20:09 ` Thomas Gleixner
2009-03-04 0:01 ` James Bottomley
2009-03-04 0:39 ` Ingo Molnar
2009-03-04 0:30 ` Thomas Gleixner
2009-03-04 0:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0903031818230.29264@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).