linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Section mismatch: acpi_early_processor_set_pdc()
@ 2010-01-13 20:44 Marin Mitov
  2010-01-16  7:07 ` Len Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Marin Mitov @ 2010-01-13 20:44 UTC (permalink / raw)
  To: linux-kernel
  Cc: Rusty Russell, Srivatsa Vaddagiri, Zwane Mwaikambo, Ashok Raj

Hi all,

kernel-2.6.33-rc4, compiler output:

WARNING: Section mismatch in reference from the function 
acpi_early_processor_set_pdc() to the variable .cpuinit.data:processor_idle_dmi_table                                                                                           
The function acpi_early_processor_set_pdc() references                                                                            
the variable __cpuinitdata processor_idle_dmi_table.                                                                              
This is often because acpi_early_processor_set_pdc lacks a __cpuinitdata                                                          
annotation or the annotation of processor_idle_dmi_table is wrong.   

acpi_early_processor_set_pdc() is invoked only from __init acpi_bus_init()  
Mark it __cpuinit.

The patch is against 2.6.33-rc4

Signed-off-by: Marin Mitov <mitov@issp.bas.bg>

===========================================================================
--- a/drivers/acpi/processor_pdc.c	2010-01-13 21:53:14.000000000 +0200
+++ b/drivers/acpi/processor_pdc.c	2010-01-13 21:58:39.000000000 +0200
@@ -151,7 +151,7 @@
 	return AE_OK;
 }
 
-void acpi_early_processor_set_pdc(void)
+void __cpuinit acpi_early_processor_set_pdc(void)
 {
 	/*
 	 * Check whether the system is DMI table. If yes, OSPM

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Section mismatch: acpi_early_processor_set_pdc()
  2010-01-13 20:44 [PATCH] Section mismatch: acpi_early_processor_set_pdc() Marin Mitov
@ 2010-01-16  7:07 ` Len Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2010-01-16  7:07 UTC (permalink / raw)
  To: Marin Mitov
  Cc: Linux Kernel Mailing List, Rusty Russell, Srivatsa Vaddagiri,
	Zwane Mwaikambo, Ashok Raj, tony.luck, Alex Chiang

I think tony's patch (in my tree) to change this to __init is correct.

thanks,
Len Brown, Intel Open Source Technology Center

On Wed, 13 Jan 2010, Marin Mitov wrote:

> Hi all,
> 
> kernel-2.6.33-rc4, compiler output:
> 
> WARNING: Section mismatch in reference from the function 
> acpi_early_processor_set_pdc() to the variable .cpuinit.data:processor_idle_dmi_table                                                                                           
> The function acpi_early_processor_set_pdc() references                                                                            
> the variable __cpuinitdata processor_idle_dmi_table.                                                                              
> This is often because acpi_early_processor_set_pdc lacks a __cpuinitdata                                                          
> annotation or the annotation of processor_idle_dmi_table is wrong.   
> 
> acpi_early_processor_set_pdc() is invoked only from __init acpi_bus_init()  
> Mark it __cpuinit.
> 
> The patch is against 2.6.33-rc4
> 
> Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
> 
> ===========================================================================
> --- a/drivers/acpi/processor_pdc.c	2010-01-13 21:53:14.000000000 +0200
> +++ b/drivers/acpi/processor_pdc.c	2010-01-13 21:58:39.000000000 +0200
> @@ -151,7 +151,7 @@
>  	return AE_OK;
>  }
>  
> -void acpi_early_processor_set_pdc(void)
> +void __cpuinit acpi_early_processor_set_pdc(void)
>  {
>  	/*
>  	 * Check whether the system is DMI table. If yes, OSPM
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-16  7:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-13 20:44 [PATCH] Section mismatch: acpi_early_processor_set_pdc() Marin Mitov
2010-01-16  7:07 ` Len Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).