* [PATCH] ARM: decompressor: fix a wrong comment
@ 2014-11-28 6:12 Masahiro Yamada
2014-11-28 7:15 ` Nicolas Pitre
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2014-11-28 6:12 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masahiro Yamada, Russell King, Nicolas Pitre, Kevin Hilman,
Will Deacon, Heiko Stuebner, linux-kernel
This comment does not correspond to the actual code.
When zImage is loaded at a lower *OR* higher address of
the destination of Image, it won't overwrite itself.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
arch/arm/boot/compressed/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
index 68be901..9dff614 100644
--- a/arch/arm/boot/compressed/head.S
+++ b/arch/arm/boot/compressed/head.S
@@ -178,7 +178,7 @@ not_angel:
/*
* Set up a page table only if it won't overwrite ourself.
- * That means r4 < pc && r4 - 16k page directory > &_end.
+ * That means r4 < pc || r4 - 16k page directory > &_end.
* Given that r4 > &_end is most unfrequent, we add a rough
* additional 1MB of room for a possible appended DTB.
*/
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: decompressor: fix a wrong comment
2014-11-28 6:12 [PATCH] ARM: decompressor: fix a wrong comment Masahiro Yamada
@ 2014-11-28 7:15 ` Nicolas Pitre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Pitre @ 2014-11-28 7:15 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-arm-kernel, Russell King, Kevin Hilman, Will Deacon,
Heiko Stuebner, linux-kernel
On Fri, 28 Nov 2014, Masahiro Yamada wrote:
> This comment does not correspond to the actual code.
>
> When zImage is loaded at a lower *OR* higher address of
> the destination of Image, it won't overwrite itself.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
>
> arch/arm/boot/compressed/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index 68be901..9dff614 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -178,7 +178,7 @@ not_angel:
>
> /*
> * Set up a page table only if it won't overwrite ourself.
> - * That means r4 < pc && r4 - 16k page directory > &_end.
> + * That means r4 < pc || r4 - 16k page directory > &_end.
> * Given that r4 > &_end is most unfrequent, we add a rough
> * additional 1MB of room for a possible appended DTB.
> */
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-28 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-28 6:12 [PATCH] ARM: decompressor: fix a wrong comment Masahiro Yamada
2014-11-28 7:15 ` Nicolas Pitre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).