From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-mips@linux-mips.org,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] ld-version: fix it on Fedora
Date: Thu, 11 Feb 2016 13:00:32 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.20.1602111249400.2715@eddie.linux-mips.org> (raw)
In-Reply-To: <20160107181920.GE17031@linux-mips.org>
On Thu, 7 Jan 2016, Ralf Baechle wrote:
> > GNU ld version 2.25-15.fc23
> >
> > But ld-version.sh fails to parse this, so e.g. mips build fails to
> > enable VDSO, printing a warning that binutils >= 2.24 is required.
> >
> > To fix, teach ld-version to parse this format.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Which tree should this be merged through? Mine? MIPS?
>
> MIPS is the sole user of ld-ifversion at this time and taking this through
> the MIPS tree will avoid possible merge conflicts with James Hogan's
> pending d5ece1cb074b2c7082c9a2948ac598dd0ad40657 fix ("Fix ld-version.sh to
> handle large 3rd version part"). So I think I should take this through
> the MIPS tree.
FYI, I'm still getting a failure here, with:
$ mips64el-linux-ld --version
GNU ld (GNU Binutils) 2.20.1.20100303
[...]
$
-- so this is a plain upstream development snapshot as these have their
date appended. Can we just get rid of the subversion components beyond
the third, as I already suggested? I.e. stop on the third point and in
any case on a non-point-non-digit.
I'll post a minimal fix shortly, feel free to enhance it if needed.
Maciej
next prev parent reply other threads:[~2016-02-11 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:55 [PATCH] ld-version: fix it on Fedora Michael S. Tsirkin
2016-01-07 18:19 ` Ralf Baechle
2016-02-11 13:00 ` Maciej W. Rozycki [this message]
2016-01-07 18:42 ` Alexandre Oliva
2016-01-13 17:05 ` James Hogan
2016-01-13 17:30 ` Daniel Sanders
[not found] ` <CAJ1xhMWth4kNuEkuVEUiUEz=d_9dmKxh0+Z_GrRcKB+F72W91w@mail.gmail.com>
2016-01-25 10:49 ` Daniel Sanders
2016-01-25 17:30 ` Alexander Kapshuk
2016-01-30 13:38 ` Maciej W. Rozycki
2016-01-31 15:05 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602111249400.2715@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mmarek@suse.com \
--cc=mst@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).