From: Alexandre Oliva <oliva@gnu.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-mips@linux-mips.org,
ralf@linux-mips.org
Subject: Re: [PATCH] ld-version: fix it on Fedora
Date: Thu, 07 Jan 2016 16:42:24 -0200 [thread overview]
Message-ID: <ormvsh44fj.fsf@livre.home> (raw)
In-Reply-To: <1452189189-31188-1-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 7 Jan 2016 19:55:24 +0200")
On Jan 7, 2016, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fedora 23, ld --version outputs:
> GNU ld version 2.25-15.fc23
> But ld-version.sh fails to parse this
On gnewsense 3, ld --version outputs:
GNU ld (GNU Binutils for Debian) 2.20.1-system.20100303
Copyright [...]
The date at the end severely confuses the version parser.
Furthermore, awk is mawk, whose gsub takes ')' as grouping, so it
complains about the missing '('.
Also, once a[1] is multiplied by 1e7, mawk's print spits out the number
in exponential notation, which confuses the -lt test. In order to avoid
that falling back to floating-point numbers, I've used smaller
multipliers and concatenated (truncated) integers. Yuck.
I've modified the script so that it takes the - as a separator too, and
so that it works on both gawk and mawk. Here's the ld-version.sh that
worked for me. I guess this will have to be combined with your patch
somehow.
#!/usr/bin/awk -f
# extract linker version number from stdin and turn into single number
{
gsub(".*[)]", "");
split($1,a, "[-.]");
printf "%i%04i\n", a[1]*10000 + a[2]*100 + a[3], (a[4]*100 + a[5])%10000;
exit
}
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
next prev parent reply other threads:[~2016-01-07 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:55 [PATCH] ld-version: fix it on Fedora Michael S. Tsirkin
2016-01-07 18:19 ` Ralf Baechle
2016-02-11 13:00 ` Maciej W. Rozycki
2016-01-07 18:42 ` Alexandre Oliva [this message]
2016-01-13 17:05 ` James Hogan
2016-01-13 17:30 ` Daniel Sanders
[not found] ` <CAJ1xhMWth4kNuEkuVEUiUEz=d_9dmKxh0+Z_GrRcKB+F72W91w@mail.gmail.com>
2016-01-25 10:49 ` Daniel Sanders
2016-01-25 17:30 ` Alexander Kapshuk
2016-01-30 13:38 ` Maciej W. Rozycki
2016-01-31 15:05 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ormvsh44fj.fsf@livre.home \
--to=oliva@gnu.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mmarek@suse.com \
--cc=mst@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).