From: James Simmons <jsimmons@infradead.org>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: use setup_timer().
Date: Fri, 13 May 2016 20:42:42 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1605132042210.5961@casper.infradead.org> (raw)
In-Reply-To: <1462980251-6608-1-git-send-email-falakreyaz@gmail.com>
> Use setup_timer() for initializing the timer, instead of structure
> assignments.
> This is the preferred/standard way.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Acked-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lnet/lnet/net_fault.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 7d76f28..e4aceb7 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -760,9 +760,7 @@ lnet_delay_rule_add(struct lnet_fault_attr *attr)
> wait_event(delay_dd.dd_ctl_waitq, delay_dd.dd_running);
> }
>
> - init_timer(&rule->dl_timer);
> - rule->dl_timer.function = delay_timer_cb;
> - rule->dl_timer.data = (unsigned long)rule;
> + setup_timer(&rule->dl_timer, delay_timer_cb, (unsigned long)rule);
>
> spin_lock_init(&rule->dl_lock);
> INIT_LIST_HEAD(&rule->dl_msg_list);
> --
> 1.9.1
>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>
prev parent reply other threads:[~2016-05-13 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 15:23 [PATCH] staging: lustre: use setup_timer() Muhammad Falak R Wani
2016-05-13 19:42 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1605132042210.5961@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=devel@driverdev.osuosl.org \
--cc=falakreyaz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).