* [PATCH] staging: lustre: Fix variable type declaration after refactoring
@ 2016-12-08 16:07 Quentin Lambert
2016-12-08 19:36 ` Dan Carpenter
2016-12-08 20:38 ` [PATCH v2] " Quentin Lambert
0 siblings, 2 replies; 4+ messages in thread
From: Quentin Lambert @ 2016-12-08 16:07 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman,
lustre-devel, devel, linux-kernel, kernel-janitors
Cc: Quentin Lambert
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: lustre: Fix variable type declaration after refactoring
2016-12-08 16:07 [PATCH] staging: lustre: Fix variable type declaration after refactoring Quentin Lambert
@ 2016-12-08 19:36 ` Dan Carpenter
2016-12-08 20:38 ` [PATCH v2] " Quentin Lambert
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-12-08 19:36 UTC (permalink / raw)
To: Quentin Lambert
Cc: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman,
lustre-devel, devel, linux-kernel, kernel-janitors
On Thu, Dec 08, 2016 at 05:07:59PM +0100, Quentin Lambert wrote:
> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
>
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
>
> This patch fixes this issue.
>
> Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
0a1200991234f7
Fixes hash is wrong. It should start with "0a".
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] staging: lustre: Fix variable type declaration after refactoring
2016-12-08 16:07 [PATCH] staging: lustre: Fix variable type declaration after refactoring Quentin Lambert
2016-12-08 19:36 ` Dan Carpenter
@ 2016-12-08 20:38 ` Quentin Lambert
2016-12-19 16:38 ` James Simmons
1 sibling, 1 reply; 4+ messages in thread
From: Quentin Lambert @ 2016-12-08 20:38 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman,
lustre-devel, devel, linux-kernel, kernel-janitors
Cc: Quentin Lambert
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
v2: fixes the referenced sha
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring
2016-12-08 20:38 ` [PATCH v2] " Quentin Lambert
@ 2016-12-19 16:38 ` James Simmons
0 siblings, 0 replies; 4+ messages in thread
From: James Simmons @ 2016-12-19 16:38 UTC (permalink / raw)
To: Quentin Lambert
Cc: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, lustre-devel,
devel, linux-kernel, kernel-janitors
> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
>
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
>
> This patch fixes this issue.
Acked-by: James Simmons <jsimmons@infradead.org>
> Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> ---
> v2: fixes the referenced sha
>
> drivers/staging/lustre/lustre/include/obd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/lustre/lustre/include/obd.h
> +++ b/drivers/staging/lustre/lustre/include/obd.h
> @@ -889,7 +889,7 @@ struct obd_client_handle {
> struct md_open_data *och_mod;
> struct lustre_handle och_lease_handle; /* open lock for lease */
> __u32 och_magic;
> - int och_flags;
> + fmode_t och_flags;
> };
>
> #define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-19 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-08 16:07 [PATCH] staging: lustre: Fix variable type declaration after refactoring Quentin Lambert
2016-12-08 19:36 ` Dan Carpenter
2016-12-08 20:38 ` [PATCH v2] " Quentin Lambert
2016-12-19 16:38 ` James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).