fix comments in sound/core.h (fwd)

fix comments in sound/core.h (fwd)

[Pavel Machek]

Do we have sound maintainers? Noone replies on trivial patches :-(.

							Pavel

----- Forwarded message from Pavel Machek <pavel@suse.cz> -----

From: Pavel Machek <pavel@suse.cz>
To: perex@perex.cz, kernel list <linux-kernel@vger.kernel.org>,
	Trivial patch monkey <trivial@kernel.org>, tiwai@suse.de
Subject: fix comments in sound/core.h
X-Warning: Reading this can be dangerous to your mental health.


Two sentences seem to be spliced into one in comment, fix that and fix
english. Also fix codingstyle.

Signed-off-by: Pavel Machek <pavel@suse.cz> 

diff --git a/include/sound/core.h b/include/sound/core.h
index 4fc0235..452000d 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
 int snd_card_file_remove(struct snd_card *card, struct file *file);
 
 #ifndef snd_card_set_dev
-#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
+#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
 #endif
 
 /* device.c */
@@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
  * snd_printd - debug printk
  * @fmt: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG is not set.
  */
 #define snd_printd(fmt, args...) \
@@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
  * snd_printdd - debug printk
  * @format: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
  */
 #define snd_printdd(format, args...) snd_printk(format, ##args)

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: fix comments in sound/core.h (fwd)

[Jaroslav Kysela]

On Tue, 1 Apr 2008, Pavel Machek wrote:

> Do we have sound maintainers? Noone replies on trivial patches :-(.

Applied to ALSA repository. Thanks.

					Jaroslav

> ----- Forwarded message from Pavel Machek <pavel@suse.cz> -----
> 
> From: Pavel Machek <pavel@suse.cz>
> To: perex@perex.cz, kernel list <linux-kernel@vger.kernel.org>,
> 	Trivial patch monkey <trivial@kernel.org>, tiwai@suse.de
> Subject: fix comments in sound/core.h
> X-Warning: Reading this can be dangerous to your mental health.
> 
> 
> Two sentences seem to be spliced into one in comment, fix that and fix
> english. Also fix codingstyle.
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz> 
> 
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 4fc0235..452000d 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
>  int snd_card_file_remove(struct snd_card *card, struct file *file);
>  
>  #ifndef snd_card_set_dev
> -#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
> +#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
>  #endif
>  
>  /* device.c */
> @@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
>   * snd_printd - debug printk
>   * @fmt: format string
>   *
> - * Compiled only when Works like snd_printk() for debugging purpose.
> + * Works like snd_printk() for debugging purposes.
>   * Ignored when CONFIG_SND_DEBUG is not set.
>   */
>  #define snd_printd(fmt, args...) \
> @@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
>   * snd_printdd - debug printk
>   * @format: format string
>   *
> - * Compiled only when Works like snd_printk() for debugging purpose.
> + * Works like snd_printk() for debugging purposes.
>   * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
>   */
>  #define snd_printdd(format, args...) snd_printk(format, ##args)
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 
> 
> ----- End forwarded message -----
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 

-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

Re: fix comments in sound/core.h (fwd)

[Pavel Machek]

On Tue 2008-04-01 14:34:08, Jaroslav Kysela wrote:
> On Tue, 1 Apr 2008, Pavel Machek wrote:
> 
> > Do we have sound maintainers? Noone replies on trivial patches :-(.
> 
> Applied to ALSA repository. Thanks.

There should be queue of few more similar patches (this was first
resend)... will you process them, or should I resend?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: fix comments in sound/core.h (fwd)

[Takashi Iwai]

Hi Pavel,

I've been on vacation (a sort of honeymoon) until April 11.
So I cannot work on your patches right now.  Sorry for inconvenience.


Takashi

On 4/1/08, Pavel Machek <pavel@ucw.cz> wrote:
> Do we have sound maintainers? Noone replies on trivial patches :-(.
>
>                                                        Pavel
>
> ----- Forwarded message from Pavel Machek <pavel@suse.cz> -----
>
> From: Pavel Machek <pavel@suse.cz>
> To: perex@perex.cz, kernel list <linux-kernel@vger.kernel.org>,
>        Trivial patch monkey <trivial@kernel.org>, tiwai@suse.de
> Subject: fix comments in sound/core.h
> X-Warning: Reading this can be dangerous to your mental health.
>
>
> Two sentences seem to be spliced into one in comment, fix that and fix
> english. Also fix codingstyle.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 4fc0235..452000d 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
>  int snd_card_file_remove(struct snd_card *card, struct file *file);
>
>  #ifndef snd_card_set_dev
> -#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
> +#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
>  #endif
>
>  /* device.c */
> @@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
>  * snd_printd - debug printk
>  * @fmt: format string
>  *
> - * Compiled only when Works like snd_printk() for debugging purpose.
> + * Works like snd_printk() for debugging purposes.
>  * Ignored when CONFIG_SND_DEBUG is not set.
>  */
>  #define snd_printd(fmt, args...) \
> @@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
>  * snd_printdd - debug printk
>  * @format: format string
>  *
> - * Compiled only when Works like snd_printk() for debugging purpose.
> + * Works like snd_printk() for debugging purposes.
>  * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
>  */
>  #define snd_printdd(format, args...) snd_printk(format, ##args)
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
>
> ----- End forwarded message -----
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
>

Re: fix comments in sound/core.h (fwd)

[Jesper Juhl]

On Tue, 1 Apr 2008, Pavel Machek wrote:

> Do we have sound maintainers? Noone replies on trivial patches :-(.
> 

I handle trivial patches (well, at least those send to 
trivial@kernel.org).
I don't check that mailbox daily though - for a few reasons;

1. I prefer to wait a while to see if patches get merged elsewhere before 
bothering about them for Trivial.

2. I only just took over Trivial fron Adrian and I've still to work out 
how to deal with it properly.

/Jesper Juhl


> 							Pavel
> 
> ----- Forwarded message from Pavel Machek <pavel@suse.cz> -----
> 
> From: Pavel Machek <pavel@suse.cz>
> To: perex@perex.cz, kernel list <linux-kernel@vger.kernel.org>,
> 	Trivial patch monkey <trivial@kernel.org>, tiwai@suse.de
> Subject: fix comments in sound/core.h
> X-Warning: Reading this can be dangerous to your mental health.
> 
> 
> Two sentences seem to be spliced into one in comment, fix that and fix
> english. Also fix codingstyle.
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz> 
> 
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 4fc0235..452000d 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
>  int snd_card_file_remove(struct snd_card *card, struct file *file);
>  
>  #ifndef snd_card_set_dev
> -#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
> +#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
>  #endif
>  
>  /* device.c */
> @@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
>   * snd_printd - debug printk
>   * @fmt: format string
>   *
> - * Compiled only when Works like snd_printk() for debugging purpose.
> + * Works like snd_printk() for debugging purposes.
>   * Ignored when CONFIG_SND_DEBUG is not set.
>   */
>  #define snd_printd(fmt, args...) \
> @@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
>   * snd_printdd - debug printk
>   * @format: format string
>   *
> - * Compiled only when Works like snd_printk() for debugging purpose.
> + * Works like snd_printk() for debugging purposes.
>   * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
>   */
>  #define snd_printdd(format, args...) snd_printk(format, ##args)
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 
> 
> ----- End forwarded message -----
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 

Re: fix comments in sound/core.h (fwd)

[Pavel Machek]

Hi!

> > Do we have sound maintainers? Noone replies on trivial patches :-(.
> > 
> 
> I handle trivial patches (well, at least those send to 
> trivial@kernel.org).
> I don't check that mailbox daily though - for a few reasons;
> 
> 1. I prefer to wait a while to see if patches get merged elsewhere before 
> bothering about them for Trivial.
> 
> 2. I only just took over Trivial fron Adrian and I've still to work out 
> how to deal with it properly.

No problem. I this is already merged, so ignore this...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html