* Re: [PATCH] WeTab device ID
[not found] <4D0AA66F.6080506@plausible.org>
@ 2010-12-17 12:03 ` Henrik Rydberg
2010-12-17 21:21 ` Andy Ross
2010-12-18 0:06 ` Jiri Kosina
0 siblings, 2 replies; 6+ messages in thread
From: Henrik Rydberg @ 2010-12-17 12:03 UTC (permalink / raw)
To: Andy Ross; +Cc: Dmitry Torokhov, Jiri Kosina, linux-input, linux-kernel
Hi Andy,
> > > Hi. I'm looking at getting a WeTab running right now and just
> > > found this patch set. It's a few weeks old now and not upstream
> > > yet, so before I start hacking at it I thought I should check with
> > > you to make sure there isn't a more current one available.
> >
> > You find the tip of the mt work at
> > git://git.kernel.org/pub/scm/linux/kernel/git/rydberg/input-mt.git
>
> Thanks much. It works great, though on our WeTab it's missing the
> device ID of the part on the board. Patch below:
Thanks for the patch. Does the one below work for you?
Henrik
---
>From a8b4613b6d7e7cf04a7335930e9c5c2fb44302d0 Mon Sep 17 00:00:00 2001
From: Andy Ross <andy@plausible.org>
Date: Thu, 16 Dec 2010 15:53:19 -0800
Subject: [PATCH] hid: egalax: Add support for Wetab (726b)
This patch adds support for another Wetab device (726b), and grabs it
accordingly in hid-core.
[rydberg@euromail.se: rename and log message changes]
Signed-off-by: Andy Ross <andy@plausible.org>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-egalax.c | 2 ++
drivers/hid/hid-ids.h | 1 +
3 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index f4a37f8..88668ae 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1302,6 +1302,7 @@ static const struct hid_device_id hid_blacklist[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH1) },
{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2) },
{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_BM084) },
{ HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) },
{ HID_USB_DEVICE(USB_VENDOR_ID_GAMERON, USB_DEVICE_ID_GAMERON_DUAL_PSX_ADAPTOR) },
diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c
index 8787850..16566fc 100644
--- a/drivers/hid/hid-egalax.c
+++ b/drivers/hid/hid-egalax.c
@@ -242,6 +242,8 @@ static const struct hid_device_id egalax_devices[] = {
USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2) },
{ HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
+ USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4) },
{ }
};
MODULE_DEVICE_TABLE(hid, egalax_devices);
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index a95719b..0f150c7 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -198,6 +198,7 @@
#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH1 0x720c
#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH2 0x72a1
#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH3 0x480e
+#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH4 0x726b
#define USB_VENDOR_ID_ELECOM 0x056e
#define USB_DEVICE_ID_ELECOM_BM084 0x0061
--
1.7.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] WeTab device ID
2010-12-17 12:03 ` [PATCH] WeTab device ID Henrik Rydberg
@ 2010-12-17 21:21 ` Andy Ross
2010-12-17 21:58 ` Henrik Rydberg
2010-12-18 0:06 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Andy Ross @ 2010-12-17 21:21 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Dmitry Torokhov, Jiri Kosina, linux-input, linux-kernel
On 12/17/2010 04:03 AM, Henrik Rydberg wrote:
> Thanks for the patch. Does the one below work for you?
Looks like this is against more recent changes than I see in the "hid"
branch of input-mt on kernel.org. I don't see a
"...EGALAX_MULTITOUCH3" defined there. Maybe you missed a push? So
not tested as-is, but certainly looks correct by inspection.
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WeTab device ID
2010-12-17 21:21 ` Andy Ross
@ 2010-12-17 21:58 ` Henrik Rydberg
2010-12-17 23:03 ` Andy Ross
0 siblings, 1 reply; 6+ messages in thread
From: Henrik Rydberg @ 2010-12-17 21:58 UTC (permalink / raw)
To: Andy Ross; +Cc: Dmitry Torokhov, Jiri Kosina, linux-input, linux-kernel
On Fri, Dec 17, 2010 at 01:21:07PM -0800, Andy Ross wrote:
> On 12/17/2010 04:03 AM, Henrik Rydberg wrote:
> > Thanks for the patch. Does the one below work for you?
>
> Looks like this is against more recent changes than I see in the "hid"
> branch of input-mt on kernel.org. I don't see a
> "...EGALAX_MULTITOUCH3" defined there. Maybe you missed a push? So
> not tested as-is, but certainly looks correct by inspection.
Ah, the tip is actually at the next branch, never did say that.
Thanks,
Henrik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WeTab device ID
2010-12-17 21:58 ` Henrik Rydberg
@ 2010-12-17 23:03 ` Andy Ross
0 siblings, 0 replies; 6+ messages in thread
From: Andy Ross @ 2010-12-17 23:03 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Dmitry Torokhov, Jiri Kosina, linux-input, linux-kernel
On 12/17/2010 01:58 PM, Henrik Rydberg wrote:
> On Fri, Dec 17, 2010 at 01:21:07PM -0800, Andy Ross wrote:
>> > On 12/17/2010 04:03 AM, Henrik Rydberg wrote:
>>> > > Thanks for the patch. Does the one below work for you?
>> >
>> > Looks like this is against more recent changes than I see in the "hid"
>> > branch of input-mt on kernel.org. I don't see a
>> > "...EGALAX_MULTITOUCH3" defined there. Maybe you missed a push? So
>> > not tested as-is, but certainly looks correct by inspection.
>
> Ah, the tip is actually at the next branch, never did say that.
OK, makes much more sense. Applies and works great, thanks.
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WeTab device ID
2010-12-17 12:03 ` [PATCH] WeTab device ID Henrik Rydberg
2010-12-17 21:21 ` Andy Ross
@ 2010-12-18 0:06 ` Jiri Kosina
2010-12-18 6:49 ` Henrik Rydberg
1 sibling, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2010-12-18 0:06 UTC (permalink / raw)
To: Henrik Rydberg
Cc: Andy Ross, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input, linux-kernel
On Fri, 17 Dec 2010, Henrik Rydberg wrote:
> Hi Andy,
>
> > > > Hi. I'm looking at getting a WeTab running right now and just
> > > > found this patch set. It's a few weeks old now and not upstream
> > > > yet, so before I start hacking at it I thought I should check with
> > > > you to make sure there isn't a more current one available.
> > >
> > > You find the tip of the mt work at
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rydberg/input-mt.git
> >
> > Thanks much. It works great, though on our WeTab it's missing the
> > device ID of the part on the board. Patch below:
>
> Thanks for the patch. Does the one below work for you?
>
> Henrik
> ---
> >From a8b4613b6d7e7cf04a7335930e9c5c2fb44302d0 Mon Sep 17 00:00:00 2001
> From: Andy Ross <andy@plausible.org>
> Date: Thu, 16 Dec 2010 15:53:19 -0800
> Subject: [PATCH] hid: egalax: Add support for Wetab (726b)
>
> This patch adds support for another Wetab device (726b), and grabs it
> accordingly in hid-core.
>
> [rydberg@euromail.se: rename and log message changes]
> Signed-off-by: Andy Ross <andy@plausible.org>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
I guess you are going to take it together with your pile to Dmitry, right
Henrik?
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] WeTab device ID
2010-12-18 0:06 ` Jiri Kosina
@ 2010-12-18 6:49 ` Henrik Rydberg
0 siblings, 0 replies; 6+ messages in thread
From: Henrik Rydberg @ 2010-12-18 6:49 UTC (permalink / raw)
To: Jiri Kosina
Cc: Andy Ross, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input, linux-kernel
> > From: Andy Ross <andy@plausible.org>
> > Date: Thu, 16 Dec 2010 15:53:19 -0800
> > Subject: [PATCH] hid: egalax: Add support for Wetab (726b)
> >
> > This patch adds support for another Wetab device (726b), and grabs it
> > accordingly in hid-core.
> >
> > [rydberg@euromail.se: rename and log message changes]
> > Signed-off-by: Andy Ross <andy@plausible.org>
> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> I guess you are going to take it together with your pile to Dmitry, right
> Henrik?
Yep - thanks!
Henrik
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-18 6:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <4D0AA66F.6080506@plausible.org>
2010-12-17 12:03 ` [PATCH] WeTab device ID Henrik Rydberg
2010-12-17 21:21 ` Andy Ross
2010-12-17 21:58 ` Henrik Rydberg
2010-12-17 23:03 ` Andy Ross
2010-12-18 0:06 ` Jiri Kosina
2010-12-18 6:49 ` Henrik Rydberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).