* [PATCH][resend] Remove pointless memset in nfsacl_encode()
@ 2011-03-21 19:35 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2011-03-21 19:35 UTC (permalink / raw)
To: linux-nfs
Cc: Trond Myklebust, Milton Miller, Chuck Lever, linux-kernel,
Neil Brown, bfields
Remove pointless memset() in nfsacl_encode().
Thanks to Trond Myklebust <Trond.Myklebust@netapp.com> for pointing out
that it is not needed since posix_acl_init() will set everything
regardless..
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
nfsacl.c | 1 -
1 file changed, 1 deletion(-)
Patch against up-to-date Linus' tree.
diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
index 84c27d6..ec0f277 100644
--- a/fs/nfs_common/nfsacl.c
+++ b/fs/nfs_common/nfsacl.c
@@ -117,7 +117,6 @@ int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode,
* invoked in contexts where a memory allocation failure is
* fatal. Fortunately this fake ACL is small enough to
* construct on the stack. */
- memset(acl2, 0, sizeof(acl2));
posix_acl_init(acl2, 4);
/* Insert entries in canonical order: other orders seem
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-03-21 19:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-21 19:35 [PATCH][resend] Remove pointless memset in nfsacl_encode() Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).