* [PATCH] HID: hid-debug: Show rdesc for unclaimed devices
@ 2012-08-21 18:22 Henrik Rydberg
2012-08-27 15:07 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Henrik Rydberg @ 2012-08-21 18:22 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Dmitry Torokhov, linux-input, linux-kernel, Henrik Rydberg
Since commit a7197c2e, the raw report descriptor is available also for
unclaimed devices. This patchs make it show in the rdesc debugfs node.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
drivers/hid/hid-debug.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 01dd9a7..933fff0 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -911,15 +911,21 @@ static void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f)
}
-
static int hid_debug_rdesc_show(struct seq_file *f, void *p)
{
struct hid_device *hdev = f->private;
+ const __u8 *rdesc = hdev->rdesc;
+ unsigned rsize = hdev->rsize;
int i;
+ if (!rdesc) {
+ rdesc = hdev->dev_rdesc;
+ rsize = hdev->dev_rsize;
+ }
+
/* dump HID report descriptor */
- for (i = 0; i < hdev->rsize; i++)
- seq_printf(f, "%02x ", hdev->rdesc[i]);
+ for (i = 0; i < rsize; i++)
+ seq_printf(f, "%02x ", rdesc[i]);
seq_printf(f, "\n\n");
/* dump parsed data and input mappings */
--
1.7.11.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: hid-debug: Show rdesc for unclaimed devices
2012-08-21 18:22 [PATCH] HID: hid-debug: Show rdesc for unclaimed devices Henrik Rydberg
@ 2012-08-27 15:07 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2012-08-27 15:07 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Dmitry Torokhov, linux-input, linux-kernel, Henrik Rydberg
On Tue, 21 Aug 2012, Henrik Rydberg wrote:
> Since commit a7197c2e, the raw report descriptor is available also for
> unclaimed devices. This patchs make it show in the rdesc debugfs node.
Definitely nice to have. Applied, thanks Henrik.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> ---
> drivers/hid/hid-debug.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 01dd9a7..933fff0 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -911,15 +911,21 @@ static void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f)
>
> }
>
> -
> static int hid_debug_rdesc_show(struct seq_file *f, void *p)
> {
> struct hid_device *hdev = f->private;
> + const __u8 *rdesc = hdev->rdesc;
> + unsigned rsize = hdev->rsize;
> int i;
>
> + if (!rdesc) {
> + rdesc = hdev->dev_rdesc;
> + rsize = hdev->dev_rsize;
> + }
> +
> /* dump HID report descriptor */
> - for (i = 0; i < hdev->rsize; i++)
> - seq_printf(f, "%02x ", hdev->rdesc[i]);
> + for (i = 0; i < rsize; i++)
> + seq_printf(f, "%02x ", rdesc[i]);
> seq_printf(f, "\n\n");
>
> /* dump parsed data and input mappings */
> --
> 1.7.11.5
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-27 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-21 18:22 [PATCH] HID: hid-debug: Show rdesc for unclaimed devices Henrik Rydberg
2012-08-27 15:07 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).