From: Jiri Kosina <jkosina@suse.cz>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Daniel Leung <daniel.leung@linux.intel.com>,
srinivas.pandruvada@intel.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hid-sensor-hub: do not process feature reports in raw_event
Date: Wed, 29 May 2013 16:19:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1305291619040.30576@pobox.suse.cz> (raw)
In-Reply-To: <516588E2.4030901@linux.intel.com>
On Wed, 10 Apr 2013, Srinivas Pandruvada wrote:
> I don't know if this should be fixed in client drivers since other drivers may
> have this issue.
Agreed.
Srinivas, how about the patch below, could you please test it in your
scenario to see whether it actually fixes the issue?
Thanks.
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 264f550..65879b9 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1293,7 +1293,7 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
if (hdrv && hdrv->raw_event && hid_match_report(hid, report)) {
ret = hdrv->raw_event(hid, report, data, size);
- if (ret != 0) {
+ if (ret < 0) {
ret = ret < 0 ? ret : 0;
goto unlock;
}
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2013-05-29 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 17:22 [PATCH] HID: hid-sensor-hub: do not process feature reports in raw_event daniel.leung
2013-03-25 15:45 ` Srinivas Pandruvada
2013-03-27 15:09 ` Jiri Kosina
2013-04-04 7:48 ` Jiri Kosina
2013-04-08 16:54 ` Daniel Leung
2013-04-09 23:55 ` Daniel Leung
2013-04-10 15:44 ` Srinivas Pandruvada
2013-05-29 14:19 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1305291619040.30576@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=daniel.leung@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).