From: Jiri Kosina <jkosina@suse.cz>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: bcrl@kvack.org, akpm@linux-foundation.org, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] page_migrate: Fix wrong comment in address_space_operations->migratepage()
Date: Tue, 20 Aug 2013 13:02:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1308201302290.21654@pobox.suse.cz> (raw)
In-Reply-To: <1371723023-4060-3-git-send-email-tangchen@cn.fujitsu.com>
On Thu, 20 Jun 2013, Tang Chen wrote:
> There is no parameter "sync" in address_space_operations->migratepage().
> It should be mograte_mode. And the comment is for MIGRATE_ASYNC.
I am fixing this typo in changelog :) and applying the series.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
> include/linux/fs.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 43db02e..c1a76ac 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -372,8 +372,8 @@ struct address_space_operations {
> int (*get_xip_mem)(struct address_space *, pgoff_t, int,
> void **, unsigned long *);
> /*
> - * migrate the contents of a page to the specified target. If sync
> - * is false, it must not block.
> + * migrate the contents of a page to the specified target. If
> + * migrate_mode is MIGRATE_ASYNC, it must not block.
> */
> int (*migratepage) (struct address_space *,
> struct page *, struct page *, enum migrate_mode);
> --
> 1.7.1
>
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2013-08-20 11:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 10:10 [PATCH 0/5] Fix some wrong comments Tang Chen
2013-06-20 10:10 ` [PATCH 1/5] page_isolation: Fix a comment typo in test_pages_isolated() Tang Chen
2013-06-20 13:17 ` Zhang Yanfei
2013-06-21 1:12 ` Tang Chen
2013-06-20 10:10 ` [PATCH 2/5] page_migrate: Fix wrong comment in address_space_operations->migratepage() Tang Chen
2013-08-20 11:02 ` Jiri Kosina [this message]
2013-08-20 11:05 ` Tang Chen
2013-06-20 10:10 ` [PATCH 3/5] aio: Fix wrong comment in aio_complete() Tang Chen
2013-06-20 10:10 ` [PATCH 4/5] memblock: Fix wrong comment in __next_free_mem_range() Tang Chen
2013-06-20 10:10 ` [PATCH 5/5] bootmem, numa: Fix a comment typo in register_page_bootmem_info_node() Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1308201302290.21654@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).