From: Tang Chen <tangchen@cn.fujitsu.com>
To: Zhang Yanfei <zhangyanfei.yes@gmail.com>
Cc: bcrl@kvack.org, akpm@linux-foundation.org, hpa@zytor.com,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] page_isolation: Fix a comment typo in test_pages_isolated()
Date: Fri, 21 Jun 2013 09:12:45 +0800 [thread overview]
Message-ID: <51C3A88D.30408@cn.fujitsu.com> (raw)
In-Reply-To: <51C300FF.50208@gmail.com>
On 06/20/2013 09:17 PM, Zhang Yanfei wrote:
> On 06/20/2013 06:10 PM, Tang Chen wrote:
>> pageblock_nr_page should be pageblock_nr_pages, and fist is
>> a typo of first.
>>
>> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com>
>> ---
>> mm/page_isolation.c | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
>> index 383bdbb..0cee10f 100644
>> --- a/mm/page_isolation.c
>> +++ b/mm/page_isolation.c
>> @@ -226,9 +226,9 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
>> int ret;
>>
>> /*
>> - * Note: pageblock_nr_page != MAX_ORDER. Then, chunks of free page
>> - * is not aligned to pageblock_nr_pages.
>> - * Then we just check pagetype fist.
>> + * Note: pageblock_nr_pages != MAX_ORDER. Then, chunks of free pages
>
> pageblock_nr_pages is the count of pages while MAX_ORDER is a order. Here
> may be pageblock_order != MAX_ORDER.
Hum, yes. Since we have:
#define pageblock_nr_pages (1UL << pageblock_order)
it should be pageblock_order.
>
>> + * are not aligned to pageblock_nr_pages.
>> + * Then we just check migratetype first.
>> */
>> for (pfn = start_pfn; pfn< end_pfn; pfn += pageblock_nr_pages) {
>> page = __first_valid_page(pfn, pageblock_nr_pages);
>> @@ -238,7 +238,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
>> page = __first_valid_page(start_pfn, end_pfn - start_pfn);
>> if ((pfn< end_pfn) || !page)
>> return -EBUSY;
>> - /* Check all pages are free or Marked as ISOLATED */
>> + /* Check all pages are free or marked as ISOLATED */
>> zone = page_zone(page);
>> spin_lock_irqsave(&zone->lock, flags);
>> ret = __test_page_isolated_in_pageblock(start_pfn, end_pfn,
>
>
next prev parent reply other threads:[~2013-06-21 1:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 10:10 [PATCH 0/5] Fix some wrong comments Tang Chen
2013-06-20 10:10 ` [PATCH 1/5] page_isolation: Fix a comment typo in test_pages_isolated() Tang Chen
2013-06-20 13:17 ` Zhang Yanfei
2013-06-21 1:12 ` Tang Chen [this message]
2013-06-20 10:10 ` [PATCH 2/5] page_migrate: Fix wrong comment in address_space_operations->migratepage() Tang Chen
2013-08-20 11:02 ` Jiri Kosina
2013-08-20 11:05 ` Tang Chen
2013-06-20 10:10 ` [PATCH 3/5] aio: Fix wrong comment in aio_complete() Tang Chen
2013-06-20 10:10 ` [PATCH 4/5] memblock: Fix wrong comment in __next_free_mem_range() Tang Chen
2013-06-20 10:10 ` [PATCH 5/5] bootmem, numa: Fix a comment typo in register_page_bootmem_info_node() Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C3A88D.30408@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=zhangyanfei.yes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).