linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Jessica Yu <jeyu@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Petr Mladek <pmladek@suse.com>, Jonathan Corbet <corbet@lwn.net>,
	Miroslav Benes <mbenes@suse.cz>,
	linux-api@vger.kernel.org, live-patching@vger.kernel.org,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-doc@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: (mostly) Arch-independent livepatch
Date: Wed, 30 Mar 2016 01:24:08 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1603300122020.3656@cbobk.fhfr.pm> (raw)
In-Reply-To: <20160329211330.GA1253@packer-debian-8-amd64.digitalocean.com>

On Tue, 29 Mar 2016, Jessica Yu wrote:

> > v6:
> > - Since we hard-code the field widths for the objname and symbol name
> >   for the sscanf() calls, which are supposed to correspond to the values
> >   of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
> >   the values of these constants deviate from the expected values.
> > - Squash the sample livepatch module patch into patch 4
> >   ("livepatch: reuse module loader code to write relocations") so
> >   git bisects don't break
> > - Don't need the klp_buf struct, just use plain char arrays to hold the
> >   output of sscanf(). Also, no need to clear the bufs after every
> >   invocation, as sscanf() takes care to put a null byte at the end of
> >   the bufs.
> > - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
> > - Fixed some small module.c nits
> > 
> 
> Pinging Rusty, just in case this thread got buried :-)
> How do the module.c changes look?

Plus there are (admittedly indeed rather small and trivial) changes to 
s390 module loader, so I'd prefer to have Heiko's / Martin's Ack before 
merging this.

Hence, let me piggy back on this ping to Rusty, and let me ping Heiko and 
Martin as well (adding to CC explicitly to make sure this doesn't get lost 
in general noise).

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2016-03-29 23:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23  0:03 [PATCH v6 0/5] (mostly) Arch-independent livepatch Jessica Yu
2016-03-23  0:03 ` [PATCH v6 1/5] Elf: add livepatch-specific Elf constants Jessica Yu
2016-03-23  0:03 ` [PATCH v6 2/5] module: preserve Elf information for livepatch modules Jessica Yu
2016-03-31 23:17   ` Rusty Russell
2016-03-23  0:03 ` [PATCH v6 3/5] module: s390: keep mod_arch_specific " Jessica Yu
2016-03-23  0:03 ` [PATCH v6 4/5] livepatch: reuse module loader code to write relocations Jessica Yu
2016-03-23  0:03 ` [PATCH v6 5/5] Documentation: livepatch: outline Elf format and requirements for patch modules Jessica Yu
2016-03-23 13:00 ` [PATCH v6 0/5] (mostly) Arch-independent livepatch Josh Poimboeuf
2016-03-23 13:50 ` Miroslav Benes
2016-03-29 21:13 ` Jessica Yu
2016-03-29 23:24   ` Jiri Kosina [this message]
2016-03-30  7:10     ` Heiko Carstens
2016-04-01 15:00 ` [PATCH v6 0/5] " Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1603300122020.3656@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=corbet@lwn.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jeyu@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --cc=rusty@rustcorp.com.au \
    --cc=schwidefsky@de.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).