From: Jiri Kosina <jikos@kernel.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
jeyu@redhat.com, pmladek@suse.com, jslaby@suse.cz,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
huawei.libin@huawei.com, minfei.huang@yahoo.com
Subject: Re: [RFC PATCH] livepatch: allow removal of a disabled patch
Date: Wed, 1 Jun 2016 01:13:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1606010112020.31937@cbobk.fhfr.pm> (raw)
In-Reply-To: <alpine.LNX.2.00.1605031008550.23480@pobox.suse.cz>
On Tue, 3 May 2016, Miroslav Benes wrote:
> > > Currently we do not allow patch module to unload since there is no
> > > method to determine if a task is still running in the patched code.
> > >
> > > The consistency model gives us the way because when the patching
> > > finishes we know that all tasks were marked as safe to call a new
> > > patched function. Thus every new call to the function calls the new
> > > patched code and at the same time no task can be somewhere in the old
> > > code, because it had to leave that code to be marked as safe.
> > >
> > > We can safely let the patch module go after that.
> >
> > I found this a little confusing because it talks about patching, whereas
> > we really want to remove the patch module after _unpatching_ it.
>
> You're right. I'll rephrase that.
Now that it's been settled that this way (completion) is the way to go,
could you please incorporate the feedback (and persumably also add Acks
from Josh and Jessica) and send me v2?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-05-31 23:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 11:57 [RFC PATCH] livepatch: allow removal of a disabled patch Miroslav Benes
2016-05-02 15:08 ` Josh Poimboeuf
2016-05-03 8:16 ` Miroslav Benes
2016-05-31 23:13 ` Jiri Kosina [this message]
2016-05-03 21:37 ` Josh Poimboeuf
2016-05-03 22:31 ` Jiri Kosina
2016-05-04 2:39 ` Josh Poimboeuf
2016-05-04 3:36 ` Josh Poimboeuf
2016-05-04 11:58 ` Miroslav Benes
2016-05-04 13:14 ` Josh Poimboeuf
2016-05-04 14:35 ` Miroslav Benes
2016-05-04 16:14 ` Josh Poimboeuf
2016-05-05 8:28 ` Miroslav Benes
2016-05-05 13:27 ` Josh Poimboeuf
2016-05-05 14:25 ` Miroslav Benes
2016-05-05 15:04 ` Josh Poimboeuf
2016-05-05 21:08 ` Jiri Kosina
2016-05-06 0:42 ` Jessica Yu
2016-05-06 7:51 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1606010112020.31937@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=huawei.libin@huawei.com \
--cc=jeyu@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=minfei.huang@yahoo.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).