From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 12/14] nubus: Rename struct nubus_dev
Date: Tue, 14 Nov 2017 11:18:49 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1711132052080.3@nippy.intranet> (raw)
In-Reply-To: <CAMuHMdUkMTHZA8zjky6Tmj1mdtyA0GkJXGt2QSvFd8Of63TOaA@mail.gmail.com>
On Mon, 13 Nov 2017, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain <fthain@telegraphics.com.au>
> wrote:
> > It is misleading to use "dev" to mean a functional resource. And in
> > adopting the Linux Driver Model, struct nubus_board will embed a
> > struct device. Drivers will then bind with boards, not with functional
> > resources.
> >
> > Rename struct nubus_dev as struct nubus_functional_resource. This is
> > the vendor's terminology and avoids confusion.
>
> Isn't "struct nubus_functional_resource" a bit long?
Right.
> What about "nubus_res"? "nubus_fres"?
>
I think the temporary variables can remain 'fres', as that's just a
mnemonic, though the declaration really ought to tell us something
meaningful.
You and I both avoided 'func' as an abbreviation. I think it suggests a
'C' function pointer. And 'res' and 'rsrc' suggest an ioport.h struct
resource. An unambiguous compromise would be 'nubus_functional_rsrc' but
maybe this is still too long?
Perhaps 'struct nubus_rsrc' or 'struct nubus_res' are okay if we can keep
the distinction between 'functional resources', 'slot resources' and
'board resources' clear by naming instances appropriately? E.g.
@@ -33,7 +33,7 @@ struct nubus_dirent {
struct nubus_board {
struct nubus_board *next;
- struct nubus_dev *first_dev;
+ struct nubus_rsrc *first_func_rsrc;
/* Only 9-E actually exist, though 0-8 are also theoretically
possible, and 0 is a special case which represents the
@@ -81,8 +81,8 @@ struct nubus_dev {
struct nubus_board *board;
};
-/* This is all NuBus devices (used to find devices later on) */
-extern struct nubus_dev *nubus_devices;
+/* This is all NuBus functional resources (used to find devices later on)
*/
+extern struct nubus_rsrc *nubus_func_rsrcs;
/* This is all NuBus cards */
extern struct nubus_board *nubus_boards;
etc.
--
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2017-11-14 0:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 6:12 [PATCH 00/14] Modernization and fixes for NuBus subsystem Finn Thain
2017-11-11 6:12 ` [PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/ Finn Thain
2017-11-11 6:12 ` [PATCH 04/14] nubus: Fix log spam Finn Thain
2017-11-11 15:04 ` Joe Perches
2017-11-11 23:47 ` Finn Thain
2017-11-12 0:08 ` Joe Perches
2017-11-11 6:12 ` [PATCH 05/14] nubus: Validate slot resource IDs Finn Thain
2017-11-11 6:12 ` [PATCH 02/14] nubus: Fix up header split Finn Thain
2017-11-11 6:12 ` [PATCH 09/14] nubus: Don't needlessly unpack vidname and driver resources Finn Thain
2017-11-11 6:12 ` [PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/ Finn Thain
2017-11-13 8:56 ` Geert Uytterhoeven
2017-11-14 0:21 ` Finn Thain
2017-11-11 6:12 ` [PATCH 03/14] nubus: Use static functions where possible Finn Thain
2017-11-11 6:12 ` [PATCH 01/14] nubus: Avoid array underflow and overflow Finn Thain
2017-11-11 6:12 ` [PATCH 08/14] nubus: Clean up whitespace Finn Thain
2017-11-11 6:12 ` [PATCH 06/14] nubus: Call proc_mkdir() not more than once per slot Finn Thain
2017-11-11 6:12 ` [PATCH 07/14] nubus: Remove redundant code Finn Thain
2017-11-11 6:12 ` [PATCH 13/14] nubus: Add expansion_type values for various Mac models Finn Thain
2017-11-11 6:12 ` [PATCH 14/14] nubus: Add support for the driver model Finn Thain
2017-11-11 8:45 ` Greg Kroah-Hartman
2017-11-11 8:46 ` Greg Kroah-Hartman
2017-11-12 3:52 ` Finn Thain
2017-11-11 6:12 ` [PATCH 12/14] nubus: Rename struct nubus_dev Finn Thain
2017-11-13 8:57 ` Geert Uytterhoeven
2017-11-14 0:18 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1711132052080.3@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).