From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/
Date: Mon, 13 Nov 2017 09:56:35 +0100 [thread overview]
Message-ID: <CAMuHMdUCWzmGNyPp0OV-XFvtyTcxCgW-eLKdxnkd0gg_rGToVw@mail.gmail.com> (raw)
In-Reply-To: <51c5a1526bbf522bbb76d6a71040c220e7e72a8a.1510377369.git.fthain@telegraphics.com.au>
Hi Finn,
On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> Create the /proc/bus/nubus/s/ inodes while scanning slot s. During
> descent through slot resource subdirectories, call the new
> nubus_proc_add_foo() functions to create the procfs inodes.
>
> Also add a new function, nubus_seq_write_rsrc_mem(), to write the
> contents of a particular slot resource to a given seq_file. This is
> used by the procfs file_operations methods, to finally give userspace
> access to slot ROM information, such as the available video modes.
>
> Tested-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Thanks for your patch!
> ---
> drivers/nubus/nubus.c | 117 +++++++++++++++++++++++++++-------
> drivers/nubus/proc.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++---
> include/linux/nubus.h | 35 ++++++++++-
> 3 files changed, 288 insertions(+), 34 deletions(-)
Wow, that's much more code added than was removed by "[PATCH 10/14] nubus:
Depopulate /proc/bus/nubus/s/":
drivers/nubus/proc.c | 100 --------------------------------------------------
include/linux/nubus.h | 1 -
2 files changed, 101 deletions(-)
How much memory is saved by not using the stored representation of
slot resource data?
BTW, should 10 and 11 be combined, to avoid a regression during bisection?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-11-13 8:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 6:12 [PATCH 00/14] Modernization and fixes for NuBus subsystem Finn Thain
2017-11-11 6:12 ` [PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/ Finn Thain
2017-11-11 6:12 ` [PATCH 04/14] nubus: Fix log spam Finn Thain
2017-11-11 15:04 ` Joe Perches
2017-11-11 23:47 ` Finn Thain
2017-11-12 0:08 ` Joe Perches
2017-11-11 6:12 ` [PATCH 05/14] nubus: Validate slot resource IDs Finn Thain
2017-11-11 6:12 ` [PATCH 02/14] nubus: Fix up header split Finn Thain
2017-11-11 6:12 ` [PATCH 09/14] nubus: Don't needlessly unpack vidname and driver resources Finn Thain
2017-11-11 6:12 ` [PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/ Finn Thain
2017-11-13 8:56 ` Geert Uytterhoeven [this message]
2017-11-14 0:21 ` Finn Thain
2017-11-11 6:12 ` [PATCH 03/14] nubus: Use static functions where possible Finn Thain
2017-11-11 6:12 ` [PATCH 01/14] nubus: Avoid array underflow and overflow Finn Thain
2017-11-11 6:12 ` [PATCH 08/14] nubus: Clean up whitespace Finn Thain
2017-11-11 6:12 ` [PATCH 06/14] nubus: Call proc_mkdir() not more than once per slot Finn Thain
2017-11-11 6:12 ` [PATCH 07/14] nubus: Remove redundant code Finn Thain
2017-11-11 6:12 ` [PATCH 13/14] nubus: Add expansion_type values for various Mac models Finn Thain
2017-11-11 6:12 ` [PATCH 14/14] nubus: Add support for the driver model Finn Thain
2017-11-11 8:45 ` Greg Kroah-Hartman
2017-11-11 8:46 ` Greg Kroah-Hartman
2017-11-12 3:52 ` Finn Thain
2017-11-11 6:12 ` [PATCH 12/14] nubus: Rename struct nubus_dev Finn Thain
2017-11-13 8:57 ` Geert Uytterhoeven
2017-11-14 0:18 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUCWzmGNyPp0OV-XFvtyTcxCgW-eLKdxnkd0gg_rGToVw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).