From: Alexander Monakov <amonakov@ispras.ru>
To: platform-driver-x86@vger.kernel.org
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Hans de Goede <hdegoede@redhat.com>,
Alexander.Deucher@amd.com, linux-kernel@vger.kernel.org
Subject: amd-pmc s2idle driver issues
Date: Mon, 21 Dec 2020 00:12:14 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.13.2012202341520.6949@monopod.intra.ispras.ru> (raw)
Hi folks,
I've tried the "platform/x86: amd-pmc: Add AMD platform support for S2Idle"
patch on my Acer Swift SF314-42 laptop (Renoir SoC, Ryzen 4500U CPU) and hit
the following issues:
1. The driver doesn't bind to any device. It has the following binding table:
+static const struct acpi_device_id amd_pmc_acpi_ids[] = {
+ {"AMDI0005", 0},
+ {"AMD0004", 0},
+ { }
+};
This laptop has "AMD0005" instead. Adding it to the list allows the driver to
successfully probe.
2. The debugfs interface does not seem to be very helpful. It shows
SMU FW Info: ffffffff
It's not very informative. The code seems to be fetching SMU version from mmio,
so I guess the file should be saying "FW version" rather than "FW Info", and
then, I think version number is not supposed to be "-1".
(and I'm afraid I cannot use the driver, as there seems to be an issue with
GPU resume: sometimes the screen is frozen or black after resume, so I need
to reboot the laptop :( )
Alexander
next reply other threads:[~2020-12-20 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 21:12 Alexander Monakov [this message]
2020-12-22 14:16 ` amd-pmc s2idle driver issues Deucher, Alexander
2020-12-22 14:45 ` Alexander Monakov
2020-12-22 15:20 ` Deucher, Alexander
2020-12-22 15:57 ` Alexander Monakov
2020-12-22 16:44 ` Deucher, Alexander
2020-12-22 17:25 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.2012202341520.6949@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=Alexander.Deucher@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).