From: Alexander Monakov <amonakov@ispras.ru>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
Hans de Goede <hdegoede@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: amd-pmc s2idle driver issues
Date: Tue, 22 Dec 2020 18:57:15 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.13.2012221834180.10565@monopod.intra.ispras.ru> (raw)
In-Reply-To: <MN2PR12MB4488CC1657EAEAB16886A200F7DF0@MN2PR12MB4488.namprd12.prod.outlook.com>
On Tue, 22 Dec 2020, Deucher, Alexander wrote:
> > Yes. Out-of-the-box it's a "modern standby" laptop. There's a "hidden"
> > bios menu with extra settings that apparently allows to select legacy S3.
> > I did not change it, so I'm testing the "modern" mode.
> >
> > Note that this driver fetches SMU version from MMIO, which looks odd to
> > me:
> > elsewhere (i.e. in the amdgpu driver) SMU version is retrieved by issuing the
> > corresponding SMU command, as far as I can tell.
>
> There are multiple interfaces to the SMU. It's shared by the entire SoC on
> APUs.
Just pointing that out because evidently this interface does not work on this
laptop, producing all-ones instead of something resembling a version number.
Which APU generations does this driver support? If it does not support Renoir
(yet?) it should be documented in the Kconfig text. Is Renoir support related
to missing AMD0005 ACPI id binding, and borked version number info?
Alexander
next prev parent reply other threads:[~2020-12-22 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 21:12 amd-pmc s2idle driver issues Alexander Monakov
2020-12-22 14:16 ` Deucher, Alexander
2020-12-22 14:45 ` Alexander Monakov
2020-12-22 15:20 ` Deucher, Alexander
2020-12-22 15:57 ` Alexander Monakov [this message]
2020-12-22 16:44 ` Deucher, Alexander
2020-12-22 17:25 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.2012221834180.10565@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=Alexander.Deucher@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).