linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 4.18 00/79] 4.18.1-stable review
@ 2018-08-15 17:24 Byron Stanoszek
  2018-08-15 17:32 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 9+ messages in thread
From: Byron Stanoszek @ 2018-08-15 17:24 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Kroah-Hartman, Thomas Gleixner

Hi Greg & Thomas,

I'd like to report a regression in Linux 4.18.1 regarding the L1TF patches.

The kernel no longer thinks I have SMT enabled in the BIOS. This works fine in
4.18.0.

Not sure if this matters, but in my particular 4-core system, my third core is
broken (core #2). So I must boot using "maxcpus=2" and then online the other
cores & SMT threads at startup using:

echo 1 > /sys/devices/system/cpu/cpu3/online
echo 1 > /sys/devices/system/cpu/cpu4/online
echo 1 > /sys/devices/system/cpu/cpu5/online
echo 1 > /sys/devices/system/cpu/cpu7/online

In 4.18.0, dmesg shows:

smpboot: Booting Node 0 Processor 3 APIC 0x6
smpboot: Booting Node 0 Processor 4 APIC 0x1
smpboot: Booting Node 0 Processor 5 APIC 0x3
smpboot: Booting Node 0 Processor 7 APIC 0x7

In 4.18.1, dmesg shows:

smpboot: Booting Node 0 Processor 3 APIC 0x6
smpboot: Booting Node 0 Processor 4 APIC 0x1
smpboot: CPU 4 is now offline
smpboot: Booting Node 0 Processor 5 APIC 0x3
smpboot: CPU 5 is now offline
smpboot: Booting Node 0 Processor 7 APIC 0x7
smpboot: CPU 7 is now offline

and I get an "Operation cancelled" error in the shell when trying to online 4,
5, and 7.

In 4.18.1, /sys/devices/system/cpu/smt/control says "notsupported".

  - - -

A possible second regression is the following:

My CPU normally runs at 3600 MHz. I usually run my CPU at 2800 MHz to keep from
overheating under full load (it is a fanless system). I do this by running
"echo 1 > /sys/class/thermal/cooling_device5/cur_state", and confirm with "cat
/proc/cpuinfo" (shows 2800).

This works in 4.18.0 but not in 4.18.1. I get no error from the "echo" command
(and the state reads back as "1"), but the CPU remains running at 3600 MHz.

Thanks,
  -Byron


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-15 17:24 [PATCH 4.18 00/79] 4.18.1-stable review Byron Stanoszek
@ 2018-08-15 17:32 ` Greg Kroah-Hartman
  2018-08-16  4:39   ` Byron Stanoszek
  0 siblings, 1 reply; 9+ messages in thread
From: Greg Kroah-Hartman @ 2018-08-15 17:32 UTC (permalink / raw)
  To: Byron Stanoszek; +Cc: linux-kernel, Thomas Gleixner

On Wed, Aug 15, 2018 at 01:24:25PM -0400, Byron Stanoszek wrote:
> Hi Greg & Thomas,
> 
> I'd like to report a regression in Linux 4.18.1 regarding the L1TF patches.
> 
> The kernel no longer thinks I have SMT enabled in the BIOS. This works fine in
> 4.18.0.
> 
> Not sure if this matters, but in my particular 4-core system, my third core is
> broken (core #2). So I must boot using "maxcpus=2" and then online the other
> cores & SMT threads at startup using:
> 
> echo 1 > /sys/devices/system/cpu/cpu3/online
> echo 1 > /sys/devices/system/cpu/cpu4/online
> echo 1 > /sys/devices/system/cpu/cpu5/online
> echo 1 > /sys/devices/system/cpu/cpu7/online
> 
> In 4.18.0, dmesg shows:
> 
> smpboot: Booting Node 0 Processor 3 APIC 0x6
> smpboot: Booting Node 0 Processor 4 APIC 0x1
> smpboot: Booting Node 0 Processor 5 APIC 0x3
> smpboot: Booting Node 0 Processor 7 APIC 0x7
> 
> In 4.18.1, dmesg shows:
> 
> smpboot: Booting Node 0 Processor 3 APIC 0x6
> smpboot: Booting Node 0 Processor 4 APIC 0x1
> smpboot: CPU 4 is now offline
> smpboot: Booting Node 0 Processor 5 APIC 0x3
> smpboot: CPU 5 is now offline
> smpboot: Booting Node 0 Processor 7 APIC 0x7
> smpboot: CPU 7 is now offline
> 
> and I get an "Operation cancelled" error in the shell when trying to online 4,
> 5, and 7.
> 
> In 4.18.1, /sys/devices/system/cpu/smt/control says "notsupported".
> 
>  - - -
> 
> A possible second regression is the following:
> 
> My CPU normally runs at 3600 MHz. I usually run my CPU at 2800 MHz to keep from
> overheating under full load (it is a fanless system). I do this by running
> "echo 1 > /sys/class/thermal/cooling_device5/cur_state", and confirm with "cat
> /proc/cpuinfo" (shows 2800).
> 
> This works in 4.18.0 but not in 4.18.1. I get no error from the "echo" command
> (and the state reads back as "1"), but the CPU remains running at 3600 MHz.

How about Linus's tree at the moment, is it ok there?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-15 17:32 ` Greg Kroah-Hartman
@ 2018-08-16  4:39   ` Byron Stanoszek
  2018-08-16 10:12     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 9+ messages in thread
From: Byron Stanoszek @ 2018-08-16  4:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Thomas Gleixner; +Cc: linux-kernel

On Wed, 15 Aug 2018, Greg Kroah-Hartman wrote:

> On Wed, Aug 15, 2018 at 01:24:25PM -0400, Byron Stanoszek wrote:
>> Hi Greg & Thomas,
>>
>> I'd like to report a regression in Linux 4.18.1 regarding the L1TF patches.
>>
>> The kernel no longer thinks I have SMT enabled in the BIOS. This works fine in
>> 4.18.0.
>>
>> Not sure if this matters, but in my particular 4-core system, my third core is
>> broken (core #2). So I must boot using "maxcpus=2" and then online the other
>> cores & SMT threads at startup using:
>>
>> echo 1 > /sys/devices/system/cpu/cpu3/online
>> echo 1 > /sys/devices/system/cpu/cpu4/online
>> echo 1 > /sys/devices/system/cpu/cpu5/online
>> echo 1 > /sys/devices/system/cpu/cpu7/online
>>
>> In 4.18.0, dmesg shows:
>>
>> smpboot: Booting Node 0 Processor 3 APIC 0x6
>> smpboot: Booting Node 0 Processor 4 APIC 0x1
>> smpboot: Booting Node 0 Processor 5 APIC 0x3
>> smpboot: Booting Node 0 Processor 7 APIC 0x7
>>
>> In 4.18.1, dmesg shows:
>>
>> smpboot: Booting Node 0 Processor 3 APIC 0x6
>> smpboot: Booting Node 0 Processor 4 APIC 0x1
>> smpboot: CPU 4 is now offline
>> smpboot: Booting Node 0 Processor 5 APIC 0x3
>> smpboot: CPU 5 is now offline
>> smpboot: Booting Node 0 Processor 7 APIC 0x7
>> smpboot: CPU 7 is now offline
>>
>> and I get an "Operation cancelled" error in the shell when trying to online 4,
>> 5, and 7.
>>
>> In 4.18.1, /sys/devices/system/cpu/smt/control says "notsupported".
>>
>>  - - -
>>
>> A possible second regression is the following:
>>
>> My CPU normally runs at 3600 MHz. I usually run my CPU at 2800 MHz to keep from
>> overheating under full load (it is a fanless system). I do this by running
>> "echo 1 > /sys/class/thermal/cooling_device5/cur_state", and confirm with "cat
>> /proc/cpuinfo" (shows 2800).
>>
>> This works in 4.18.0 but not in 4.18.1. I get no error from the "echo" command
>> (and the state reads back as "1"), but the CPU remains running at 3600 MHz.
>
> How about Linus's tree at the moment, is it ok there?
>
> thanks,
>
> greg k-h
>

It also fails in Linus's tree. Seems like this logic is to blame:

/*
  * If SMT was disabled by BIOS, detect it here, after the CPUs have been
  * brought online. This ensures the smt/l1tf sysfs entries are consistent
  * with reality. cpu_smt_available is set to true during the bringup of non
  * boot CPUs when a SMT sibling is detected. Note, this may overwrite
  * cpu_smt_control's previous setting.
  */
void __init cpu_smt_check_topology(void)
{
         if (!cpu_smt_available)
                 cpu_smt_control = CPU_SMT_NOT_SUPPORTED;
}

SMT is enabled in my BIOS, but because I booted with maxcpus=2, the init code
never officially booted any SMT thread yet--just primary threads. I suspect the
line 'cpu_smt_available = true;' in kernel/cpu.c function cpu_smt_allowed() is
never being reached.

It is then impossible to boot any SMT thread after init is done, since
'cpu_smt_available' is false.

The following test patch makes everything work for me on both mainline and
4.18.1, but we might as well throw out 'cpu_smt_available' altogether then (or
find another way to set it appropriately). Just because we didn't boot any SMT
threads at init shouldn't mean that SMT is disabled by the BIOS.

---

x86/l1tf: Fix booting with low maxcpus=# causes SMT to be disabled

If maxcpus=# is given on the kernel command line where # is too low for
any SMT CPU (thread) to be booted during init, then the kernel thinks
SMT is disabled by the BIOS. SMT threads are then unable to be manually
brought online later after init.

Set 'cpu_smt_available' early on in init instead, if
topology_smt_supported() returns true.

Fixes: 958f338e96f8 ("Merge branch 'l1tf-final' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip")
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Byron Stanoszek <gandalf@winds.org>
---
  kernel/cpu.c | 10 ++--------
  1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index ed44d7d34c2d..bf9be8b8c0a0 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -378,6 +378,8 @@ void __init cpu_smt_check_topology_early(void)
  {
  	if (!topology_smt_supported())
  		cpu_smt_control = CPU_SMT_NOT_SUPPORTED;
+	else
+		cpu_smt_available = true;
  }

  /*
@@ -405,14 +407,6 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
  	if (topology_is_primary_thread(cpu))
  		return true;

-	/*
-	 * If the CPU is not a 'primary' thread and the booted_once bit is
-	 * set then the processor has SMT support. Store this information
-	 * for the late check of SMT support in cpu_smt_check_topology().
-	 */
-	if (per_cpu(cpuhp_state, cpu).booted_once)
-		cpu_smt_available = true;
-
  	if (cpu_smt_control == CPU_SMT_ENABLED)
  		return true;

-- 
2.18.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-16  4:39   ` Byron Stanoszek
@ 2018-08-16 10:12     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2018-08-16 10:12 UTC (permalink / raw)
  To: Byron Stanoszek; +Cc: Thomas Gleixner, linux-kernel

On Thu, Aug 16, 2018 at 12:39:29AM -0400, Byron Stanoszek wrote:
> On Wed, 15 Aug 2018, Greg Kroah-Hartman wrote:
> 
> > On Wed, Aug 15, 2018 at 01:24:25PM -0400, Byron Stanoszek wrote:
> > > Hi Greg & Thomas,
> > > 
> > > I'd like to report a regression in Linux 4.18.1 regarding the L1TF patches.
> > > 
> > > The kernel no longer thinks I have SMT enabled in the BIOS. This works fine in
> > > 4.18.0.
> > > 
> > > Not sure if this matters, but in my particular 4-core system, my third core is
> > > broken (core #2). So I must boot using "maxcpus=2" and then online the other
> > > cores & SMT threads at startup using:
> > > 
> > > echo 1 > /sys/devices/system/cpu/cpu3/online
> > > echo 1 > /sys/devices/system/cpu/cpu4/online
> > > echo 1 > /sys/devices/system/cpu/cpu5/online
> > > echo 1 > /sys/devices/system/cpu/cpu7/online
> > > 
> > > In 4.18.0, dmesg shows:
> > > 
> > > smpboot: Booting Node 0 Processor 3 APIC 0x6
> > > smpboot: Booting Node 0 Processor 4 APIC 0x1
> > > smpboot: Booting Node 0 Processor 5 APIC 0x3
> > > smpboot: Booting Node 0 Processor 7 APIC 0x7
> > > 
> > > In 4.18.1, dmesg shows:
> > > 
> > > smpboot: Booting Node 0 Processor 3 APIC 0x6
> > > smpboot: Booting Node 0 Processor 4 APIC 0x1
> > > smpboot: CPU 4 is now offline
> > > smpboot: Booting Node 0 Processor 5 APIC 0x3
> > > smpboot: CPU 5 is now offline
> > > smpboot: Booting Node 0 Processor 7 APIC 0x7
> > > smpboot: CPU 7 is now offline
> > > 
> > > and I get an "Operation cancelled" error in the shell when trying to online 4,
> > > 5, and 7.
> > > 
> > > In 4.18.1, /sys/devices/system/cpu/smt/control says "notsupported".
> > > 
> > >  - - -
> > > 
> > > A possible second regression is the following:
> > > 
> > > My CPU normally runs at 3600 MHz. I usually run my CPU at 2800 MHz to keep from
> > > overheating under full load (it is a fanless system). I do this by running
> > > "echo 1 > /sys/class/thermal/cooling_device5/cur_state", and confirm with "cat
> > > /proc/cpuinfo" (shows 2800).
> > > 
> > > This works in 4.18.0 but not in 4.18.1. I get no error from the "echo" command
> > > (and the state reads back as "1"), but the CPU remains running at 3600 MHz.
> > 
> > How about Linus's tree at the moment, is it ok there?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> It also fails in Linus's tree. Seems like this logic is to blame:
> 
> /*
>  * If SMT was disabled by BIOS, detect it here, after the CPUs have been
>  * brought online. This ensures the smt/l1tf sysfs entries are consistent
>  * with reality. cpu_smt_available is set to true during the bringup of non
>  * boot CPUs when a SMT sibling is detected. Note, this may overwrite
>  * cpu_smt_control's previous setting.
>  */
> void __init cpu_smt_check_topology(void)
> {
>         if (!cpu_smt_available)
>                 cpu_smt_control = CPU_SMT_NOT_SUPPORTED;
> }
> 
> SMT is enabled in my BIOS, but because I booted with maxcpus=2, the init code
> never officially booted any SMT thread yet--just primary threads. I suspect the
> line 'cpu_smt_available = true;' in kernel/cpu.c function cpu_smt_allowed() is
> never being reached.
> 
> It is then impossible to boot any SMT thread after init is done, since
> 'cpu_smt_available' is false.
> 
> The following test patch makes everything work for me on both mainline and
> 4.18.1, but we might as well throw out 'cpu_smt_available' altogether then (or
> find another way to set it appropriately). Just because we didn't boot any SMT
> threads at init shouldn't mean that SMT is disabled by the BIOS.
> 
> ---
> 
> x86/l1tf: Fix booting with low maxcpus=# causes SMT to be disabled
> 
> If maxcpus=# is given on the kernel command line where # is too low for
> any SMT CPU (thread) to be booted during init, then the kernel thinks
> SMT is disabled by the BIOS. SMT threads are then unable to be manually
> brought online later after init.
> 
> Set 'cpu_smt_available' early on in init instead, if
> topology_smt_supported() returns true.
> 
> Fixes: 958f338e96f8 ("Merge branch 'l1tf-final' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip")
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Byron Stanoszek <gandalf@winds.org>
> ---
>  kernel/cpu.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Thomas is out for at least the rest of this week, so it might be a bit
before he sees this :(

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-14 17:16 Greg Kroah-Hartman
  2018-08-15  6:12 ` Greg Kroah-Hartman
  2018-08-15 13:16 ` Guenter Roeck
@ 2018-08-15 20:12 ` Dan Rue
  2 siblings, 0 replies; 9+ messages in thread
From: Dan Rue @ 2018-08-15 20:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, torvalds, akpm, linux, shuah, patches,
	ben.hutchings, lkft-triage, stable

On Tue, Aug 14, 2018 at 07:16:19PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.18.1 release.
> There are 79 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu Aug 16 17:13:16 UTC 2018.
> Anything received after that time might be too late.

Our systems are swamped with these RCs and mainline today, but since I
see these are being tagged I wanted to get results out based on the data
that we do have. We manually screened the results and will follow up if
we notice anything subsequently. Caveat applies to all stable branches.

Results from Linaro’s test farm.
No regressions on arm64, arm and x86_64.

Summary
------------------------------------------------------------------------

kernel: 4.18.1-rc2
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.18.y
git commit: 8105f76febd464c5c5cf4cd4647e42b724ed728c
git describe: v4.18-83-g8105f76febd4
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.18-oe/build/v4.18-83-g8105f76febd4


No regressions (compared to build v4.18)


Ran 15737 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_x86_64
- x15 - arm
- x86_64

Test Suites
-----------
* boot
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-containers-tests
* ltp-cve-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* ltp-open-posix-tests
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none

-- 
Linaro LKFT
https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-15 13:16 ` Guenter Roeck
@ 2018-08-15 15:32   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2018-08-15 15:32 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings,
	lkft-triage, stable

On Wed, Aug 15, 2018 at 06:16:14AM -0700, Guenter Roeck wrote:
> On 08/14/2018 10:16 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.18.1 release.
> > There are 79 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Thu Aug 16 17:13:16 UTC 2018.
> > Anything received after that time might be too late.
> > 
> 
> For v4.18-83-g8105f76:
> 
> Build results:
> 	total: 134 pass: 134 fail: 0
> Qemu test results:
> 	total: 302 pass: 302 fail: 0
> 
> Details are available at http://kerneltests.org/builders/.

Thanks for testing all of these, and for the fixes, and a lot for the
4.4 backports of these patches.

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-14 17:16 Greg Kroah-Hartman
  2018-08-15  6:12 ` Greg Kroah-Hartman
@ 2018-08-15 13:16 ` Guenter Roeck
  2018-08-15 15:32   ` Greg Kroah-Hartman
  2018-08-15 20:12 ` Dan Rue
  2 siblings, 1 reply; 9+ messages in thread
From: Guenter Roeck @ 2018-08-15 13:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman, linux-kernel
  Cc: torvalds, akpm, shuah, patches, ben.hutchings, lkft-triage, stable

On 08/14/2018 10:16 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.18.1 release.
> There are 79 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu Aug 16 17:13:16 UTC 2018.
> Anything received after that time might be too late.
> 

For v4.18-83-g8105f76:

Build results:
	total: 134 pass: 134 fail: 0
Qemu test results:
	total: 302 pass: 302 fail: 0

Details are available at http://kerneltests.org/builders/.

Guenter

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4.18 00/79] 4.18.1-stable review
  2018-08-14 17:16 Greg Kroah-Hartman
@ 2018-08-15  6:12 ` Greg Kroah-Hartman
  2018-08-15 13:16 ` Guenter Roeck
  2018-08-15 20:12 ` Dan Rue
  2 siblings, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2018-08-15  6:12 UTC (permalink / raw)
  To: linux-kernel
  Cc: torvalds, akpm, linux, shuah, patches, ben.hutchings,
	lkft-triage, stable

On Tue, Aug 14, 2018 at 07:16:19PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.18.1 release.
> There are 79 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu Aug 16 17:13:16 UTC 2018.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.18.1-rc1.gz

-rc2 is now out with some build fixes:
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.18.1-rc2.gz


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 4.18 00/79] 4.18.1-stable review
@ 2018-08-14 17:16 Greg Kroah-Hartman
  2018-08-15  6:12 ` Greg Kroah-Hartman
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2018-08-14 17:16 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches,
	ben.hutchings, lkft-triage, stable

This is the start of the stable review cycle for the 4.18.1 release.
There are 79 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu Aug 16 17:13:16 UTC 2018.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.18.1-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.18.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 4.18.1-rc1

Josh Poimboeuf <jpoimboe@redhat.com>
    x86/microcode: Allow late microcode loading with SMT disabled

David Woodhouse <dwmw@amazon.co.uk>
    tools headers: Synchronise x86 cpufeatures.h for L1TF additions

Andi Kleen <ak@linux.intel.com>
    x86/mm/kmmio: Make the tracer robust against L1TF

Andi Kleen <ak@linux.intel.com>
    x86/mm/pat: Make set_memory_np() L1TF safe

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Make pmd/pud_mknotpresent() invert

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Invert all not present mappings

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Fix SMT supported evaluation

Paolo Bonzini <pbonzini@redhat.com>
    KVM: VMX: Tell the nested hypervisor to skip L1D flush on vmentry

Paolo Bonzini <pbonzini@redhat.com>
    x86/speculation: Use ARCH_CAPABILITIES to skip L1D flush on vmentry

Paolo Bonzini <pbonzini@redhat.com>
    x86/speculation: Simplify sysfs report of VMX L1TF vulnerability

Thomas Gleixner <tglx@linutronix.de>
    Documentation/l1tf: Remove Yonah processors from not vulnerable list

Nicolai Stange <nstange@suse.de>
    x86/KVM/VMX: Don't set l1tf_flush_l1d from vmx_handle_external_intr()

Nicolai Stange <nstange@suse.de>
    x86/irq: Let interrupt handlers set kvm_cpu_l1tf_flush_l1d

Nicolai Stange <nstange@suse.de>
    x86: Don't include linux/irq.h from asm/hardirq.h

Nicolai Stange <nstange@suse.de>
    x86/KVM/VMX: Introduce per-host-cpu analogue of l1tf_flush_l1d

Nicolai Stange <nstange@suse.de>
    x86/irq: Demote irq_cpustat_t::__softirq_pending to u16

Nicolai Stange <nstange@suse.de>
    x86/KVM/VMX: Move the l1tf_flush_l1d test to vmx_l1d_flush()

Nicolai Stange <nstange@suse.de>
    x86/KVM/VMX: Replace 'vmx_l1d_flush_always' with 'vmx_l1d_flush_cond'

Nicolai Stange <nstange@suse.de>
    x86/KVM/VMX: Don't set l1tf_flush_l1d to true from vmx_l1d_flush()

Josh Poimboeuf <jpoimboe@redhat.com>
    cpu/hotplug: detect SMT disabled by BIOS

Tony Luck <tony.luck@intel.com>
    Documentation/l1tf: Fix typos

Nicolai Stange <nstange@suse.de>
    x86/KVM/VMX: Initialize the vmx_l1d_flush_pages' content

Jiri Kosina <jkosina@suse.cz>
    x86/speculation/l1tf: Unbreak !__HAVE_ARCH_PFN_MODIFY_ALLOWED architectures

Thomas Gleixner <tglx@linutronix.de>
    Documentation: Add section about CPU vulnerabilities

Jiri Kosina <jkosina@suse.cz>
    x86/bugs, kvm: Introduce boot-time control of L1TF mitigations

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Set CPU_SMT_NOT_SUPPORTED early

Jiri Kosina <jkosina@suse.cz>
    cpu/hotplug: Expose SMT control init function

Thomas Gleixner <tglx@linutronix.de>
    x86/kvm: Allow runtime control of L1D flush

Thomas Gleixner <tglx@linutronix.de>
    x86/kvm: Serialize L1D flush parameter setter

Thomas Gleixner <tglx@linutronix.de>
    x86/kvm: Add static key for flush always

Thomas Gleixner <tglx@linutronix.de>
    x86/kvm: Move l1tf setup function

Thomas Gleixner <tglx@linutronix.de>
    x86/l1tf: Handle EPT disabled state proper

Thomas Gleixner <tglx@linutronix.de>
    x86/kvm: Drop L1TF MSR list approach

Thomas Gleixner <tglx@linutronix.de>
    x86/litf: Introduce vmx status variable

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Online siblings when SMT control is turned on

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM/VMX: Use MSR save list for IA32_FLUSH_CMD if required

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM/VMX: Extend add_atomic_switch_msr() to allow VMENTER only MSRs

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM/VMX: Separate the VMX AUTOLOAD guest/host number accounting

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM/VMX: Add find_msr() helper function

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM/VMX: Split the VMX MSR LOAD structures to have an host/guest numbers

Paolo Bonzini <pbonzini@redhat.com>
    x86/KVM/VMX: Add L1D flush logic

Paolo Bonzini <pbonzini@redhat.com>
    x86/KVM/VMX: Add L1D MSR based flush

Paolo Bonzini <pbonzini@redhat.com>
    x86/KVM/VMX: Add L1D flush algorithm

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM/VMX: Add module argument for L1TF mitigation

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/KVM: Warn user if KVM is loaded SMT and L1TF CPU bug being present

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Boot HT siblings at least once

Thomas Gleixner <tglx@linutronix.de>
    Revert "x86/apic: Ignore secondary threads if nosmt=force"

Michal Hocko <mhocko@suse.cz>
    x86/speculation/l1tf: Fix up pte->pfn conversion for PAE

Vlastimil Babka <vbabka@suse.cz>
    x86/speculation/l1tf: Protect PAE swap entries against L1TF

Borislav Petkov <bp@suse.de>
    x86/CPU/AMD: Move TOPOEXT reenablement before reading smp_num_siblings

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/cpufeatures: Add detection of L1D cache flush support.

Vlastimil Babka <vbabka@suse.cz>
    x86/speculation/l1tf: Extend 64bit swap file size limit

Thomas Gleixner <tglx@linutronix.de>
    x86/apic: Ignore secondary threads if nosmt=force

Thomas Gleixner <tglx@linutronix.de>
    x86/cpu/AMD: Evaluate smp_num_siblings early

Borislav Petkov <bp@suse.de>
    x86/CPU/AMD: Do not check CPUID max ext level before parsing SMP info

Thomas Gleixner <tglx@linutronix.de>
    x86/cpu/intel: Evaluate smp_num_siblings early

Thomas Gleixner <tglx@linutronix.de>
    x86/cpu/topology: Provide detect_extended_topology_early()

Thomas Gleixner <tglx@linutronix.de>
    x86/cpu/common: Provide detect_ht_early()

Thomas Gleixner <tglx@linutronix.de>
    x86/cpu/AMD: Remove the pointless detect_ht() call

Thomas Gleixner <tglx@linutronix.de>
    x86/cpu: Remove the pointless CPU printout

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Provide knobs to control SMT

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Split do_cpu_down()

Thomas Gleixner <tglx@linutronix.de>
    cpu/hotplug: Make bringup/teardown of smp threads symmetric

Thomas Gleixner <tglx@linutronix.de>
    x86/topology: Provide topology_smt_supported()

Thomas Gleixner <tglx@linutronix.de>
    x86/smp: Provide topology_is_primary_thread()

Peter Zijlstra <peterz@infradead.org>
    sched/smt: Update sched_smt_present at runtime

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    x86/bugs: Move the l1tf function and define pr_fmt properly

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Limit swap file size to MAX_PA/2

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Disallow non privileged high MMIO PROT_NONE mappings

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Add sysfs reporting for l1tf

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Make sure the first page is always reserved

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Protect PROT_NONE PTEs against speculation

Linus Torvalds <torvalds@linux-foundation.org>
    x86/speculation/l1tf: Protect swap entries against L1TF

Linus Torvalds <torvalds@linux-foundation.org>
    x86/speculation/l1tf: Change order of offset/type in swap entry

Andi Kleen <ak@linux.intel.com>
    x86/speculation/l1tf: Increase 32bit PAE __PHYSICAL_PAGE_SHIFT

Nick Desaulniers <ndesaulniers@google.com>
    x86/irqflags: Provide a declaration for native_save_fl

Masami Hiramatsu <mhiramat@kernel.org>
    kprobes/x86: Fix %p uses in error messages

Jiri Kosina <jkosina@suse.cz>
    x86/speculation: Protect against userspace-userspace spectreRSB

Peter Zijlstra <peterz@infradead.org>
    x86/paravirt: Fix spectre-v2 mitigations for paravirt guests


-------------

Diffstat:

 Documentation/ABI/testing/sysfs-devices-system-cpu |  24 +
 Documentation/admin-guide/index.rst                |   9 +
 Documentation/admin-guide/kernel-parameters.txt    |  78 +++
 Documentation/admin-guide/l1tf.rst                 | 610 +++++++++++++++++++++
 Makefile                                           |   4 +-
 arch/Kconfig                                       |   3 +
 arch/x86/Kconfig                                   |   1 +
 arch/x86/include/asm/apic.h                        |   9 +
 arch/x86/include/asm/cpufeatures.h                 |   3 +
 arch/x86/include/asm/dmi.h                         |   2 +-
 arch/x86/include/asm/hardirq.h                     |  26 +-
 arch/x86/include/asm/irqflags.h                    |   2 +
 arch/x86/include/asm/kvm_host.h                    |   6 +
 arch/x86/include/asm/msr-index.h                   |   7 +
 arch/x86/include/asm/page_32_types.h               |   9 +-
 arch/x86/include/asm/pgtable-2level.h              |  17 +
 arch/x86/include/asm/pgtable-3level.h              |  37 +-
 arch/x86/include/asm/pgtable-invert.h              |  32 ++
 arch/x86/include/asm/pgtable.h                     |  74 ++-
 arch/x86/include/asm/pgtable_64.h                  |  38 +-
 arch/x86/include/asm/processor.h                   |  17 +
 arch/x86/include/asm/topology.h                    |   6 +-
 arch/x86/include/asm/vmx.h                         |  11 +
 arch/x86/kernel/apic/apic.c                        |  16 +
 arch/x86/kernel/apic/io_apic.c                     |   1 +
 arch/x86/kernel/apic/msi.c                         |   1 +
 arch/x86/kernel/apic/vector.c                      |   1 +
 arch/x86/kernel/cpu/amd.c                          |  51 +-
 arch/x86/kernel/cpu/bugs.c                         | 171 ++++--
 arch/x86/kernel/cpu/common.c                       |  56 +-
 arch/x86/kernel/cpu/cpu.h                          |   2 +
 arch/x86/kernel/cpu/intel.c                        |   7 +
 arch/x86/kernel/cpu/microcode/core.c               |  16 +-
 arch/x86/kernel/cpu/topology.c                     |  41 +-
 arch/x86/kernel/fpu/core.c                         |   1 +
 arch/x86/kernel/hpet.c                             |   1 +
 arch/x86/kernel/i8259.c                            |   1 +
 arch/x86/kernel/idt.c                              |   1 +
 arch/x86/kernel/irq.c                              |   1 +
 arch/x86/kernel/irq_32.c                           |   1 +
 arch/x86/kernel/irq_64.c                           |   1 +
 arch/x86/kernel/irqinit.c                          |   1 +
 arch/x86/kernel/kprobes/core.c                     |   5 +-
 arch/x86/kernel/paravirt.c                         |  14 +-
 arch/x86/kernel/setup.c                            |   6 +
 arch/x86/kernel/smp.c                              |   1 +
 arch/x86/kernel/smpboot.c                          |  18 +
 arch/x86/kernel/time.c                             |   1 +
 arch/x86/kvm/mmu.c                                 |   1 +
 arch/x86/kvm/vmx.c                                 | 455 ++++++++++++---
 arch/x86/kvm/x86.c                                 |  34 +-
 arch/x86/mm/init.c                                 |  23 +
 arch/x86/mm/kmmio.c                                |  25 +-
 arch/x86/mm/mmap.c                                 |  21 +
 arch/x86/mm/pageattr.c                             |   8 +-
 arch/x86/mm/pti.c                                  |   1 +
 .../intel-mid/device_libs/platform_mrfld_wdt.c     |   1 +
 arch/x86/platform/uv/tlb_uv.c                      |   1 +
 arch/x86/xen/enlighten.c                           |   1 +
 drivers/base/cpu.c                                 |   8 +
 drivers/gpu/drm/i915/i915_pmu.c                    |   1 +
 drivers/gpu/drm/i915/intel_lpe_audio.c             |   1 +
 drivers/pci/controller/pci-hyperv.c                |   1 +
 include/asm-generic/pgtable.h                      |  12 +
 include/linux/cpu.h                                |  21 +
 include/linux/swapfile.h                           |   2 +
 kernel/cpu.c                                       | 280 +++++++++-
 kernel/sched/core.c                                |  30 +-
 kernel/sched/fair.c                                |   1 +
 kernel/smp.c                                       |   2 +
 mm/memory.c                                        |  37 +-
 mm/mprotect.c                                      |  49 ++
 mm/swapfile.c                                      |  46 +-
 tools/arch/x86/include/asm/cpufeatures.h           |   3 +
 74 files changed, 2206 insertions(+), 300 deletions(-)



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-08-16 10:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 17:24 [PATCH 4.18 00/79] 4.18.1-stable review Byron Stanoszek
2018-08-15 17:32 ` Greg Kroah-Hartman
2018-08-16  4:39   ` Byron Stanoszek
2018-08-16 10:12     ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2018-08-14 17:16 Greg Kroah-Hartman
2018-08-15  6:12 ` Greg Kroah-Hartman
2018-08-15 13:16 ` Guenter Roeck
2018-08-15 15:32   ` Greg Kroah-Hartman
2018-08-15 20:12 ` Dan Rue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).