* [PATCH 2/7] drivers: nubus: Avoids building driver if CONFIG_NUBUS is disabled
@ 2018-09-26 1:52 Leonardo Brás
2018-09-26 6:45 ` Finn Thain
0 siblings, 1 reply; 2+ messages in thread
From: Leonardo Brás @ 2018-09-26 1:52 UTC (permalink / raw)
To: lkcamp
Cc: Alexander Shishkin, Finn Thain, Robert Richter,
James E.J. Bottomley, Helge Deller, Martin Schwidefsky,
Heiko Carstens, Geert Uytterhoeven, linux-kernel, linux-m68k,
oprofile-list, linux-parisc, linux-s390
Avoids building driver if 'make drivers/nubus/' is called and
CONFIG_NUBUS is disabled.
Avoids building proc.o if CONFIG_PROC_FS is enabled but
CONFIG_NUBUS is disabled.
Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
---
drivers/nubus/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nubus/Makefile b/drivers/nubus/Makefile
index 6d063cde39d1..827301c4a84f 100644
--- a/drivers/nubus/Makefile
+++ b/drivers/nubus/Makefile
@@ -2,6 +2,6 @@
# Makefile for the nubus specific drivers.
#
-obj-y := nubus.o bus.o
-
-obj-$(CONFIG_PROC_FS) += proc.o
+obj-$(CONFIG_NUBUS) := nubus.o
+nubus-y := bus.o
+nubus-$(CONFIG_PROC_FS) += proc.o
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/7] drivers: nubus: Avoids building driver if CONFIG_NUBUS is disabled
2018-09-26 1:52 [PATCH 2/7] drivers: nubus: Avoids building driver if CONFIG_NUBUS is disabled Leonardo Brás
@ 2018-09-26 6:45 ` Finn Thain
0 siblings, 0 replies; 2+ messages in thread
From: Finn Thain @ 2018-09-26 6:45 UTC (permalink / raw)
To: Leonardo Bras
Cc: lkcamp, Alexander Shishkin, Robert Richter, James E.J. Bottomley,
Helge Deller, Martin Schwidefsky, Heiko Carstens,
Geert Uytterhoeven, linux-kernel, linux-m68k, oprofile-list,
linux-parisc, linux-s390
On Tue, 25 Sep 2018, Leonardo Bras wrote:
> Avoids building driver if 'make drivers/nubus/' is called and
> CONFIG_NUBUS is disabled.
> Avoids building proc.o if CONFIG_PROC_FS is enabled but
> CONFIG_NUBUS is disabled.
>
> Signed-off-by: Leonardo Bras <leobras.c@gmail.com>
> ---
> drivers/nubus/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nubus/Makefile b/drivers/nubus/Makefile
> index 6d063cde39d1..827301c4a84f 100644
> --- a/drivers/nubus/Makefile
> +++ b/drivers/nubus/Makefile
> @@ -2,6 +2,6 @@
> # Makefile for the nubus specific drivers.
> #
>
> -obj-y := nubus.o bus.o
> -
> -obj-$(CONFIG_PROC_FS) += proc.o
> +obj-$(CONFIG_NUBUS) := nubus.o
> +nubus-y := bus.o
> +nubus-$(CONFIG_PROC_FS) += proc.o
>
Did you build this for m68k? It doesn't link for me.
MODPOST vmlinux.o
drivers/nubus/bus.o: In function `nubus_device_release':
bus.c:(.text+0xd0): undefined reference to `nubus_func_rsrcs'
bus.c:(.text+0xe0): undefined reference to `nubus_func_rsrcs'
bus.c:(.text+0x118): undefined reference to `nubus_func_rsrcs'
bus.c:(.text+0xc2): undefined reference to `nubus_func_rsrcs'
drivers/nubus/proc.o: In function `nubus_devices_proc_show':
proc.c:(.text+0xa): undefined reference to `nubus_first_rsrc_or_null'
proc.c:(.text+0x1c): undefined reference to `nubus_next_rsrc_or_null'
drivers/nubus/proc.o: In function `nubus_proc_rsrc_show':
proc.c:(.text+0x190): undefined reference to `nubus_seq_write_rsrc_mem'
drivers/nubus/proc.o: In function `nubus_proc_add_rsrc_mem':
proc.c:(.text+0x24c): undefined reference to `nubus_dirptr'
Patch 4/7 (drivers/zorro) also causes 'undefined reference' errors. I
didn't test the others.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-26 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 1:52 [PATCH 2/7] drivers: nubus: Avoids building driver if CONFIG_NUBUS is disabled Leonardo Brás
2018-09-26 6:45 ` Finn Thain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).