* [PATCH] libata: increase the timeout when setting transfer mode
@ 2015-07-08 17:06 Mikulas Patocka
2015-07-15 15:57 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Mikulas Patocka @ 2015-07-08 17:06 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, linux-kernel
I have a ST4000DM000 disk. If Linux is booted while the disk is spun down,
the command that sets transfer mode causes the disk to spin up. The
spin-up takes longer than the default 5s timeout, so the command fails and
timeout is reported.
Fix this by increasing the timeout to 15s, which is enough for the disk to
spin up.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
---
drivers/ata/libata-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-4.1.1/drivers/ata/libata-core.c
===================================================================
--- linux-4.1.1.orig/drivers/ata/libata-core.c 2015-07-07 22:21:39.962112941 +0200
+++ linux-4.1.1/drivers/ata/libata-core.c 2015-07-08 18:59:03.852951057 +0200
@@ -4501,7 +4501,8 @@ static unsigned int ata_dev_set_xfermode
else /* In the ancient relic department - skip all of this */
return 0;
- err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 0);
+ /* On some disks, this command causes spin-up, so we need longer timeout */
+ err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 15000);
DPRINTK("EXIT, err_mask=%x\n", err_mask);
return err_mask;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: increase the timeout when setting transfer mode
2015-07-08 17:06 [PATCH] libata: increase the timeout when setting transfer mode Mikulas Patocka
@ 2015-07-15 15:57 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2015-07-15 15:57 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: linux-ide, linux-kernel
On Wed, Jul 08, 2015 at 01:06:12PM -0400, Mikulas Patocka wrote:
> I have a ST4000DM000 disk. If Linux is booted while the disk is spun down,
> the command that sets transfer mode causes the disk to spin up. The
> spin-up takes longer than the default 5s timeout, so the command fails and
> timeout is reported.
>
> Fix this by increasing the timeout to 15s, which is enough for the disk to
> spin up.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Cc: stable@vger.kernel.org
Applied to libata/for-4.2-fixes.
Thanks!
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-15 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-08 17:06 [PATCH] libata: increase the timeout when setting transfer mode Mikulas Patocka
2015-07-15 15:57 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).